Support accounts-dod as account endpoint #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreyas-goenka
approved these changes
Jun 27, 2023
| return true | ||
| } | ||
| } | ||
| return c.AccountID != "" && c.isTesting |
There was a problem hiding this comment.
Can you make this case return early since this is a special condition?
if c.AccountID != "" && c.isTesting {
return true
}
3 tasks
mgyucht
added a commit
that referenced
this pull request
Jun 27, 2023
## Changes #530 merged before addressing one style issue from @shreyas-goenka. ## Tests <!-- How is this tested? Please see the checklist below and also describe any other relevant tests --> - [ ] `make test` passing - [ ] `make fmt` applied - [ ] relevant integration tests applied
Merged
mgyucht
added a commit
that referenced
this pull request
Jun 28, 2023
## Changes * Regenerated from OpenAPI spec ([#527](#527)). Includes bugfixes for System Tables. * Support accounts-dod as account endpoint ([#530](#530)). Breaking API Changes: - Renamed compute.ClusterInfo to compute.ClusterDetails - Renamed compue.BaseClusterInfo to compute.ClusterSpec - Renamed jobs.RunSubmitTaskSettings to jobs.SubmitTask - Renamed jobs.JobTaskSettings to jobs.Task - Renamed jobs.CreateJobFormat to jobs.Format - Renamed jobs.JobsWebhookNotifications to jobs.WebhookNotifications - Renamed jobs.CronSchedulePauseStatus to jobs.PauseStatus - Renamed jobs.FileArrivalTriggerSettings to jobs.FileArrivalTriggerConfiguration - Renamed jobs.GitSourceGitProvider to jobs.GitProvider - Consolidated jobs.NotebookTaskSource, jobs.SparkPythonTaskSource to jobs.Source - Consolidated jobs.JobWebhookNotificationsOnFailureItem, jobs.JobWebhookNotificationsOnStartItem, jobs.JobWebhookNotificationsOnSuccessItem to jobs.Webhook - Renamed jobs.TaskDependenciesItem to job.TaskDependency - jobs.SparkSubmitTask.Widgets changed from *SqlDashboardWidgetOutput to []SqlDashboardWidgetOutput - (a *SystemSchemasAPI) DisableByMetastoreIdAndSchemaName changed from func(context.Context, string, string) error to func(context.Context, string, DisableSchemaName) error - (a *SystemSchemasAPI) Enable changed from func(context.Context) error to func(context.Context, EnableRequest) error - catalog.CatalogInfo.OptionsKvpairs changed from *OptionsKvPairs to map[string]string - catalog.CreateConnection.OptionsKvpairs changed from *OptionsKvPairs to map[string]string - catalog.UpdateConnection.OptionsKvpairs changed from OptionsKvPairs to map[string]string - catalog.DisableRequest.SchemaName changed from string to DisableSchemaName - catalog.OptionsKvPairs removed - catalog.SystemSchemaInfoStateDisableinitialized renamed to catalog.SystemSchemaInfoStateDisabledInitialized - catalog.SystemSchemaInfoStateEnabledcompleted renamed to catalog.SystemSchemaInfoStateEnabledCompleted - catalog.SystemSchemaInfoStateEnabledinitialized renamed to catalog.SystemSchemaInfoStateEnabledInitialized - settings.ReadPersonalComputeSettingsResponse renamed to settings.PersonalComputeSetting - workpace.CreateScope.KeyvaultMetadata removed Other API Changes: - catalog.CatalogInfo.ConnectionName added - catalog.CatalogInfo.Options added - catalog.DisableSchemaName added - catalog.EnableRequest added - catalog.PrivilegeUseMarketplaceAssets added - compute.ClusterEvent added - compute.ComputeSpec added - compute.ComputeSpecKind added - jobs.ConditionTask added - jobs.ConditionTaskOp added - jobs.CreateJob.Compute added - jobs.JobCompute added - jobs.JobSettings.Compute added - jobs.RunConditionTask added - jobs.RunOutput.ConditionTask added - jobs.RunTask.ConditionTask added - serving.ServedModelInput.EnvironmentVars added - serving.ServedModelOutput.EnvironmentVars added - settings.DeletePersonalComputeSetting added - settings.UpdatePersonalComputeSetting added - sharing.PrivilegeUseMarketplaceAssets added - workspace.CreateScope.BackendAzureKeyVault added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Modify IsAccountClient to return
truefor new accounts endpoints that are set up for the Department of Defense.Resolves databricks/terraform-provider-databricks#2433 once TF provider is updated to a version including this commit.
Tests
make testpassingmake fmtapplied