Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Support account-level operations in DOD environments #2433

Closed
mgyucht opened this issue Jun 27, 2023 · 0 comments · Fixed by databricks/databricks-sdk-go#530
Closed

[FEATURE] Support account-level operations in DOD environments #2433

mgyucht opened this issue Jun 27, 2023 · 0 comments · Fixed by databricks/databricks-sdk-go#530
Labels
feature New feature or request

Comments

@mgyucht
Copy link
Contributor

mgyucht commented Jun 27, 2023

Use-cases

Today, Databricks operates an accounts service in public clouds for management of an E2 Databricks account. To identify whether the Terraform provider is connected to an E2 account or a workspace (needed for SCIM APIs which can be used at both the workspace and account levels), the provider checks whether the configured hostname starts with "https://accounts." Accounts endpoints which don't match that scheme (like "https://accounts-dod.cloud.databricks.us") cannot use account-level SCIM APIs.

Attempted Solutions

Proposal

Widen the check for accounts-level services to check for both "https://accounts." and "https://accounts-dod.".

References
@mgyucht mgyucht added the feature New feature or request label Jun 27, 2023
@mgyucht mgyucht mentioned this issue Jun 27, 2023
Merged
4 tasks
mgyucht added a commit to databricks/databricks-sdk-go that referenced this issue Jun 27, 2023
@mgyucht
Support accounts-dod as account endpoint (#530)
feb05af 
## Changes
Modify IsAccountClient to return `true` for new accounts endpoints that
are set up for the Department of Defense.

Resolves
databricks/terraform-provider-databricks#2433
once TF provider is updated to a version including this commit.

## Tests
- [x] Added a unit test to cover IsAccountClient().
- [x] `make test` passing
- [x] `make fmt` applied
- [ ] relevant integration tests applied
@mgyucht mgyucht reopened this Jun 27, 2023
@mgyucht mgyucht closed this as completed Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support accounts-dod as account endpoint databricks/databricks-sdk-go
1 participant
@mgyucht