[Fix] Stop pagination on empty next page token #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hectorcast-db
force-pushed
the
fix-pagination
branch
from
ba90c60
to
5a78363
Compare
mgyucht
reviewed
Sep 9, 2024
There was a problem hiding this comment.
Even though we are depending on a library that exposes this functionality, would you mind changing this to token == null || token.isEmpty()? It's exactly what is done in the Google library, but it means we don't depend on Google for this, minimizing the surface area of external libraries we depend on.
hectorcast-db
force-pushed
the
fix-pagination
branch
from
5a78363
to
1a5820b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Stop pagination on empty next page token
Tests