[PECO-1356] Removed protocol check in GO #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nithinkdb
requested review from
susodapop,
yunbodeng-db,
andrefurlan-db,
rcypher-databricks and
jadewang-db
as code owners
susodapop
reviewed
Dec 26, 2023
| @@ -112,9 +112,6 @@ func (c *conn) ExecContext(ctx context.Context, query string, args []driver.Name | |||
| defer log.Duration(msg, start) | |||
|
|
|||
| corrId := driverctx.CorrelationIdFromContext(ctx) | |||
| if len(args) > 0 && c.session.ServerProtocolVersion < cli_service.TProtocolVersion_SPARK_CLI_SERVICE_PROTOCOL_V8 { | |||
| return nil, dbsqlerrint.NewDriverError(ctx, dbsqlerr.ErrParametersNotSupported, nil) | |||
There was a problem hiding this comment.
Should we also remove ErrParametersNotSupported from dbsqlerr?
There was a problem hiding this comment.
I was considering leaving it in just in case we reintroduce the check at some point.
jadewang-db
approved these changes
Dec 28, 2023
Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
nithinkdb
force-pushed
the
nithinkdb/PECO-1356
branch
from
1408364
to
1648935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Customers have reached out in Node and GO about protocol versioning not being correctly reflected by the server. We've decided to revert these changes in Node, this PR does the same for GO.