allow-table-extended-to-handle-more-than-2048-chars (#326) #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcypher-databricks
previously approved these changes
May 2, 2023
|
Hi @andrefurlan-db! Sorry to tag you here but was just wondering: when can we expect this change to be merged, please? |
|
Any update on when we can expect to see this fix implemented? @rcypher-databricks @andrefurlan-db ? |
<!-- Please review our pull request review process in CONTRIBUTING.md before your proceed. --> Resolves [#326](#326) <!--- Include the number of the issue addressed by this PR above if applicable. Example: resolves #1234 Please review our pull request review process in CONTRIBUTING.md before your proceed. --> ### Description This PR allows the adapter to handle strings of more than 2048 characters when running show tables extended in Databricks. This is currently preventing users from being able to run this command when using dbt if they have a large number of tables in any given schema. The way this is done is that it will pass the `*` in instances where the string length of the pipe separated tables is more than 2048 chars. I have successfully tested both unit tests and `tox -e integration-databricks-sql-endpoint`. ### Checklist - [x] I have run this code in development and it appears to resolve the stated issue - [x] This PR includes tests, or tests are not required/relevant for this PR - [x] I have updated the `CHANGELOG.md` and added information about my change to the "dbt-databricks next" section.
susodapop
temporarily deployed
to
azure-prod-peco
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-pecou
GitHub Actions
Inactive
|
This went stale because of inattention. But the change has been approved. I just rebased the branch off of main so we can rerun the integration tests. Will merge once these pass. |
susodapop
temporarily deployed
to
azure-prod-pecou
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-peco
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-pecou
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-peco
GitHub Actions
Inactive
Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com>
susodapop
temporarily deployed
to
azure-prod-pecou
GitHub Actions
Inactive
susodapop
temporarily deployed
to
azure-prod-peco
GitHub Actions
Inactive
benc-db
pushed a commit
to benc-db/dbt-databricks
that referenced
this pull request
Jul 27, 2023
) (databricks#330) Signed-off-by: Jesse Whitehouse <jesse.whitehouse@databricks.com> Co-authored-by: Joe Berni <99652623+josephberni@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #326
Description
This PR allows the adapter to handle strings of more than 2048 characters when running show tables extended in Databricks. This is currently preventing users from being able to run this command when using dbt if they have a large number of tables in any given schema.
The way this is done is that it will pass the
*in instances where the string length of the pipe separated tables is more than 2048 chars.I have successfully tested both unit tests and
tox -e integration-databricks-sql-endpoint.Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.