This repository was archived by the owner on Mar 24, 2025. It is now read-only.
Change default values for valueTag and attributePrefix to avoid always require field escape for some apis. #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r valueTag and attributePrefix
Current coverage is 90.39% (diff: 100%)@@ master #142 diff @@
==========================================
Files 14 14
Lines 677 677
Methods 614 614
Messages 0 0
Branches 63 63
==========================================
Hits 612 612
Misses 65 65
Partials 0 0
|
HyukjinKwon
changed the title
HyukjinKwon
changed the title
Member
Author
|
I am going to merge this. |
Closed
HyukjinKwon
added a commit
that referenced
this pull request
Sep 10, 2016
This PR prepares the release for 0.4.0. This will include the changes below: - Support for PERMISSIVE/DROPMALFORMED mode and corrupt record option. #107 - Change default values for valueTag and attributePrefix to avoid always require field escape for some apis #142 - deprecates saveAsXmlFile and promote the usage of write(). #150 - deprecates xmlFile and promote the usage of read(). #150 - drops 1.x compatibility from 0.4.0. #150 - makes not supporting UserDefinedType as it became private. #150 Author: hyukjinkwon <gurwls223@gmail.com> Closes #176 from HyukjinKwon/version-0.4.0.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#123
This simply changes the default values in
valueTagandattributePrefixdue to some problems. Please refer the issue above for more details.This PR also adds the test for default values for them. They were not being tested.