Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] Terraform Meta Block "timeouts" Reporting as Unsupported #1142

Closed
HamiltonHord opened this issue Feb 25, 2022 · 4 comments · Fixed by #1159
Closed

[ISSUE] Terraform Meta Block "timeouts" Reporting as Unsupported #1142

HamiltonHord opened this issue Feb 25, 2022 · 4 comments · Fixed by #1159

Comments

@HamiltonHord
Copy link

Hi there,

Configuration

resource "databricks_sql_endpoint" "endpoint" {
  name                 = "endpoint"
  cluster_size         = "2X-Large"
  min_num_clusters     = 0
  max_num_clusters     = 7
  auto_stop_mins       = 30
  spot_instance_policy = "COST_OPTIMIZED"

  enable_serverless_compute = true

  instance_profile_arn = databricks_instance_profile.iam_profiles["example"].id

  timeouts {
    create = "30m"
  }
}

Expected Behavior

Should have used the extra Terraform resource meta argument and extended the creation timeout built into terraform.

Actual Behavior

Error message from terraform:

Error: Unsupported block type

  on modules/east1_workspace/sql_endpoints.tf line 24, in resource "databricks_sql_endpoint" "looker_e1":
  24:   timeouts {

Blocks of type "timeouts" are not expected here.

Steps to Reproduce

Please list the steps required to reproduce the issue, for example:

  1. terraform plan

Terraform and provider versions

$ terraform -v
Terraform v0.13.7

  • provider registry.terraform.io/databrickslabs/databricks v0.5.0
  • provider registry.terraform.io/hashicorp/aws v3.74.0

Debug Output

Please add turn on logging, e.g. TF_LOG=DEBUG terraform apply and run command again, paste it to gist & provide the link to gist. If you're still willing to paste in log output, make sure you provide only relevant log lines with requests.

It would make it more readable, if you pipe the log through | grep databricks | sed -E 's/^.* plugin[^:]+: (.*)$/\1/', e.g.:

TF_LOG=DEBUG terraform plan 2>&1 | grep databricks | sed -E 's/^.* plugin[^:]+: (.*)$/\1/'

If Terraform produced a panic, please provide a link to a GitHub Gist containing the output of the crash.log.

Important Factoids

Are there anything atypical about your accounts that we should know?
N/A

@alexott
Copy link
Contributor

alexott commented Feb 26, 2022

there is no support for such block in SQL Endpoints - refer to documentation for supported parameters. The Terraform documentation says that "some resources" support it, not "all resources" support it.

Please file feature request, or better, PR if you need such functionality.

@alexott alexott closed this as completed Feb 26, 2022
@nfx nfx reopened this Feb 26, 2022
@nfx
Copy link
Contributor

nfx commented Feb 26, 2022

@alexott sql endpoints did actually suppose to have working timeouts, this is something to investigate for next week

@kuntalkumarbasu
Copy link

kuntalkumarbasu commented Mar 2, 2022

there is no support for such block in SQL Endpoints - refer to documentation for supported parameters. The Terraform documentation says that "some resources" support it, not "all resources" support it.

Please file feature request, or better, PR if you need such functionality.

@alexott As per the document you shared the timeout is supported. Can you please double check

@nfx
Copy link
Contributor

nfx commented Mar 3, 2022

@kuntalkumarbasu we'll investigate this as soon as we can. stay tuned.

nfx added a commit that referenced this issue Mar 7, 2022
Previously, `timeout` meta-block was documented, but resulting in error. It was due to `Timeouts: &schema.ResourceTimeout` not added on resource.

Fixes #1142
@nfx nfx closed this as completed in #1159 Mar 7, 2022
nfx added a commit that referenced this issue Mar 7, 2022
Previously, `timeout` meta-block was documented, but resulting in error. It was due to `Timeouts: &schema.ResourceTimeout` not added on resource.

Fixes #1142
@nfx nfx mentioned this issue Mar 7, 2022
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this issue Feb 15, 2023
Previously, `timeout` meta-block was documented, but resulting in error. It was due to `Timeouts: &schema.ResourceTimeout` not added on resource.

Fixes databricks#1142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants