Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix databricks_sql_endpoint timeout propagation #1159

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Fix databricks_sql_endpoint timeout propagation #1159

merged 1 commit into from
Mar 7, 2022

Conversation

nfx
Copy link
Contributor

@nfx nfx commented Mar 7, 2022

Previously, timeout meta-block was documented, but resulting in error. It was due to Timeouts: &schema.ResourceTimeout not added on resource.

Fixes #1142

Previously, `timeout` meta-block was documented, but resulting in error. It was due to `Timeouts: &schema.ResourceTimeout` not added on resource.

Fixes #1142
@nfx nfx requested a review from alexott March 7, 2022 14:12
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #1159 (c549b33) into master (e2203b1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1159   +/-   ##
=======================================
  Coverage   90.83%   90.84%           
=======================================
  Files         117      117           
  Lines        9736     9739    +3     
=======================================
+ Hits         8844     8847    +3     
  Misses        526      526           
  Partials      366      366           
Impacted Files Coverage Δ
sql/resource_sql_endpoint.go 97.50% <100.00%> (+0.09%) ⬆️

@nfx nfx merged commit c8a4813 into master Mar 7, 2022
@nfx nfx deleted the issue/1142 branch March 7, 2022 14:26
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
Previously, `timeout` meta-block was documented, but resulting in error. It was due to `Timeouts: &schema.ResourceTimeout` not added on resource.

Fixes databricks#1142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Terraform Meta Block "timeouts" Reporting as Unsupported
2 participants