-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expand documentation for databricks_sql_query
resource
#1603
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thank you @alexott, anything else i need to do on my end for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crankswagon thank you for keeping docs sane! :)
- please separate make fmt-doc and sql query improvements into two separate PRs
- once you rebase on the latest master, i'll merge the pr
3061cfe
to
911f8b7
Compare
no worries at all :) i've limited this PR to just the other linting changes have been moved to #1606 both have been rebased on the latest master 👍 |
@crankswagon previous PR merged, please rebase this one again |
Revert "expand `parameter` documentation for `databricks_sql_query` resource" This reverts commit 3061cfe. expand docs
911f8b7
to
c7d96da
Compare
@nfx thank you, rebased just now 👍 |
# Version changelog ## 1.3.1 * Added autoscale `mode` configuration to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#1600](#1600)). * Fixed `gcp_availability` field in [databricks_insance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/insance_pool) resource ([#1610](#1610)). * Fixed `secret` field name in [databricks_mlflow_webhook](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mlflow_webhook) resource ([#1625](#1625)). * Further improvements of exporter ([#1602](#1602)). Documentation improvements: * Updates for [databricks_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/table) and [databricks_mws_vpc_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_vpc_endpoint) ([#1616](#1616)). * Document `http_timeout_seconds` from `common/client.go` ([#1599](#1599)). * Expand `parameter` documentation for [databricks_sql_query](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_query) resource ([#1603](#1603)). * Updated Unity Catalog docs ([#1605](#1605), [#1626](#1626), [#1620](#1620)). Updated dependency versions: * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.21.0 to 2.23.0 ([#1597](#1597), [#1611](#1611)). * Bump google.golang.org/api from 0.94.0 to 0.96.0 ([#1598](#1598), [#1612](#1612)).
# Version changelog ## 1.3.1 * Added autoscale `mode` configuration to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#1600](#1600)). * Fixed `gcp_availability` field in [databricks_insance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/insance_pool) resource ([#1610](#1610)). * Fixed `secret` field name in [databricks_mlflow_webhook](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mlflow_webhook) resource ([#1625](#1625)). * Further improvements of exporter ([#1602](#1602)). Documentation improvements: * Updates for [databricks_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/table) and [databricks_mws_vpc_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_vpc_endpoint) ([#1616](#1616)). * Document `http_timeout_seconds` from `common/client.go` ([#1599](#1599)). * Expand `parameter` documentation for [databricks_sql_query](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_query) resource ([#1603](#1603)). * Updated Unity Catalog docs ([#1605](#1605), [#1626](#1626), [#1620](#1620)). Updated dependency versions: * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.21.0 to 2.23.0 ([#1597](#1597), [#1611](#1611)). * Bump google.golang.org/api from 0.94.0 to 0.96.0 ([#1598](#1598), [#1612](#1612)).
# Version changelog ## 1.3.1 * Added autoscale `mode` configuration to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([databricks#1600](databricks#1600)). * Fixed `gcp_availability` field in [databricks_insance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/insance_pool) resource ([databricks#1610](databricks#1610)). * Fixed `secret` field name in [databricks_mlflow_webhook](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mlflow_webhook) resource ([databricks#1625](databricks#1625)). * Further improvements of exporter ([databricks#1602](databricks#1602)). Documentation improvements: * Updates for [databricks_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/table) and [databricks_mws_vpc_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_vpc_endpoint) ([databricks#1616](databricks#1616)). * Document `http_timeout_seconds` from `common/client.go` ([databricks#1599](databricks#1599)). * Expand `parameter` documentation for [databricks_sql_query](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_query) resource ([databricks#1603](databricks#1603)). * Updated Unity Catalog docs ([databricks#1605](databricks#1605), [databricks#1626](databricks#1626), [databricks#1620](databricks#1620)). Updated dependency versions: * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.21.0 to 2.23.0 ([databricks#1597](databricks#1597), [databricks#1611](databricks#1611)). * Bump google.golang.org/api from 0.94.0 to 0.96.0 ([databricks#1598](databricks#1598), [databricks#1612](databricks#1612)).
changes to
databricks_sql_query
resource documentationparameter
blocks to make it easier for usersinternal server errors
other changesgeneral linting for/docs
so new contributors should not longer seehcl
parse errors when runningmake fmt-docs
linting moved to #1606