Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix secret field name in databricks_mlflow_webhook resource #1625

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Conversation

alexott
Copy link
Contributor

@alexott alexott commented Sep 21, 2022

fixes #1621

@alexott alexott requested a review from a team September 21, 2022 06:33
@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@df280ff). Click here to learn what that means.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1625   +/-   ##
=========================================
  Coverage          ?   90.05%           
=========================================
  Files             ?      135           
  Lines             ?    10825           
  Branches          ?        0           
=========================================
  Hits              ?     9748           
  Misses            ?      688           
  Partials          ?      389           
Impacted Files Coverage Δ
mlflow/resource_mlflow_webhook.go 100.00% <ø> (ø)

@nfx nfx enabled auto-merge (squash) September 21, 2022 08:23
@nfx nfx merged commit bc24f3c into master Sep 21, 2022
@nfx nfx mentioned this pull request Sep 23, 2022
nfx added a commit that referenced this pull request Sep 23, 2022
# Version changelog

## 1.3.1

 * Added autoscale `mode` configuration to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#1600](#1600)).
 * Fixed `gcp_availability` field in [databricks_insance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/insance_pool) resource ([#1610](#1610)).
 * Fixed `secret` field name in [databricks_mlflow_webhook](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mlflow_webhook) resource ([#1625](#1625)).
 * Further improvements of exporter ([#1602](#1602)).

 Documentation improvements:
 
 * Updates for [databricks_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/table) and [databricks_mws_vpc_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_vpc_endpoint) ([#1616](#1616)).
 * Document `http_timeout_seconds` from `common/client.go` ([#1599](#1599)).
 * Expand `parameter` documentation for [databricks_sql_query](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_query) resource ([#1603](#1603)).
 * Updated Unity Catalog docs ([#1605](#1605), [#1626](#1626), [#1620](#1620)).

 Updated dependency versions:

 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.21.0 to 2.23.0 ([#1597](#1597), [#1611](#1611)).
 * Bump google.golang.org/api from 0.94.0 to 0.96.0 ([#1598](#1598), [#1612](#1612)).
@nfx nfx deleted the issue-1621 branch September 30, 2022 17:18
nkvuong pushed a commit that referenced this pull request Oct 6, 2022
nkvuong pushed a commit that referenced this pull request Oct 6, 2022
# Version changelog

## 1.3.1

 * Added autoscale `mode` configuration to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([#1600](#1600)).
 * Fixed `gcp_availability` field in [databricks_insance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/insance_pool) resource ([#1610](#1610)).
 * Fixed `secret` field name in [databricks_mlflow_webhook](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mlflow_webhook) resource ([#1625](#1625)).
 * Further improvements of exporter ([#1602](#1602)).

 Documentation improvements:
 
 * Updates for [databricks_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/table) and [databricks_mws_vpc_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_vpc_endpoint) ([#1616](#1616)).
 * Document `http_timeout_seconds` from `common/client.go` ([#1599](#1599)).
 * Expand `parameter` documentation for [databricks_sql_query](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_query) resource ([#1603](#1603)).
 * Updated Unity Catalog docs ([#1605](#1605), [#1626](#1626), [#1620](#1620)).

 Updated dependency versions:

 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.21.0 to 2.23.0 ([#1597](#1597), [#1611](#1611)).
 * Bump google.golang.org/api from 0.94.0 to 0.96.0 ([#1598](#1598), [#1612](#1612)).
nkvuong pushed a commit that referenced this pull request Oct 7, 2022
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140905 +0100

parent 06af47b
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140865 +0100

parent 06af47b
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140826 +0100

parent 06af47b
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140786 +0100

Release 1.4.0 (#1650)

remove databricks_table resource from doc

fix following suggestions

update docs to match new privilege model

Fix dashboard acceptance test (#1618)

DBSQL resources are organized in a workspace structure as of recently.
As such it is no longer possible to use the same name for different
assets. This acceptance test used to use the same name for both
the dashboard and the query and started failing. The solution here
is to use a different suffix for the different resources.

Fix unity catalog docs to use correct metastore (#1620)

aws_iam_policy.unity_metastore is referencing
aws_s3_bucket.unity_metastore.arn, which is non-existent.
Fix to use aws_s3_bucket.metastore.arn instead. This also
matches with the online tutorial.

https://docs.databricks.com/data-governance/unity-catalog/automate.html

fix `secret` field name in `databricks_mlflow_webhook` resource (#1625)

fixes #1621

Fixed `gcp_availability` field in `databricks_insance_pool` resource (#1610)

Co-authored-by: Alex Ott <alexey.ott@databricks.com>

Add autoscale `mode` configuration to `databricks_pipeline` resource (#1600)

Fix Azure authentication for dev and staging workspaces (#1607)

* Fix Azure authentication for dev and staging workspaces
* use env variable
* Fix client attributes tests
* Rename AzureDatabricksResourceId to AzureDatabricksLoginAppId
* Simplify GetAzureDatabricksLoginAppId

Fixed minor errors in Unity Catalog docs (#1626)

* Fixed errors in docs
* Fixed Azure SPOT and elastic disk
* Added fallback on SPOT_AZURE configuration

Bump github.com/hashicorp/hcl/v2 from 2.14.0 to 2.14.1 (#1634)

Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.14.0 to 2.14.1.
- [Release notes](https://github.com/hashicorp/hcl/releases)
- [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md)
- [Commits](hashicorp/hcl@v2.14.0...v2.14.1)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/hcl/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump google.golang.org/api from 0.96.0 to 0.97.0 (#1633)

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.96.0 to 0.97.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.96.0...v0.97.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Correct handling of references in `databricks_permissions` resources (#1631)

this fixes #1628

expand documentation for `databricks_sql_visualization` resource (#1630)

* expand documentation for `options` field in `sql-visualization` resource
* add wording for how to restore during issue scenario

Prevent stripping of `CAN_MANAGE` permission from caller of `databricks_sql_query` resource (#1644)

Make debugging work again (#1560)

Fix test for `databricks_job` data source (#1649)
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this pull request Feb 15, 2023
# Version changelog

## 1.3.1

 * Added autoscale `mode` configuration to [databricks_pipeline](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/pipeline) resource ([databricks#1600](databricks#1600)).
 * Fixed `gcp_availability` field in [databricks_insance_pool](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/insance_pool) resource ([databricks#1610](databricks#1610)).
 * Fixed `secret` field name in [databricks_mlflow_webhook](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mlflow_webhook) resource ([databricks#1625](databricks#1625)).
 * Further improvements of exporter ([databricks#1602](databricks#1602)).

 Documentation improvements:
 
 * Updates for [databricks_table](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/table) and [databricks_mws_vpc_endpoint](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/mws_vpc_endpoint) ([databricks#1616](databricks#1616)).
 * Document `http_timeout_seconds` from `common/client.go` ([databricks#1599](databricks#1599)).
 * Expand `parameter` documentation for [databricks_sql_query](https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/sql_query) resource ([databricks#1603](databricks#1603)).
 * Updated Unity Catalog docs ([databricks#1605](databricks#1605), [databricks#1626](databricks#1626), [databricks#1620](databricks#1620)).

 Updated dependency versions:

 * Bump github.com/hashicorp/terraform-plugin-sdk/v2 from 2.21.0 to 2.23.0 ([databricks#1597](databricks#1597), [databricks#1611](databricks#1611)).
 * Bump google.golang.org/api from 0.94.0 to 0.96.0 ([databricks#1598](databricks#1598), [databricks#1612](databricks#1612)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ISSUE] Issue with databricks/terraform-provider-databricks/mlflow/databricks_mlflow_webhook resource
3 participants