Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] Issue with databricks/terraform-provider-databricks/mlflow/databricks_mlflow_webhook resource #1621

Closed
colinobriencork opened this issue Sep 21, 2022 · 0 comments · Fixed by #1625
Assignees

Comments

@colinobriencork
Copy link

colinobriencork commented Sep 21, 2022

Configuration

resource "databricks_mlflow_webhook" "url" {
  events        = ["MODEL_VERSION_TRANSITIONED_TO_PRODUCTION"]
  description   = "Databricks Job webhook trigger"
  status        = "ACTIVE"
  http_url_spec {
    url                      =  host_url
    #enable_ssl_verification = false
    secret                  = local.databricks_hmac_webhook[var.environment]
  }
}

Expected Behavior

It should have passed.

Actual Behavior

It crapped out saying that the argument secret was not expected.

Steps to Reproduce

  1. terraform plan

Terraform and provider versions

Terraform v1.1.9

Debug Output

An argument named "secret" is not expected here.

Important Factoids

I'm no expert on go but it seems to me that maybe this line
should say json:"secret,omitempty", not json:"string,omitempty"

@colinobriencork colinobriencork changed the title [BUG] Issue with databricks/terraform-provider-databricks resource [BUG] Issue with databricks/terraform-provider-databricks/mlflow/databricks_mlflow_webhook resource Sep 21, 2022
@colinobriencork colinobriencork changed the title [BUG] Issue with databricks/terraform-provider-databricks/mlflow/databricks_mlflow_webhook resource [ISSUE] Issue with databricks/terraform-provider-databricks/mlflow/databricks_mlflow_webhook resource Sep 21, 2022
@alexott alexott self-assigned this Sep 21, 2022
@nfx nfx closed this as completed in #1625 Sep 21, 2022
nkvuong pushed a commit that referenced this issue Oct 7, 2022
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140905 +0100

parent 06af47b
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140865 +0100

parent 06af47b
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140826 +0100

parent 06af47b
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140786 +0100

Release 1.4.0 (#1650)

remove databricks_table resource from doc

fix following suggestions

update docs to match new privilege model

Fix dashboard acceptance test (#1618)

DBSQL resources are organized in a workspace structure as of recently.
As such it is no longer possible to use the same name for different
assets. This acceptance test used to use the same name for both
the dashboard and the query and started failing. The solution here
is to use a different suffix for the different resources.

Fix unity catalog docs to use correct metastore (#1620)

aws_iam_policy.unity_metastore is referencing
aws_s3_bucket.unity_metastore.arn, which is non-existent.
Fix to use aws_s3_bucket.metastore.arn instead. This also
matches with the online tutorial.

https://docs.databricks.com/data-governance/unity-catalog/automate.html

fix `secret` field name in `databricks_mlflow_webhook` resource (#1625)

fixes #1621

Fixed `gcp_availability` field in `databricks_insance_pool` resource (#1610)

Co-authored-by: Alex Ott <alexey.ott@databricks.com>

Add autoscale `mode` configuration to `databricks_pipeline` resource (#1600)

Fix Azure authentication for dev and staging workspaces (#1607)

* Fix Azure authentication for dev and staging workspaces
* use env variable
* Fix client attributes tests
* Rename AzureDatabricksResourceId to AzureDatabricksLoginAppId
* Simplify GetAzureDatabricksLoginAppId

Fixed minor errors in Unity Catalog docs (#1626)

* Fixed errors in docs
* Fixed Azure SPOT and elastic disk
* Added fallback on SPOT_AZURE configuration

Bump github.com/hashicorp/hcl/v2 from 2.14.0 to 2.14.1 (#1634)

Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.14.0 to 2.14.1.
- [Release notes](https://github.com/hashicorp/hcl/releases)
- [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md)
- [Commits](hashicorp/hcl@v2.14.0...v2.14.1)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/hcl/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump google.golang.org/api from 0.96.0 to 0.97.0 (#1633)

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.96.0 to 0.97.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.96.0...v0.97.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Correct handling of references in `databricks_permissions` resources (#1631)

this fixes #1628

expand documentation for `databricks_sql_visualization` resource (#1630)

* expand documentation for `options` field in `sql-visualization` resource
* add wording for how to restore during issue scenario

Prevent stripping of `CAN_MANAGE` permission from caller of `databricks_sql_query` resource (#1644)

Make debugging work again (#1560)

Fix test for `databricks_job` data source (#1649)
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this issue Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants