Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE] Issue with databricks_permissions exporter for sql endpoints #1628

Closed
rohitnijhawan opened this issue Sep 22, 2022 · 3 comments · Fixed by #1631
Closed

[ISSUE] Issue with databricks_permissions exporter for sql endpoints #1628

rohitnijhawan opened this issue Sep 22, 2022 · 3 comments · Fixed by #1631
Assignees
Labels
bug Something isn't working exporter TF configuration generator

Comments

@rohitnijhawan
Copy link
Contributor

Configuration

resource "databricks_permissions" "sql_endpoint_starter_endpoint" {
    sql_endpoint_id = "fb8......xyz"
    access_control {
        permission_level = "CAN_USE"
        group_name = data.databricks_group.users.display_name
    }
    access_control {
        user_name = databricks_user.k0p00te.user_name
        permission_level  = "CAN_MANAGE"
    }
}

Expected Behavior

IDs for resources should be provided with dotted notation as in: a reference to a value (to be known in the future)

Actual Behavior

The Terraform Exporter is writing some hcl configuration files with IDs that are hardcoded for resources.
Resources with these IDs do no exist when other resources look for them.
The culprit here is
sql_endpoint_id = "fb8......xyz" which leads to the error message

Error: cannot create permissions: endpoints fb8.......xyz does not exist

Steps to Reproduce

  • Create a new SQL Endpoint
  • Add user permissions to manage the endpoint
  • Run the terraform exporter with -services=sql,access

Terraform and provider versions

Databricks terraform Provider 1.3.0
Terraform - versions above 0.15

Important Factoids

Technically the output shown above is not wrong. It reflects the state of the workspace but the user can't use it to run apply because IDs are autogenerated.
As a result, all resources should have reference notation.

@nfx nfx changed the title [ISSUE] Issue with databricks_permissions resource [ISSUE] Issue with databricks_permissions exporter for sql endpoints Sep 23, 2022
@nfx nfx added bug Something isn't working exporter TF configuration generator labels Sep 23, 2022
@nfx
Copy link
Contributor

nfx commented Sep 23, 2022

@alexott this is a simple fix

@alexott
Copy link
Contributor

alexott commented Sep 23, 2022

I know. will fix it together with other stuff

@alexott
Copy link
Contributor

alexott commented Sep 26, 2022

Really, I already had that fix as a part of the dbsql branch. Will extract into a separate PR

@nfx nfx closed this as completed in #1631 Sep 27, 2022
nkvuong pushed a commit that referenced this issue Oct 7, 2022
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140905 +0100

parent 06af47b
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140865 +0100

parent 06af47b
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140826 +0100

parent 06af47b
author Serge Smertin <259697+nfx@users.noreply.github.com> 1664570116 -0700
committer Vuong Nguyen <vuong.nguyen@databricks.com> 1665140786 +0100

Release 1.4.0 (#1650)

remove databricks_table resource from doc

fix following suggestions

update docs to match new privilege model

Fix dashboard acceptance test (#1618)

DBSQL resources are organized in a workspace structure as of recently.
As such it is no longer possible to use the same name for different
assets. This acceptance test used to use the same name for both
the dashboard and the query and started failing. The solution here
is to use a different suffix for the different resources.

Fix unity catalog docs to use correct metastore (#1620)

aws_iam_policy.unity_metastore is referencing
aws_s3_bucket.unity_metastore.arn, which is non-existent.
Fix to use aws_s3_bucket.metastore.arn instead. This also
matches with the online tutorial.

https://docs.databricks.com/data-governance/unity-catalog/automate.html

fix `secret` field name in `databricks_mlflow_webhook` resource (#1625)

fixes #1621

Fixed `gcp_availability` field in `databricks_insance_pool` resource (#1610)

Co-authored-by: Alex Ott <alexey.ott@databricks.com>

Add autoscale `mode` configuration to `databricks_pipeline` resource (#1600)

Fix Azure authentication for dev and staging workspaces (#1607)

* Fix Azure authentication for dev and staging workspaces
* use env variable
* Fix client attributes tests
* Rename AzureDatabricksResourceId to AzureDatabricksLoginAppId
* Simplify GetAzureDatabricksLoginAppId

Fixed minor errors in Unity Catalog docs (#1626)

* Fixed errors in docs
* Fixed Azure SPOT and elastic disk
* Added fallback on SPOT_AZURE configuration

Bump github.com/hashicorp/hcl/v2 from 2.14.0 to 2.14.1 (#1634)

Bumps [github.com/hashicorp/hcl/v2](https://github.com/hashicorp/hcl) from 2.14.0 to 2.14.1.
- [Release notes](https://github.com/hashicorp/hcl/releases)
- [Changelog](https://github.com/hashicorp/hcl/blob/main/CHANGELOG.md)
- [Commits](hashicorp/hcl@v2.14.0...v2.14.1)

---
updated-dependencies:
- dependency-name: github.com/hashicorp/hcl/v2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump google.golang.org/api from 0.96.0 to 0.97.0 (#1633)

Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.96.0 to 0.97.0.
- [Release notes](https://github.com/googleapis/google-api-go-client/releases)
- [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md)
- [Commits](googleapis/google-api-go-client@v0.96.0...v0.97.0)

---
updated-dependencies:
- dependency-name: google.golang.org/api
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Correct handling of references in `databricks_permissions` resources (#1631)

this fixes #1628

expand documentation for `databricks_sql_visualization` resource (#1630)

* expand documentation for `options` field in `sql-visualization` resource
* add wording for how to restore during issue scenario

Prevent stripping of `CAN_MANAGE` permission from caller of `databricks_sql_query` resource (#1644)

Make debugging work again (#1560)

Fix test for `databricks_job` data source (#1649)
michael-berk pushed a commit to michael-berk/terraform-provider-databricks that referenced this issue Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working exporter TF configuration generator
Projects
None yet
3 participants