Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FullName in databricks_volume resource only if no error is returned. #2374

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Update FullName in databricks_volume resource only if no error is returned. #2374

merged 5 commits into from
Jun 6, 2023

Conversation

tanmay-db
Copy link
Contributor

@tanmay-db tanmay-db commented Jun 5, 2023 •
edited
Loading

Changes

Title

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@tanmay-db tanmay-db changed the title Update FullName in databricks_volumeresource only if no error is returned. Update FullName in databricks_volumeresource only if no error is returned. Jun 5, 2023
@tanmay-db tanmay-db mentioned this pull request Jun 5, 2023
Merged
5 tasks
@tanmay-db tanmay-db requested a review from nkvuong June 5, 2023 17:10
@tanmay-db tanmay-db changed the title Update FullName in databricks_volumeresource only if no error is returned. Update FullName in databricks_volume resource only if no error is returned. Jun 5, 2023
@tanmay-db tanmay-db requested a review from nfx June 5, 2023 17:25
alexott
alexott approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@alexott alexott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nfx
nfx approved these changes Jun 5, 2023
View reviewed changes
catalog/resource_volume.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #2374 (3e7a2fd) into master (1a052ad) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2374   +/-   ##
=======================================
  Coverage   88.53%   88.53%           
=======================================
  Files         141      141           
  Lines       11620    11620           
=======================================
  Hits        10288    10288           
  Misses        886      886           
  Partials      446      446
Impacted Files Coverage Δ
catalog/resource_volume.go 83.67% <100.00%> (ø)

@tanmay-db tanmay-db merged commit abde931 into databricks:master Jun 6, 2023
@nfx nfx mentioned this pull request Jun 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nfx nfx nfx approved these changes

@alexott alexott alexott approved these changes

@nkvuong nkvuong Awaiting requested review from nkvuong

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanmay-db @codecov-commenter @alexott @nfx