Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FullName in databricks_volume resource only if no error is returned. #2374

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Update FullName in databricks_volume resource only if no error is returned. #2374

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2034f28
update only if no error is retured
tanmay-db Jun 5, 2023
3e7a2fd
Merge branch 'master' into fix-update
nfx Jun 5, 2023
8cf46a1
upd comment
tanmay-db Jun 6, 2023
d64e6ef
Merge branch 'fix-update' of github.com:tanmay-db/terraform-provider-…
tanmay-db Jun 6, 2023
b14a523
Merge branch 'master' into fix-update
tanmay-db Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions catalog/resource_volume.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,12 +82,12 @@ func ResourceVolume() *schema.Resource {
common.DataToStructPointer(d, s, &updateVolumeRequestContent)
updateVolumeRequestContent.FullNameArg = d.Id()
v, err := w.Volumes.Update(ctx, updateVolumeRequestContent)
// We need to update the resource data because Name is updatable and FullName consists of Name,
// So if we don't update the field then the requests would be made to old FullName which doesn't exists.
d.SetId(v.FullName)
if err != nil {
return err
}
// We need to update the resource data because Name is updatable and FullName consists of Name,
tanmay-db marked this conversation as resolved.
Show resolved Hide resolved
// So if we don't update the field then the requests would be made to old FullName which doesn't exists.
d.SetId(v.FullName)
return nil
},
Delete: func(ctx context.Context, d *schema.ResourceData, c *common.DatabricksClient) error {
Expand Down