[Exporter] Improving reliability of Emit function
#4163
Merged
+43
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I found in the large-scale testing that sometimes we don't handle emitting of the same resource reliably, and this may lead to generation of duplicate resources (very small amount, but still) - found this in a very specific case when notebooks were listed without directories. This PR fixes this problem: - by tracking if resource is already in importing queue - detecting duplicates during code generation It also may improve performance a bit (2-3%).
alexott
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
|
Test Details: go/deco-tests/11552649280 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mgyucht
approved these changes
Oct 28, 2024
mgyucht
added a commit
that referenced
this pull request
Oct 28, 2024
### Bug Fixes * Recreate missing system schema ([#4068](#4068)). * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)). ### Documentation * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)). ### Internal Changes * Automatically trigger integration tests on PR ([#4149](#4149)). ### Exporter * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)). * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)). * Improving reliability of `Emit` function ([#4163](#4163)).
mgyucht
added a commit
that referenced
this pull request
Oct 28, 2024
### Bug Fixes * Recreate missing system schema ([#4068](#4068)). * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)). ### Documentation * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)). ### Internal Changes * Automatically trigger integration tests on PR ([#4149](#4149)). ### Exporter * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)). * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)). * Improving reliability of `Emit` function ([#4163](#4163)).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 28, 2024
### Bug Fixes * Recreate missing system schema ([#4068](#4068)). * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)). ### Documentation * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)). ### Internal Changes * Automatically trigger integration tests on PR ([#4149](#4149)). ### Exporter * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)). * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)). * Improving reliability of `Emit` function ([#4163](#4163)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I found in the large-scale testing that sometimes we don't handle emitting of the same resource reliably, and this may lead to generation of duplicate resources (very small amount, but still) - found this in a very specific case when notebooks were listed without directories.
This PR fixes this problem:
It also may improve performance a bit (2-3%).
Tests
make testrun locallydocs/folderinternal/acceptance