Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Fix databricks_grant regarding metastore_id description #4164

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

LittleWat
Copy link
Contributor

@LittleWat LittleWat commented Oct 28, 2024

I found the mistakes in the doc: https://registry.terraform.io/providers/databricks/databricks/latest/docs/resources/grant

so let me fix them 🙇

Changes

Tests

  • make test run locally
  • relevant change in docs/ folder
  • covered with integration tests in internal/acceptance
  • relevant acceptance tests are passing
  • using Go SDK

@LittleWat LittleWat requested review from a team as code owners October 28, 2024 12:50
@LittleWat LittleWat requested review from renaudhartert-db and removed request for a team October 28, 2024 12:50
@renaudhartert-db renaudhartert-db requested review from tanmay-db and removed request for renaudhartert-db October 28, 2024 12:52
@alexott alexott changed the title Fix grant.md regarding metastore_id description [Doc] Fix grant.md regarding metastore_id description Oct 28, 2024
@alexott alexott enabled auto-merge October 28, 2024 13:05
@mgyucht mgyucht disabled auto-merge October 28, 2024 13:45
@mgyucht
Copy link
Contributor

mgyucht commented Oct 28, 2024

Merging as this is a docs-only change. Thanks for the contribution @LittleWat!

@mgyucht mgyucht changed the title [Doc] Fix grant.md regarding metastore_id description [Doc] Fix databricks_grant regarding metastore_id description Oct 28, 2024
@mgyucht mgyucht merged commit 948bf08 into databricks:main Oct 28, 2024
12 of 15 checks passed
mgyucht added a commit that referenced this pull request Oct 28, 2024
### Bug Fixes

 * Recreate missing system schema  ([#4068](#4068)).
 * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)).

### Documentation

 * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)).

### Internal Changes

 * Automatically trigger integration tests on PR ([#4149](#4149)).

### Exporter

 * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)).
 * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)).
 * Improving reliability of `Emit` function ([#4163](#4163)).
mgyucht added a commit that referenced this pull request Oct 28, 2024
### Bug Fixes

 * Recreate missing system schema  ([#4068](#4068)).
 * Tolerate `databricks_permissions` resources for SQL warehouses with `/warehouses/...` IDs ([#4158](#4158)).

### Documentation

 * Fix `databricks_grant` regarding metastore_id description ([#4164](#4164)).

### Internal Changes

 * Automatically trigger integration tests on PR ([#4149](#4149)).

### Exporter

 * **Breaking change** Use new query and alert resources instead of legacy resources ([#4150](#4150)).
 * Improve exporting of `databricks_pipeline` resources ([#4142](#4142)).
 * Improving reliability of `Emit` function ([#4163](#4163)).
github-merge-queue bot pushed a commit that referenced this pull request Oct 28, 2024
### Bug Fixes

* Recreate missing system schema
([#4068](#4068)).
* Tolerate `databricks_permissions` resources for SQL warehouses with
`/warehouses/...` IDs
([#4158](#4158)).


### Documentation

* Fix `databricks_grant` regarding metastore_id description
([#4164](#4164)).


### Internal Changes

* Automatically trigger integration tests on PR
([#4149](#4149)).


### Exporter

* **Breaking change** Use new query and alert resources instead of
legacy resources
([#4150](#4150)).
* Improve exporting of `databricks_pipeline` resources
([#4142](#4142)).
* Improving reliability of `Emit` function
([#4163](#4163)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants