Improved installation finish messages within installer script #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tebook for next steps.
tamilselvanveeramani
requested review from
nfx and
larsgeorge-db
as code owners
Codecov Report
@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 83.35% 83.37% +0.02%
==========================================
Files 29 29
Lines 1976 1979 +3
Branches 337 337
==========================================
+ Hits 1647 1650 +3
Misses 261 261
Partials 68 68
|
nfx
requested changes
Sep 22, 2023
src/databricks/labs/ucx/install.py
Outdated
| @@ -76,6 +76,8 @@ def run(self): | |||
| self._configure() | |||
| self._create_dashboards() | |||
| self._create_jobs() | |||
| msg = """Installation completed successfully! Please refer to the README.py notebook for next steps.""" | |||
There was a problem hiding this comment.
Post a link to a notebook, not just a name of it
nfx
changed the title
…tebook for next steps.
|
Agreed... Here is the latest code run 
|
nfx
approved these changes
Sep 22, 2023
larsgeorge-db
pushed a commit
that referenced
this pull request
Sep 23, 2023
msg - Installation completed successfully! Please refer to the README.py notebook for next steps. <img width="881" alt="image" src="https://github.com/databrickslabs/ucx/assets/93284829/bfd24ea8-c457-4482-ba71-b65fe474ae2e">
nfx
added a commit
that referenced
this pull request
Sep 29, 2023
# Version changelog ## 0.2.0 * Added retrieving for all account-level groups with matching names to workspace-level groups in case no explicit configuration ([#277](#277)). * Added crawler for Azure Service principals used for direct storage access ([#305](#305)). * Added more SQL queries to the assessment step dashboard ([#269](#269)). * Added filtering out for job clusters in the clusters crawler ([#298](#298)). * Added recording errors from `crawl_tables` step in `$inventory.table_failures` table and display counter on the dashboard ([#300](#300)). * Added comprehensive introduction user manual ([#273](#273)). * Added interactive tutorial for local group migration readme ([#291](#291)). * Added tutorial links to the landing page of documentation ([#290](#290)). * Added (internal) support for account-level configuration and multi-cloud workspace list ([#264](#264)). * Improved order of tasks in the README notebook ([#286](#286)). * Improved installation script to run in a Windows Git Bash terminal ([#282](#282)). * Improved installation script by setting log level to uppercase by default ([#271](#271)). * Improved installation finish messages within installer script ([#267](#267)). * Improved automation for `MANAGED` table migration and continued building tables migration component ([#295](#295)). * Fixed debug notebook code with refactored package structure ([#250](#250)) ([#265](#265)). * Fixed replacement of custom configured database to replicate in the report for external locations ([#296](#296)). * Removed redundant `notebooks` top-level folder ([#263](#263)). * Split checking for test failures and linting errors into independent GitHub Actions checks ([#287](#287)). * Verify query metadata for assessment dashboards during unit tests ([#294](#294)).
Merged
nfx
added a commit
that referenced
this pull request
Sep 29, 2023
# Version changelog ## 0.2.0 * Added retrieving for all account-level groups with matching names to workspace-level groups in case no explicit configuration ([#277](#277)). * Added crawler for Azure Service principals used for direct storage access ([#305](#305)). * Added more SQL queries to the assessment step dashboard ([#269](#269)). * Added filtering out for job clusters in the clusters crawler ([#298](#298)). * Added recording errors from `crawl_tables` step in `$inventory.table_failures` table and display counter on the dashboard ([#300](#300)). * Added comprehensive introduction user manual ([#273](#273)). * Added interactive tutorial for local group migration readme ([#291](#291)). * Added tutorial links to the landing page of documentation ([#290](#290)). * Added (internal) support for account-level configuration and multi-cloud workspace list ([#264](#264)). * Improved order of tasks in the README notebook ([#286](#286)). * Improved installation script to run in a Windows Git Bash terminal ([#282](#282)). * Improved installation script by setting log level to uppercase by default ([#271](#271)). * Improved installation finish messages within installer script ([#267](#267)). * Improved automation for `MANAGED` table migration and continued building tables migration component ([#295](#295)). * Fixed debug notebook code with refactored package structure ([#250](#250)) ([#265](#265)). * Fixed replacement of custom configured database to replicate in the report for external locations ([#296](#296)). * Removed redundant `notebooks` top-level folder ([#263](#263)). * Split checking for test failures and linting errors into independent GitHub Actions checks ([#287](#287)). * Verify query metadata for assessment dashboards during unit tests ([#294](#294)).
FastLee
pushed a commit
that referenced
this pull request
Sep 29, 2023
# Version changelog ## 0.2.0 * Added retrieving for all account-level groups with matching names to workspace-level groups in case no explicit configuration ([#277](#277)). * Added crawler for Azure Service principals used for direct storage access ([#305](#305)). * Added more SQL queries to the assessment step dashboard ([#269](#269)). * Added filtering out for job clusters in the clusters crawler ([#298](#298)). * Added recording errors from `crawl_tables` step in `$inventory.table_failures` table and display counter on the dashboard ([#300](#300)). * Added comprehensive introduction user manual ([#273](#273)). * Added interactive tutorial for local group migration readme ([#291](#291)). * Added tutorial links to the landing page of documentation ([#290](#290)). * Added (internal) support for account-level configuration and multi-cloud workspace list ([#264](#264)). * Improved order of tasks in the README notebook ([#286](#286)). * Improved installation script to run in a Windows Git Bash terminal ([#282](#282)). * Improved installation script by setting log level to uppercase by default ([#271](#271)). * Improved installation finish messages within installer script ([#267](#267)). * Improved automation for `MANAGED` table migration and continued building tables migration component ([#295](#295)). * Fixed debug notebook code with refactored package structure ([#250](#250)) ([#265](#265)). * Fixed replacement of custom configured database to replicate in the report for external locations ([#296](#296)). * Removed redundant `notebooks` top-level folder ([#263](#263)). * Split checking for test failures and linting errors into independent GitHub Actions checks ([#287](#287)). * Verify query metadata for assessment dashboards during unit tests ([#294](#294)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
msg - Installation completed successfully! Please refer to the README.py notebook for next steps.