Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added filtering out for job clusters in clusters crawler #298

Merged
merged 3 commits into from
Sep 26, 2023
Merged

Added filtering out for job clusters in clusters crawler #298

merged 3 commits into from
Sep 26, 2023

Conversation

FastLee
Copy link
Contributor

@FastLee FastLee commented Sep 25, 2023

Closed #279

@FastLee FastLee self-assigned this Sep 25, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023 •
edited
Loading

Codecov Report

Merging #298 (e47fe50) into main (0c61632) will decrease coverage by 0.10%.
Report is 4 commits behind head on main.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #298      +/-   ##
==========================================
- Coverage   83.36%   83.27%   -0.10%     
==========================================
  Files          30       30              
  Lines        2128     2146      +18     
  Branches      361      366       +5     
==========================================
+ Hits         1774     1787      +13     
- Misses        276      279       +3     
- Partials       78       80       +2
Files Coverage Δ
src/databricks/labs/ucx/assessment/crawlers.py 66.94% <33.33%> (-0.88%) ⬇️

... and 3 files with indirect coverage changes

nfx
nfx requested changes Sep 25, 2023
View reviewed changes
src/databricks/labs/ucx/assessment/crawlers.py Outdated
if len(failures) > 0:
cluster_info.success = 0
yield cluster_info
if cluster.cluster_source != ClusterSource.JOB:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff is too big, do "if cluster source is job, continue". It's more readable that way as well

@nfx nfx changed the title Removed Job Clusters from Clusters Crawler Added filtering out for job clusters i clusters crawler Sep 25, 2023
@larsgeorge-db larsgeorge-db changed the title Added filtering out for job clusters i clusters crawler Added filtering out for job clusters in clusters crawler Sep 26, 2023
larsgeorge-db
larsgeorge-db approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@larsgeorge-db larsgeorge-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the feedback form Serge.

@FastLee FastLee requested a review from nfx September 26, 2023 13:28
@nfx nfx added this pull request to the merge queue Sep 26, 2023
Merged via the queue into main with commit 4fe6ed8 Sep 26, 2023
3 of 5 checks passed
@nfx nfx deleted the fix/remove_job_clusters branch September 26, 2023 23:02
nfx added a commit that referenced this pull request Sep 29, 2023
@nfx
Release v0.2.0
f885a0d 
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to workspace-level groups in case no explicit configuration ([#277](#277)).
* Added crawler for Azure Service principals used for direct storage access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard ([#269](#269)).
* Added filtering out for job clusters in the clusters crawler ([#298](#298)).
* Added recording errors from `crawl_tables` step in `$inventory.table_failures` table and display counter on the dashboard ([#300](#300)).
* Added comprehensive introduction user manual ([#273](#273)).
* Added interactive tutorial for local group migration readme ([#291](#291)).
* Added tutorial links to the landing page of documentation ([#290](#290)).
* Added (internal) support for account-level configuration and multi-cloud workspace list ([#264](#264)).
* Improved order of tasks in the README notebook ([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal ([#282](#282)).
* Improved installation script by setting log level to uppercase by default ([#271](#271)).
* Improved installation finish messages within installer script ([#267](#267)).
* Improved automation for `MANAGED` table migration and continued building tables migration component ([#295](#295)).
* Fixed debug notebook code with refactored package structure ([#250](#250)) ([#265](#265)).
* Fixed replacement of custom configured database to replicate in the report for external locations ([#296](#296)).
* Removed redundant `notebooks` top-level folder ([#263](#263)).
* Split checking for test failures and linting errors into independent GitHub Actions checks ([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests ([#294](#294)).
@nfx nfx mentioned this pull request Sep 29, 2023
Merged
nfx added a commit that referenced this pull request Sep 29, 2023
@nfx
Release v0.2.0 (#328)
b81abea 
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to
workspace-level groups in case no explicit configuration
([#277](#277)).
* Added crawler for Azure Service principals used for direct storage
access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard
([#269](#269)).
* Added filtering out for job clusters in the clusters crawler
([#298](#298)).
* Added recording errors from `crawl_tables` step in
`$inventory.table_failures` table and display counter on the dashboard
([#300](#300)).
* Added comprehensive introduction user manual
([#273](#273)).
* Added interactive tutorial for local group migration readme
([#291](#291)).
* Added tutorial links to the landing page of documentation
([#290](#290)).
* Added (internal) support for account-level configuration and
multi-cloud workspace list
([#264](#264)).
* Improved order of tasks in the README notebook
([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal
([#282](#282)).
* Improved installation script by setting log level to uppercase by
default ([#271](#271)).
* Improved installation finish messages within installer script
([#267](#267)).
* Improved automation for `MANAGED` table migration and continued
building tables migration component
([#295](#295)).
* Fixed debug notebook code with refactored package structure
([#250](#250))
([#265](#265)).
* Fixed replacement of custom configured database to replicate in the
report for external locations
([#296](#296)).
* Removed redundant `notebooks` top-level folder
([#263](#263)).
* Split checking for test failures and linting errors into independent
GitHub Actions checks
([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests
([#294](#294)).
FastLee pushed a commit that referenced this pull request Sep 29, 2023
@nfx @FastLee
Release v0.2.0 (#328)
b6015a6 
# Version changelog

## 0.2.0

* Added retrieving for all account-level groups with matching names to
workspace-level groups in case no explicit configuration
([#277](#277)).
* Added crawler for Azure Service principals used for direct storage
access ([#305](#305)).
* Added more SQL queries to the assessment step dashboard
([#269](#269)).
* Added filtering out for job clusters in the clusters crawler
([#298](#298)).
* Added recording errors from `crawl_tables` step in
`$inventory.table_failures` table and display counter on the dashboard
([#300](#300)).
* Added comprehensive introduction user manual
([#273](#273)).
* Added interactive tutorial for local group migration readme
([#291](#291)).
* Added tutorial links to the landing page of documentation
([#290](#290)).
* Added (internal) support for account-level configuration and
multi-cloud workspace list
([#264](#264)).
* Improved order of tasks in the README notebook
([#286](#286)).
* Improved installation script to run in a Windows Git Bash terminal
([#282](#282)).
* Improved installation script by setting log level to uppercase by
default ([#271](#271)).
* Improved installation finish messages within installer script
([#267](#267)).
* Improved automation for `MANAGED` table migration and continued
building tables migration component
([#295](#295)).
* Fixed debug notebook code with refactored package structure
([#250](#250))
([#265](#265)).
* Fixed replacement of custom configured database to replicate in the
report for external locations
([#296](#296)).
* Removed redundant `notebooks` top-level folder
([#263](#263)).
* Split checking for test failures and linting errors into independent
GitHub Actions checks
([#287](#287)).
* Verify query metadata for assessment dashboards during unit tests
([#294](#294)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsgeorge-db larsgeorge-db larsgeorge-db approved these changes

@nfx nfx nfx approved these changes

Assignees

@FastLee FastLee

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Job clusters from the cluster assessment
3 participants
@FastLee @nfx @larsgeorge-db