Fixes the broken test after blueprint bug fixes #4442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sundarshankar89
had a problem deploying
to
account-admin
GitHub Actions
Error
There was a problem hiding this comment.
Pull Request Overview
This PR fixes broken tests after blueprint bug fixes by updating test configurations to include new required boolean configuration fields. The changes ensure test compatibility with blueprint changes that added new boolean configuration parameters.
- Added six new boolean configuration fields to test fixtures
- Updated dependency to use a patched version of databricks-labs-blueprint
- Added configuration for direct Git references in pyproject.toml
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/unit/install/test_install.py | Added new boolean configuration fields to test fixtures |
| tests/unit/hive_metastore/test_mapping.py | Added 'compare_rows' field to mapping test data |
| pyproject.toml | Updated blueprint dependency to Git reference and enabled direct references |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+50
to
+51
| #"databricks-labs-blueprint>=0.11.0,<0.12.0", | ||
| "databricks-labs-blueprint @ git+https://github.com/databrickslabs/blueprint@patch/bool_type", |
There was a problem hiding this comment.
Using a Git branch reference instead of a versioned release creates instability and makes builds non-reproducible. Consider releasing a proper version of the blueprint library with the boolean type fixes and reverting to semantic versioning.
Suggested change
| #"databricks-labs-blueprint>=0.11.0,<0.12.0", | |
| "databricks-labs-blueprint @ git+https://github.com/databrickslabs/blueprint@patch/bool_type", | |
| "databricks-labs-blueprint>=0.11.0,<0.12.0", |
Copilot uses AI. Check for mistakes.
sundarshankar89
added
the
pr/do-not-merge
sundarshankar89
had a problem deploying
to
account-admin
GitHub Actions
Error
sundarshankar89
had a problem deploying
to
account-admin
GitHub Actions
Failure
sundarshankar89
commented
Sep 26, 2025
| if len(groups) == 1: | ||
| return groups[0].display_name | ||
| group_names = [group.display_name for group in groups] | ||
| group_names = [group.display_name for group in groups if group.display_name is not None] |
There was a problem hiding this comment.
This was done for fmt fixes
|
❌ 129/132 passed, 3 flaky, 3 failed, 11 skipped, 6h16m22s total ❌ test_table_migration_convert_manged_to_external: databricks.sdk.errors.sdk.OperationFailed: failed to reach TERMINATED or SKIPPED, got RunLifeCycleState.INTERNAL_ERROR: Task crawl_lakeview_dashboards failed with message: Cluster DATABRICKS_CLUSTER_ID was terminated during the run (cluster state message: Termination requested by 0a330eb5-dd51-4d97-b6e4-c474356b1d5d). (9m52.669s)❌ test_installation_with_dependency_upload: databricks.sdk.errors.sdk.OperationFailed: failed to reach TERMINATED or SKIPPED, got RunLifeCycleState.INTERNAL_ERROR: Task failing_task failed with message: Workload failed, see run output for details. (1m48.897s)❌ test_hiveserde_table_in_place_migration_job[migrate-external-hiveserde-tables-in-place-experimental]: AssertionError: Workflow failed: migrate-external-hiveserde-tables-in-place-experimental (27m44.999s)Flaky tests:
Running from acceptance #8888 |
sundarshankar89
had a problem deploying
to
account-admin
GitHub Actions
Failure
pritishpai
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR addresses broken tests following blueprint bug fixes by updating test configurations to include six new required boolean configuration fields. It ensures compatibility with recent blueprint changes that added new boolean configuration parameters.
Linked issues
databrickslabs/blueprint#268
Resolves #..
Resolves a Lakebridge bug which doesn't store boolean value in workspace config.yml when set to False.
Functionality
databricks labs ucx .........Tests