Skip to content

Fixes the broken test after blueprint bug fixes #4442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes the broken test after blueprint bug fixes #4442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ba9f1a
Fixes the broken test after blueprint bug fixes
sundarshankar89 Sep 26, 2025
924caeb
fmt fixes
sundarshankar89 Sep 26, 2025
bcd6d21
fmt fixes
sundarshankar89 Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,15 @@ classifiers = [

dependencies = ["databricks-sdk>=0.58.0,<0.59.0",
"databricks-labs-lsql>=0.16.0,<0.17.0",
"databricks-labs-blueprint>=0.11.0,<0.12.0",
#"databricks-labs-blueprint>=0.11.0,<0.12.0",
"databricks-labs-blueprint @ git+https://github.com/databrickslabs/blueprint@patch/bool_type",
Comment on lines +50 to +51
Copy link

Copilot AI Sep 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using a Git branch reference instead of a versioned release creates instability and makes builds non-reproducible. Consider releasing a proper version of the blueprint library with the boolean type fixes and reverting to semantic versioning.

Suggested change
#"databricks-labs-blueprint>=0.11.0,<0.12.0",
"databricks-labs-blueprint @ git+https://github.com/databrickslabs/blueprint@patch/bool_type",
"databricks-labs-blueprint>=0.11.0,<0.12.0",

Copilot uses AI. Check for mistakes.

"PyYAML>=6.0.0,<6.1.0",
"sqlglot>=26.7.0,<27.1.0",
"astroid>=3.3.0,<3.4.0"]

[tool.hatch.metadata]
allow-direct-references = true

[project.optional-dependencies]
pylsp = [
"python-lsp-server>=1.13.0,<1.14.0"
Expand Down
2 changes: 1 addition & 1 deletion src/databricks/labs/ucx/workspace_access/groups.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,7 +929,7 @@ def pick_owner_group(self, prompt: Prompts) -> str | None:
return None
if len(groups) == 1:
return groups[0].display_name
group_names = [group.display_name for group in groups]
group_names = [group.display_name for group in groups if group.display_name is not None]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done for fmt fixes

return prompt.choice("Select the group to be used as the owner group", group_names, max_attempts=3)

def user_in_group(self, group_name: str, user: User) -> bool:
Expand Down
1 change: 1 addition & 0 deletions tests/unit/hive_metastore/test_mapping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ def test_save_mapping():
[
{
'catalog_name': 'foo_bar',
'compare_rows': False,
'dst_schema': 'foo',
'dst_table': 'bar',
'src_schema': 'foo',
Expand Down
24 changes: 24 additions & 0 deletions tests/unit/install/test_install.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,12 @@ def test_configure_sets_expected_workspace_configuration_values(
'query_statement_disposition': 'INLINE',
"recon_tolerance_percent": 5,
"managed_table_external_storage": "CLONE",
"is_terraform_used": False,
"trigger_job": False,
"upload_dependencies": False,
"enable_hms_federation": False,
"use_legacy_permission_migration": False,
"skip_tacl_migration": False,
}
prompts = MockPrompts(
{
Expand Down Expand Up @@ -419,6 +425,12 @@ def test_configure_with_default_owner_group(
"num_days_submit_runs_history": 30,
"recon_tolerance_percent": 5,
"managed_table_external_storage": "CLONE",
"is_terraform_used": False,
"trigger_job": False,
"upload_dependencies": False,
"enable_hms_federation": False,
"use_legacy_permission_migration": False,
"skip_tacl_migration": False,
}
prompts = MockPrompts(
{
Expand Down Expand Up @@ -509,6 +521,12 @@ def test_create_cluster_policy(ws, mock_installation) -> None:
'query_statement_disposition': 'INLINE',
'recon_tolerance_percent': 5,
'managed_table_external_storage': "CLONE",
'is_terraform_used': False,
'trigger_job': False,
'upload_dependencies': False,
'enable_hms_federation': False,
'use_legacy_permission_migration': False,
'skip_tacl_migration': False,
},
)

Expand Down Expand Up @@ -1753,6 +1771,12 @@ def test_save_config_ext_hms(ws, mock_installation) -> None:
'query_statement_disposition': 'INLINE',
'recon_tolerance_percent': 5,
'managed_table_external_storage': "CLONE",
'is_terraform_used': False,
'trigger_job': False,
'upload_dependencies': False,
'enable_hms_federation': False,
'use_legacy_permission_migration': False,
'skip_tacl_migration': False,
},
)

Expand Down
Loading