fix(react): safely access caught Error properties (#3196)

datahub-project · Sep 8, 2021 · 8dbbec4 · 8dbbec4
1 parent 8747fbe
commit 8dbbec4
Show file tree

Hide file tree

Showing 5 changed files with 16 additions and 10 deletions.
diff --git a/...hub-web-react/src/app/entity/dataset/profile/schema/components/SchemaDescriptionField.tsx b/...hub-web-react/src/app/entity/dataset/profile/schema/components/SchemaDescriptionField.tsx
@@ -101,9 +101,9 @@ export default function DescriptionField({
             await onUpdate(desc || '');
             // message.destroy();
             // message.success({ content: 'Updated!', duration: 2 });
-        } catch (e) {
+        } catch (e: unknown) {
             message.destroy();
-            message.error({ content: `Update Failed! \n ${e.message || ''}`, duration: 2 });
+            if (e instanceof Error) message.error({ content: `Update Failed! \n ${e.message || ''}`, duration: 2 });
         }
         onCloseModal();
     };

diff --git a/datahub-web-react/src/app/entity/shared/components/legacy/UpdatableDescription.tsx b/datahub-web-react/src/app/entity/shared/components/legacy/UpdatableDescription.tsx
@@ -47,9 +47,9 @@ export default function UpdatableDescription({
                 entityUrn: urn,
             });
             message.success({ content: 'Updated!', duration: 2 });
-        } catch (e) {
+        } catch (e: unknown) {
             message.destroy();
-            message.error({ content: `Update Failed! \n ${e.message || ''}`, duration: 2 });
+            if (e instanceof Error) message.error({ content: `Update Failed! \n ${e.message || ''}`, duration: 2 });
         }
         setShowAddDescModal(false);
     };

diff --git a/datahub-web-react/src/app/entity/shared/components/styled/AddLinkModal.tsx b/datahub-web-react/src/app/entity/shared/components/styled/AddLinkModal.tsx
@@ -47,9 +47,11 @@ export const AddLinkModal = ({ buttonProps }: { buttonProps?: Record<string, unk
                     variables: { input: { urn, institutionalMemory: { elements: newLinks } } },
                 });
                 message.success({ content: 'Link Added', duration: 2 });
-            } catch (e) {
+            } catch (e: unknown) {
                 message.destroy();
-                message.error({ content: `Failed to add link: \n ${e.message || ''}`, duration: 3 });
+                if (e instanceof Error) {
+                    message.error({ content: `Failed to add link: \n ${e.message || ''}`, duration: 3 });
+                }
             }
 
             handleClose();

diff --git a/datahub-web-react/src/app/entity/shared/tabs/Documentation/components/DescriptionEditor.tsx b/datahub-web-react/src/app/entity/shared/tabs/Documentation/components/DescriptionEditor.tsx
@@ -32,9 +32,11 @@ export const DescriptionEditor = ({ onComplete }: { onComplete?: () => void }) =
             });
             message.success({ content: 'Description Updated', duration: 2 });
             if (onComplete) onComplete();
-        } catch (e) {
+        } catch (e: unknown) {
             message.destroy();
-            message.error({ content: `Failed to update description: \n ${e.message || ''}`, duration: 2 });
+            if (e instanceof Error) {
+                message.error({ content: `Failed to update description: \n ${e.message || ''}`, duration: 2 });
+            }
         }
     };
 

diff --git a/datahub-web-react/src/app/entity/shared/tabs/Documentation/components/LinkList.tsx b/datahub-web-react/src/app/entity/shared/tabs/Documentation/components/LinkList.tsx
@@ -53,9 +53,11 @@ export const LinkList = () => {
                 variables: { input: { urn, institutionalMemory: { elements: newLinks } } },
             });
             message.success({ content: 'Link Deleted', duration: 2 });
-        } catch (e) {
+        } catch (e: unknown) {
             message.destroy();
-            message.error({ content: `Error deleting link: \n ${e.message || ''}`, duration: 2 });
+            if (e instanceof Error) {
+                message.error({ content: `Error deleting link: \n ${e.message || ''}`, duration: 2 });
+            }
         }
     };