Safely access caught Error properties #3196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update in a few places to safely access caught Error properties via typescript4 `unknown on catch Clause Bindings` https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#unknown-on-catch-clause-bindings
jjoyce0510
reviewed
Sep 3, 2021
datahub-web-react/src/app/entity/shared/tabs/Documentation/components/LinkList.tsx
Outdated
Show resolved
Hide resolved
jjoyce0510
reviewed
Sep 3, 2021
| @@ -101,9 +101,9 @@ export default function DescriptionField({ | |||
| await onUpdate(desc || ''); | |||
| // message.destroy(); | |||
| // message.success({ content: 'Updated!', duration: 2 }); | |||
| } catch (e) { | |||
| } catch (e: unknown) { | |||
There was a problem hiding this comment.
Are there cases where "e" is not an Error? I have not encountered them but interested to hear if you've seen this!
There was a problem hiding this comment.
I think this is the original proposal. It tries to be more specific on the error types, like other languages. Like the example from that thread
try {
externalApi()
} catch(e) {
if (e instanceof Error) {
// Probably send this error to developer of API
} else if (e instanceof ApiError) {
// We messed up, log it and fix it in next patch
}
}
woodyzhou
reviewed
Sep 3, 2021
datahub-web-react/src/app/entity/shared/tabs/Documentation/components/LinkList.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update in a few places to safely access caught Error properties via typescript4
unknown on catch Clause Bindingshttps://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#unknown-on-catch-clause-bindingsChecklist