Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): rest emitter should override config and env variables #4622

Merged
merged 5 commits into from
Apr 18, 2022
Merged

fix(cli): rest emitter should override config and env variables #4622

merged 5 commits into from
Apr 18, 2022

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Apr 8, 2022 •
edited
Loading

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@anshbansal
Copy link
Collaborator Author

Lint might fail for Tableau source which is unrelated to this change. Already fixed in separate PR #4621

@anshbansal anshbansal changed the title fix(cli): rest emitter should override env variables fix(cli): rest emitter should override config and env variables Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022 •
edited
Loading

Unit Test Results (build & test)

  96 files  ±0    96 suites  ±0   20m 58s ⏱️ +27s
689 tests ±0  630 ✔️ ±0  59 💤 ±0  0 ❌ ±0 

Results for commit 4dc896a. ± Comparison against base commit 7b14871.

♻️ This comment has been updated with latest results.

gabe-lyons
gabe-lyons reviewed Apr 8, 2022
View reviewed changes
Copy link
Contributor

@gabe-lyons gabe-lyons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems somewhat sketchy to re-write environment variables in this way-- i could imagine it being very confusing debugging and seeing ENV variables read as different values than what my terminal prints out. Can we put this logic instead into the helper function that gets host & token?

@anshbansal
Copy link
Collaborator Author

@gabe-lyons Putting that other way around would make the utils depend on the rest emitter which seems wrong to me.

I'll see how I can change it somehow to remove the debugging confusion.

@github-actions
Copy link

github-actions bot commented Apr 8, 2022 •
edited
Loading

Unit Test Results (metadata ingestion)

       5 files  ±0         5 suites  ±0   1h 2m 43s ⏱️ + 1m 9s
   423 tests ±0     423 ✔️ ±0    0 💤 ±0  0 ❌ ±0 
2 040 runs  ±0  1 996 ✔️ ±0  44 💤 ±0  0 ❌ ±0 

Results for commit 4dc896a. ± Comparison against base commit 7b14871.

♻️ This comment has been updated with latest results.

@gabe-lyons gabe-lyons merged commit 98d4fd4 into datahub-project:master Apr 18, 2022
@anshbansal anshbansal deleted the fix-cli-config-bug branch April 18, 2022 14:31
maggiehays pushed a commit to maggiehays/datahub that referenced this pull request Aug 1, 2022
@anshbansal @maggiehays
fix(cli): rest emitter should override config and env variables (data…
7c9759c 
…hub-project#4622)

* fix(cli): rest emitter should override env variables

* fix(cli): change to not update env variables, small refactor

* fix bug
@hsheth2 hsheth2 mentioned this pull request Jul 25, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabe-lyons gabe-lyons gabe-lyons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anshbansal @gabe-lyons