fix(ingest): fix graph config loading #11002
Conversation
WalkthroughThe recent updates significantly enhance the DataHub CLI by refining configuration management and optimizing the authentication process. Key modifications include the removal of deprecated functions, clear renaming for improved understanding, and the introduction of a new, robust configuration class. These changes enable better handling of environment variables and YAML files, promoting best practices for security and flexibility. Changes
Sequence Diagram(s)sequenceDiagram
participant CLI as CLI Tools
participant Config as Config Management
participant Auth as Authentication
participant Client as DataHub Client
CLI->>Config: Load configuration
Config-->>CLI: Return configurations
CLI->>Auth: Authenticate user
Auth-->>CLI: Return session
CLI->>Client: Connect to DataHub
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
github-actions
bot
added
the
ingestion
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (8)
- metadata-ingestion/src/datahub/cli/cli_utils.py (5 hunks)
- metadata-ingestion/src/datahub/cli/config_utils.py (1 hunks)
- metadata-ingestion/src/datahub/cli/lite_cli.py (3 hunks)
- metadata-ingestion/src/datahub/emitter/rest_emitter.py (1 hunks)
- metadata-ingestion/src/datahub/entrypoints.py (3 hunks)
- metadata-ingestion/src/datahub/ingestion/graph/client.py (4 hunks)
- metadata-ingestion/src/datahub/ingestion/graph/config.py (1 hunks)
- metadata-ingestion/tests/unit/test_cli_utils.py (5 hunks)
Additional comments not posted (27)
metadata-ingestion/src/datahub/ingestion/graph/config.py (1)
11-19: LGTM! Attributes are well-defined.The attributes in the
DatahubClientConfigclass are correctly defined with appropriate types and default values.metadata-ingestion/tests/unit/test_cli_utils.py (5)
20-21: LGTM! Test correctly validates the new function.The test correctly mocks the environment variable and asserts the expected output of
_get_config_from_env.
27-28: LGTM! Test correctly validates the new function.The test correctly mocks the environment variables and asserts the expected output of
_get_config_from_env.
39-40: LGTM! Test correctly validates the new function.The test correctly mocks the environment variables and asserts the expected output of
_get_config_from_env.
52-53: LGTM! Test correctly validates the new function.The test correctly mocks the environment variables and asserts the expected output of
_get_config_from_env.
62-63: LGTM! Test correctly validates the new function.The test correctly mocks the environment variable and asserts the expected output of
_get_config_from_env.metadata-ingestion/src/datahub/cli/config_utils.py (11)
24-31: LGTM! Environment variable constants are well-defined.The new environment variable constants are correctly defined and follow best practices.
34-36: LGTM! Custom exception class is well-defined.The
MissingConfigErrorclass is correctly defined and follows best practices.
38-44: LGTM! Function correctly retrieves system client credentials.The
get_system_authfunction is correctly implemented and follows best practices.
46-47: LGTM! Function correctly checks the skip config flag.The
_should_skip_configfunction is correctly implemented and follows best practices.
50-53: LGTM! Function correctly writes configuration to a YAML file.The
persist_raw_datahub_configfunction is correctly implemented and follows best practices.
56-63: LGTM! Function correctly loads client configuration from a YAML file.The
get_raw_client_configfunction is correctly implemented and follows best practices.
65-67: LGTM! Class correctly uses Pydantic for data validation.The
DatahubConfigclass is correctly implemented and follows best practices.
69-84: LGTM! Function correctly retrieves and constructs metadata host URL.The
_get_config_from_envfunction is correctly implemented and follows best practices.
87-109: LGTM! Function correctly loads client configuration and handles errors.The
load_client_configfunction is correctly implemented, handles errors appropriately, and follows best practices.
112-116: LGTM! Function correctly checks for configuration file existence.The
_ensure_datahub_configfunction is correctly implemented and follows best practices.
119-136: LGTM! Function correctly writes GMS configuration and handles merging.The
write_gms_configfunction is correctly implemented and follows best practices.metadata-ingestion/src/datahub/entrypoints.py (2)
16-20: LGTM! Imports adjusted correctly.The import of
write_gms_confighas been adjusted to reflect its new location indatahub.cli.config_utils.
156-156: Verify the behavior ofwrite_gms_config.The
write_gms_configfunction call has been updated to include themerge_with_previous=Falseparameter. Ensure that this change aligns with the intended behavior and does not introduce any issues.Verification successful
Verified the behavior of
write_gms_config.The addition of the
merge_with_previous=Falseparameter ensures that the new configuration will not be merged with any previous configuration. This change aligns with the intended behavior and does not introduce any issues.
- The
write_gms_configfunction implementation confirms that themerge_with_previousparameter controls whether to merge the new configuration with the previous one.- Setting
merge_with_previous=Falseensures that only the new configuration is used.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the behavior of `write_gms_config` with the new parameter. # Test: Search for the `write_gms_config` function definition to understand the impact of the new parameter. rg --type python 'def write_gms_config'Length of output: 72
Script:
#!/bin/bash # Description: Verify the behavior of `write_gms_config` with the new parameter. # Find all Python files and search for the `write_gms_config` function definition. fd -e py -x rg 'def write_gms_config' {}Length of output: 66
Script:
#!/bin/bash # Description: Retrieve the full implementation of the `write_gms_config` function to verify the impact of the new parameter. # Find all Python files and search for the full implementation of the `write_gms_config` function. fd -e py -x rg -A 20 'def write_gms_config' {}Length of output: 766
metadata-ingestion/src/datahub/cli/cli_utils.py (2)
300-309: LGTM! Function renamed and logic simplified.The function
get_session_login_ashas been renamed toget_frontend_session_login_asand the logic has been streamlined by removing the conditional check for system authentication.
353-353: LGTM! Function call updated correctly.The call to
get_session_login_ashas been updated toget_frontend_session_login_asto ensure consistent usage of the updated function name.metadata-ingestion/src/datahub/emitter/rest_emitter.py (1)
13-14: LGTM! Imports adjusted correctly.The import of
get_system_authhas been adjusted to reflect its new location indatahub.cli.config_utils.metadata-ingestion/src/datahub/cli/lite_cli.py (2)
48-50: Verify downstream processing of raw configuration data.The function now calls
get_raw_client_configinstead ofget_client_config. Ensure that downstream processing can handle raw configuration data.
312-315: Verify impact on configuration storage.The function now calls
get_raw_client_configandpersist_raw_datahub_configinstead of their previous counterparts. Ensure that the configuration storage process can handle raw configuration data.metadata-ingestion/src/datahub/ingestion/graph/client.py (3)
27-30: Verify removal of deprecated configurations and functions.The import statements have been updated to reflect the removal of deprecated configurations and associated functions. Ensure that these imports and functions are no longer needed.
Line range hint
92-94:
RefactorDataHubGraphto use a different configuration approach.The class relies on
DatahubClientConfig, which has been removed. Ensure that the class is refactored to use a different configuration approach.
Line range hint
494-497:
Verify impact of update toload_client_config.The function calls
load_client_config, which has been updated. Ensure that the function can handle the updated configuration approach.
| # TODO: Having a default for the server doesn't make a ton of sense. This should be handled | ||
| # by callers / the CLI, but the actual client should not have any magic. |
There was a problem hiding this comment.
Address the TODO comment about the default server value.
Having a default server value may lead to unexpected behavior. Consider handling this in the caller or CLI.
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
docs/how/updating-datahub.md (2)
69-69: Use a proper markdown link format.The bare URL should be formatted as a proper markdown link for better readability.
- See full configuration in https://datahubproject.io/docs/python-sdk/clients/. + See full configuration in [DataHub Python SDK Clients](https://datahubproject.io/docs/python-sdk/clients/).Tools
Markdownlint
69-69: null
Bare URL used(MD034, no-bare-urls)
70-70: Use an en dash for numerical or time ranges.Replace the hyphen with an en dash for better readability.
- #11002 - We will not auto-generate a `~/.datahubenv` file. + #11002 – We will not auto-generate a `~/.datahubenv` file.Tools
LanguageTool
[typographical] ~70-
70: If you want to indicate numerical ranges or time ranges, consider using an en dash./.datahube...
Context: ...vwill apply to all CLI calls. - #11002 - We will not auto-generate a(DASH_RULE)
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (10)
- docs/how/updating-datahub.md (2 hunks)
- metadata-ingestion/src/datahub/cli/config_utils.py (1 hunks)
- metadata-ingestion/src/datahub/emitter/rest_emitter.py (2 hunks)
- metadata-ingestion/src/datahub/ingestion/graph/client.py (4 hunks)
- metadata-ingestion/src/datahub/ingestion/run/pipeline.py (1 hunks)
- metadata-ingestion/src/datahub/ingestion/run/pipeline_config.py (2 hunks)
- metadata-ingestion/src/datahub/upgrade/upgrade.py (1 hunks)
- metadata-ingestion/tests/unit/test_pipeline.py (3 hunks)
- smoke-test/smoke.sh (1 hunks)
- smoke-test/tests/utils.py (1 hunks)
Files skipped from review due to trivial changes (1)
- metadata-ingestion/src/datahub/upgrade/upgrade.py
Files skipped from review as they are similar to previous changes (2)
- metadata-ingestion/src/datahub/emitter/rest_emitter.py
- metadata-ingestion/src/datahub/ingestion/graph/client.py
Additional context used
LanguageTool
docs/how/updating-datahub.md
[typographical] ~70-
70: If you want to indicate numerical ranges or time ranges, consider using an en dash./.datahube...
Context: ...vwill apply to all CLI calls. - #11002 - We will not auto-generate a(DASH_RULE)
Markdownlint
docs/how/updating-datahub.md
69-69: null
Bare URL used(MD034, no-bare-urls)
Additional comments not posted (20)
smoke-test/smoke.sh (1)
27-27: LGTM! Ensure alignment with the overall testing strategy.Setting the
DATAHUB_GMS_URLenvironment variable tohttp://localhost:8080is useful for local testing scenarios. Ensure that this change aligns with the overall testing strategy and does not conflict with other configurations.metadata-ingestion/src/datahub/ingestion/run/pipeline_config.py (2)
6-6: LGTM! The import statement is correct.The
validatorimport frompydanticis necessary for the validation logic in thePipelineConfigclass.
9-9: LGTM! The import statement is correct.The
DatahubClientConfigimport fromdatahub.ingestion.graph.clientis necessary for thedatahub_apifield in thePipelineConfigclass.metadata-ingestion/src/datahub/cli/config_utils.py (12)
12-12: LGTM! The import statement is correct.The
ValidationErrorimport frompydanticis necessary for error handling in theload_client_configfunction.
24-32: LGTM! The environment variable constants are correctly added.The new environment variable constants for system client identification and metadata configuration improve flexibility and security in client authentication.
34-36: LGTM! The new exception class is correctly implemented.The
MissingConfigErrorclass enhances error handling by addressing cases where essential configuration files are missing.
38-45: LGTM! The new function is correctly implemented.The
get_system_authfunction retrieves system client credentials from environment variables and returns a formatted string for basic authentication if both credentials are present.
46-48: LGTM! The function renaming is correct.The renaming of the
should_skip_configfunction to_should_skip_configaligns with the convention for internal functions.
50-54: LGTM! The function renaming is correct.The renaming of the
persist_datahub_configfunction topersist_raw_datahub_configaligns with the naming convention for raw data handling functions.
56-63: LGTM! The new function is correctly implemented.The
get_raw_client_configfunction safely loads the client configuration from a YAML file and handles errors for malformed configurations.
65-67: LGTM! The new class is correctly implemented.The
DatahubConfigclass uses Pydantic for data validation, ensuring that the configuration adheres to the expected schema.
69-84: LGTM! The new function_get_config_from_envis correctly implemented.The
_get_config_from_envfunction consolidates logic for retrieving and constructing the metadata host URL from environment variables, providing backward compatibility with existing configurations.
87-110: LGTM! The new functionload_client_configis correctly implemented.The
load_client_configfunction retrieves the client configuration from environment variables or a YAML file, enhancing error handling and validation.
112-118: LGTM! The new function_ensure_datahub_configis correctly implemented.The
_ensure_datahub_configfunction checks for the presence of the configuration file and raises aMissingConfigErrorif it is not found, improving error handling.
120-137: LGTM! The new functionwrite_gms_configis correctly implemented.The
write_gms_configfunction allows merging of new configurations with existing ones, improving the usability of the configuration management process.smoke-test/tests/utils.py (1)
26-28: Verify the correctness of the new method usage.The
login_asfunction now callscli_utils.get_frontend_session_login_asinstead ofcli_utils.get_session_login_as. Ensure that the new method is correctly used and aligns with the overall objectives of the PR.metadata-ingestion/tests/unit/test_pipeline.py (2)
Line range hint
64-83:
Verify the correctness of the updated test method.The
test_configure_without_sinkmethod has been updated to use a mocked server URL (http://fake-gms-server:8080). Ensure that the update aligns with the overall objectives of the PR and that the test method correctly validates the configuration of the pipeline.Verification successful
Verification Successful:
The
test_configure_without_sinkmethod has been correctly updated to use a mocked server URL (http://fake-gms-server:8080). The changes are self-contained within the test method and do not impact other parts of the codebase.
- The method correctly validates the configuration of the pipeline with the updated server URL.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the updated test method in `test_configure_without_sink`. # Test: Search for the usage of `test_configure_without_sink` in the codebase. rg --type python -A 5 $'test_configure_without_sink'Length of output: 82
Script:
#!/bin/bash # Description: Verify the correctness of the updated test method in `test_configure_without_sink`. # Test: Search for the usage of `test_configure_without_sink` in the codebase. rg --glob '*.py' -A 5 'test_configure_without_sink'Length of output: 1028
84-118: Verify the correctness of the new test method.The
test_configure_without_sink_use_system_authmethod is newly added and validates the configuration of a pipeline when using system authentication. Ensure that the new test method aligns with the overall objectives of the PR and correctly validates the configuration of the pipeline.Verification successful
Verify the correctness of the new test method.
The
test_configure_without_sink_use_system_authmethod is newly added and validates the configuration of a pipeline when using system authentication. The method appears to be correctly defined and not misused. It aligns with the overall objectives of the PR and correctly validates the configuration of the pipeline.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the correctness of the new test method in `test_configure_without_sink_use_system_auth`. # Test: Search for the usage of `test_configure_without_sink_use_system_auth` in the codebase. rg --type python -A 5 $'test_configure_without_sink_use_system_auth'Length of output: 98
Script:
#!/bin/bash # Description: Verify the correctness of the new test method in `test_configure_without_sink_use_system_auth`. # Test: Search for the usage of `test_configure_without_sink_use_system_auth` in the codebase. rg --type py -A 5 $'test_configure_without_sink_use_system_auth'Length of output: 569
metadata-ingestion/src/datahub/ingestion/run/pipeline.py (1)
255-257: LGTM! The logging statement improves clarity.The logging statement within the
__init__method improves the clarity of the execution flow by informing users when the defaultdatahub-restsink is used.docs/how/updating-datahub.md (1)
70-70: LGTM!The changes are clear and concise.
Tools
LanguageTool
[typographical] ~70-
70: If you want to indicate numerical ranges or time ranges, consider using an en dash./.datahube...
Context: ...vwill apply to all CLI calls. - #11002 - We will not auto-generate a(DASH_RULE)
| def load_client_config() -> DatahubClientConfig: | ||
| gms_host_env, gms_token_env = _get_config_from_env() | ||
| if gms_host_env: | ||
| # TODO We should also load system auth credentials here. |
There was a problem hiding this comment.
Please follow up and create a ticket for this.
| return None | ||
|
|
||
|
|
||
| def get_raw_client_config() -> Optional[dict]: |
There was a problem hiding this comment.
This should be marked as @deprecated or renamed to _get_raw_client_config so that external uses of this instead move over to using DataHubClient class in the future.
There was a problem hiding this comment.
it's not deprecated, and is used by datahub-lite. I'm hoping the "raw" will be enough of a deterrent
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (2)
metadata-ingestion/src/datahub/ingestion/graph/client.py (2)
Line range hint
84-101:
Refactor: Remove usage of DatahubClientConfig in init method.The
__init__method usesDatahubClientConfig, which should be removed according to the summary. Refactor this method to align with the new configuration management approach.
Line range hint
139-151:
Refactor: Remove usage of DatahubClientConfig in from_emitter method.The class method
from_emitterusesDatahubClientConfig, which should be removed according to the summary. Refactor this method to align with the new configuration management approach.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- metadata-ingestion/src/datahub/emitter/rest_emitter.py (2 hunks)
- metadata-ingestion/src/datahub/ingestion/graph/client.py (5 hunks)
Files skipped from review as they are similar to previous changes (1)
- metadata-ingestion/src/datahub/emitter/rest_emitter.py
Additional comments not posted (1)
metadata-ingestion/src/datahub/ingestion/graph/client.py (1)
Line range hint
1756-1760:
Verify: Ensure get_default_graph aligns with new configuration management.The function
get_default_graphusesconfig_utils.load_client_config()andDataHubGraph. Verify that this aligns with the new configuration management approach.
* feat(forms) Handle deleting forms references when hard deleting forms (datahub-project#10820) * refactor(ui): Misc improvements to the setup ingestion flow (ingest uplift 1/2) (datahub-project#10764) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * fix(ingestion/airflow-plugin): pipeline tasks discoverable in search (datahub-project#10819) * feat(ingest/transformer): tags to terms transformer (datahub-project#10758) Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> * fix(ingestion/unity-catalog): fixed issue with profiling with GE turned on (datahub-project#10752) Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> * feat(forms) Add java SDK for form entity PATCH + CRUD examples (datahub-project#10822) * feat(SDK) Add java SDK for structuredProperty entity PATCH + CRUD examples (datahub-project#10823) * feat(SDK) Add StructuredPropertyPatchBuilder in python sdk and provide sample CRUD files (datahub-project#10824) * feat(forms) Add CRUD endpoints to GraphQL for Form entities (datahub-project#10825) * add flag for includeSoftDeleted in scroll entities API (datahub-project#10831) * feat(deprecation) Return actor entity with deprecation aspect (datahub-project#10832) * feat(structuredProperties) Add CRUD graphql APIs for structured property entities (datahub-project#10826) * add scroll parameters to openapi v3 spec (datahub-project#10833) * fix(ingest): correct profile_day_of_week implementation (datahub-project#10818) * feat(ingest/glue): allow ingestion of empty databases from Glue (datahub-project#10666) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * feat(cli): add more details to get cli (datahub-project#10815) * fix(ingestion/glue): ensure date formatting works on all platforms for aws glue (datahub-project#10836) * fix(ingestion): fix datajob patcher (datahub-project#10827) * fix(smoke-test): add suffix in temp file creation (datahub-project#10841) * feat(ingest/glue): add helper method to permit user or group ownership (datahub-project#10784) * feat(): Show data platform instances in policy modal if they are set on the policy (datahub-project#10645) Co-authored-by: Hendrik Richert <hendrik.richert@swisscom.com> * docs(patch): add patch documentation for how implementation works (datahub-project#10010) Co-authored-by: John Joyce <john@acryl.io> * fix(jar): add missing custom-plugin-jar task (datahub-project#10847) * fix(): also check exceptions/stack trace when filtering log messages (datahub-project#10391) Co-authored-by: John Joyce <john@acryl.io> * docs(): Update posts.md (datahub-project#9893) Co-authored-by: Hyejin Yoon <0327jane@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore(ingest): update acryl-datahub-classify version (datahub-project#10844) * refactor(ingest): Refactor structured logging to support infos, warnings, and failures structured reporting to UI (datahub-project#10828) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(restli): log aspect-not-found as a warning rather than as an error (datahub-project#10834) * fix(ingest/nifi): remove duplicate upstream jobs (datahub-project#10849) * fix(smoke-test): test access to create/revoke personal access tokens (datahub-project#10848) * fix(smoke-test): missing test for move domain (datahub-project#10837) * ci: update usernames to not considered for community (datahub-project#10851) * env: change defaults for data contract visibility (datahub-project#10854) * fix(ingest/tableau): quote special characters in external URL (datahub-project#10842) * fix(smoke-test): fix flakiness of auto complete test * ci(ingest): pin dask dependency for feast (datahub-project#10865) * fix(ingestion/lookml): liquid template resolution and view-to-view cll (datahub-project#10542) * feat(ingest/audit): add client id and version in system metadata props (datahub-project#10829) * chore(ingest): Mypy 1.10.1 pin (datahub-project#10867) * docs: use acryl-datahub-actions as expected python package to install (datahub-project#10852) * docs: add new js snippet (datahub-project#10846) * refactor(ingestion): remove company domain for security reason (datahub-project#10839) * fix(ingestion/spark): Platform instance and column level lineage fix (datahub-project#10843) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(ingestion/tableau): optionally ingest multiple sites and create site containers (datahub-project#10498) Co-authored-by: Yanik Häni <Yanik.Haeni1@swisscom.com> * fix(ingestion/looker): Add sqlglot dependency and remove unused sqlparser (datahub-project#10874) * fix(manage-tokens): fix manage access token policy (datahub-project#10853) * Batch get entity endpoints (datahub-project#10880) * feat(system): support conditional write semantics (datahub-project#10868) * fix(build): upgrade vercel builds to Node 20.x (datahub-project#10890) * feat(ingest/lookml): shallow clone repos (datahub-project#10888) * fix(ingest/looker): add missing dependency (datahub-project#10876) * fix(ingest): only populate audit stamps where accurate (datahub-project#10604) * fix(ingest/dbt): always encode tag urns (datahub-project#10799) * fix(ingest/redshift): handle multiline alter table commands (datahub-project#10727) * fix(ingestion/looker): column name missing in explore (datahub-project#10892) * fix(lineage) Fix lineage source/dest filtering with explored per hop limit (datahub-project#10879) * feat(conditional-writes): misc updates and fixes (datahub-project#10901) * feat(ci): update outdated action (datahub-project#10899) * feat(rest-emitter): adding async flag to rest emitter (datahub-project#10902) Co-authored-by: Gabe Lyons <gabe.lyons@acryl.io> * feat(ingest): add snowflake-queries source (datahub-project#10835) * fix(ingest): improve `auto_materialize_referenced_tags_terms` error handling (datahub-project#10906) * docs: add new company to adoption list (datahub-project#10909) * refactor(redshift): Improve redshift error handling with new structured reporting system (datahub-project#10870) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * feat(ui) Finalize support for all entity types on forms (datahub-project#10915) * Index ExecutionRequestResults status field (datahub-project#10811) * feat(ingest): grafana connector (datahub-project#10891) Co-authored-by: Shirshanka Das <shirshanka@apache.org> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(gms) Add Form entity type to EntityTypeMapper (datahub-project#10916) * feat(dataset): add support for external url in Dataset (datahub-project#10877) * docs(saas-overview) added missing features to observe section (datahub-project#10913) Co-authored-by: John Joyce <john@acryl.io> * fix(ingest/spark): Fixing Micrometer warning (datahub-project#10882) * fix(structured properties): allow application of structured properties without schema file (datahub-project#10918) * fix(data-contracts-web) handle other schedule types (datahub-project#10919) * fix(ingestion/tableau): human-readable message for PERMISSIONS_MODE_SWITCHED error (datahub-project#10866) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * Add feature flag for view defintions (datahub-project#10914) Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io> * feat(ingest/BigQuery): refactor+parallelize dataset metadata extraction (datahub-project#10884) * fix(airflow): add error handling around render_template() (datahub-project#10907) * feat(ingestion/sqlglot): add optional `default_dialect` parameter to sqlglot lineage (datahub-project#10830) * feat(mcp-mutator): new mcp mutator plugin (datahub-project#10904) * fix(ingest/bigquery): changes helper function to decode unicode scape sequences (datahub-project#10845) * feat(ingest/postgres): fetch table sizes for profile (datahub-project#10864) * feat(ingest/abs): Adding azure blob storage ingestion source (datahub-project#10813) * fix(ingest/redshift): reduce severity of SQL parsing issues (datahub-project#10924) * fix(build): fix lint fix web react (datahub-project#10896) * fix(ingest/bigquery): handle quota exceeded for project.list requests (datahub-project#10912) * feat(ingest): report extractor failures more loudly (datahub-project#10908) * feat(ingest/snowflake): integrate snowflake-queries into main source (datahub-project#10905) * fix(ingest): fix docs build (datahub-project#10926) * fix(ingest/snowflake): fix test connection (datahub-project#10927) * fix(ingest/lookml): add view load failures to cache (datahub-project#10923) * docs(slack) overhauled setup instructions and screenshots (datahub-project#10922) Co-authored-by: John Joyce <john@acryl.io> * fix(airflow): Add comma parsing of owners to DataJobs (datahub-project#10903) * fix(entityservice): fix merging sideeffects (datahub-project#10937) * feat(ingest): Support System Ingestion Sources, Show and hide system ingestion sources with Command-S (datahub-project#10938) Co-authored-by: John Joyce <john@Johns-MBP.lan> * chore() Set a default lineage filtering end time on backend when a start time is present (datahub-project#10925) Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> Co-authored-by: John Joyce <john@Johns-MBP.lan> * Added relationships APIs to V3. Added these generic APIs to V3 swagger doc. (datahub-project#10939) * docs: add learning center to docs (datahub-project#10921) * doc: Update hubspot form id (datahub-project#10943) * chore(airflow): add python 3.11 w/ Airflow 2.9 to CI (datahub-project#10941) * fix(ingest/Glue): column upstream lineage between S3 and Glue (datahub-project#10895) * fix(ingest/abs): split abs utils into multiple files (datahub-project#10945) * doc(ingest/looker): fix doc for sql parsing documentation (datahub-project#10883) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(ingest/bigquery): Adding missing BigQuery types (datahub-project#10950) * fix(ingest/setup): feast and abs source setup (datahub-project#10951) * fix(connections) Harden adding /gms to connections in backend (datahub-project#10942) * feat(siblings) Add flag to prevent combining siblings in the UI (datahub-project#10952) * fix(docs): make graphql doc gen more automated (datahub-project#10953) * feat(ingest/athena): Add option for Athena partitioned profiling (datahub-project#10723) * fix(spark-lineage): default timeout for future responses (datahub-project#10947) * feat(datajob/flow): add environment filter using info aspects (datahub-project#10814) * fix(ui/ingest): correct privilege used to show tab (datahub-project#10483) Co-authored-by: Kunal-kankriya <127090035+Kunal-kankriya@users.noreply.github.com> * feat(ingest/looker): include dashboard urns in browse v2 (datahub-project#10955) * add a structured type to batchGet in OpenAPI V3 spec (datahub-project#10956) * fix(ui): scroll on the domain sidebar to show all domains (datahub-project#10966) * fix(ingest/sagemaker): resolve incorrect variable assignment for SageMaker API call (datahub-project#10965) * fix(airflow/build): Pinning mypy (datahub-project#10972) * Fixed a bug where the OpenAPI V3 spec was incorrect. The bug was introduced in datahub-project#10939. (datahub-project#10974) * fix(ingest/test): Fix for mssql integration tests (datahub-project#10978) * fix(entity-service) exist check correctly extracts status (datahub-project#10973) * fix(structuredProps) casing bug in StructuredPropertiesValidator (datahub-project#10982) * bugfix: use anyOf instead of allOf when creating references in openapi v3 spec (datahub-project#10986) * fix(ui): Remove ant less imports (datahub-project#10988) * feat(ingest/graph): Add get_results_by_filter to DataHubGraph (datahub-project#10987) * feat(ingest/cli): init does not actually support environment variables (datahub-project#10989) * fix(ingest/graph): Update get_results_by_filter graphql query (datahub-project#10991) * feat(ingest/spark): Promote beta plugin (datahub-project#10881) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(ingest): support domains in meta -> "datahub" section (datahub-project#10967) * feat(ingest): add `check server-config` command (datahub-project#10990) * feat(cli): Make consistent use of DataHubGraphClientConfig (datahub-project#10466) Deprecates get_url_and_token() in favor of a more complete option: load_graph_config() that returns a full DatahubClientConfig. This change was then propagated across previous usages of get_url_and_token so that connections to DataHub server from the client respect the full breadth of configuration specified by DatahubClientConfig. I.e: You can now specify disable_ssl_verification: true in your ~/.datahubenv file so that all cli functions to the server work when ssl certification is disabled. Fixes datahub-project#9705 * fix(ingest/s3): Fixing container creation when there is no folder in path (datahub-project#10993) * fix(ingest/looker): support platform instance for dashboards & charts (datahub-project#10771) * feat(ingest/bigquery): improve handling of information schema in sql parser (datahub-project#10985) * feat(ingest): improve `ingest deploy` command (datahub-project#10944) * fix(backend): allow excluding soft-deleted entities in relationship-queries; exclude soft-deleted members of groups (datahub-project#10920) - allow excluding soft-deleted entities in relationship-queries - exclude soft-deleted members of groups * fix(ingest/looker): downgrade missing chart type log level (datahub-project#10996) * doc(acryl-cloud): release docs for 0.3.4.x (datahub-project#10984) Co-authored-by: John Joyce <john@acryl.io> Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Pedro Silva <pedro@acryl.io> * fix(protobuf/build): Fix protobuf check jar script (datahub-project#11006) * fix(ui/ingest): Support invalid cron jobs (datahub-project#10998) * fix(ingest): fix graph config loading (datahub-project#11002) Co-authored-by: Pedro Silva <pedro@acryl.io> * feat(docs): Document __DATAHUB_TO_FILE_ directive (datahub-project#10968) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(graphql/upsertIngestionSource): Validate cron schedule; parse error in CLI (datahub-project#11011) * feat(ece): support custom ownership type urns in ECE generation (datahub-project#10999) * feat(assertion-v2): changed Validation tab to Quality and created new Governance tab (datahub-project#10935) * fix(ingestion/glue): Add support for missing config options for profiling in Glue (datahub-project#10858) * feat(propagation): Add models for schema field docs, tags, terms (datahub-project#2959) (datahub-project#11016) Co-authored-by: Chris Collins <chriscollins3456@gmail.com> * docs: standardize terminology to DataHub Cloud (datahub-project#11003) * fix(ingestion/transformer): replace the externalUrl container (datahub-project#11013) * docs(slack) troubleshoot docs (datahub-project#11014) * feat(propagation): Add graphql API (datahub-project#11030) Co-authored-by: Chris Collins <chriscollins3456@gmail.com> * feat(propagation): Add models for Action feature settings (datahub-project#11029) * docs(custom properties): Remove duplicate from sidebar (datahub-project#11033) * feat(models): Introducing Dataset Partitions Aspect (datahub-project#10997) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * feat(propagation): Add Documentation Propagation Settings (datahub-project#11038) * fix(models): chart schema fields mapping, add dataHubAction entity, t… (datahub-project#11040) * fix(ci): smoke test lint failures (datahub-project#11044) * docs: fix learning center color scheme & typo (datahub-project#11043) * feat: add cloud main page (datahub-project#11017) Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com> * feat(restore-indices): add additional step to also clear system metadata service (datahub-project#10662) Co-authored-by: John Joyce <john@acryl.io> * docs: fix typo (datahub-project#11046) * fix(lint): apply spotless (datahub-project#11050) * docs(airflow): example query to get datajobs for a dataflow (datahub-project#11034) * feat(cli): Add run-id option to put sub-command (datahub-project#11023) Adds an option to assign run-id to a given put command execution. This is useful when transformers do not exist for a given ingestion payload, we can follow up with custom metadata and assign it to an ingestion pipeline. * fix(ingest): improve sql error reporting calls (datahub-project#11025) * fix(airflow): fix CI setup (datahub-project#11031) * feat(ingest/dbt): add experimental `prefer_sql_parser_lineage` flag (datahub-project#11039) * fix(ingestion/lookml): enable stack-trace in lookml logs (datahub-project#10971) * (chore): Linting fix (datahub-project#11015) * chore(ci): update deprecated github actions (datahub-project#10977) * Fix ALB configuration example (datahub-project#10981) * chore(ingestion-base): bump base image packages (datahub-project#11053) * feat(cli): Trim report of dataHubExecutionRequestResult to max GMS size (datahub-project#11051) * fix(ingestion/lookml): emit dummy sql condition for lookml custom condition tag (datahub-project#11008) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(ingestion/powerbi): fix issue with broken report lineage (datahub-project#10910) * feat(ingest/tableau): add retry on timeout (datahub-project#10995) * change generate kafka connect properties from env (datahub-project#10545) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> * fix(ingest): fix oracle cronjob ingestion (datahub-project#11001) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> * chore(ci): revert update deprecated github actions (datahub-project#10977) (datahub-project#11062) * feat(ingest/dbt-cloud): update metadata_endpoint inference (datahub-project#11041) * build: Reduce size of datahub-frontend-react image by 50-ish% (datahub-project#10878) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> * fix(ci): Fix lint issue in datahub_ingestion_run_summary_provider.py (datahub-project#11063) * docs(ingest): update developing-a-transformer.md (datahub-project#11019) * feat(search-test): update search tests from datahub-project#10408 (datahub-project#11056) * feat(cli): add aspects parameter to DataHubGraph.get_entity_semityped (datahub-project#11009) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * docs(airflow): update min version for plugin v2 (datahub-project#11065) * doc(ingestion/tableau): doc update for derived permission (datahub-project#11054) Co-authored-by: Pedro Silva <pedro.cls93@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(py): remove dep on types-pkg_resources (datahub-project#11076) * feat(ingest/mode): add option to exclude restricted (datahub-project#11081) * fix(ingest): set lastObserved in sdk when unset (datahub-project#11071) * doc(ingest): Update capabilities (datahub-project#11072) * chore(vulnerability): Log Injection (datahub-project#11090) * chore(vulnerability): Information exposure through a stack trace (datahub-project#11091) * chore(vulnerability): Comparison of narrow type with wide type in loop condition (datahub-project#11089) * chore(vulnerability): Insertion of sensitive information into log files (datahub-project#11088) * chore(vulnerability): Risky Cryptographic Algorithm (datahub-project#11059) * chore(vulnerability): Overly permissive regex range (datahub-project#11061) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix: update customer data (datahub-project#11075) * fix(models): fixing the datasetPartition models (datahub-project#11085) Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * fix(ui): Adding view, forms GraphQL query, remove showing a fallback error message on unhandled GraphQL error (datahub-project#11084) Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * feat(docs-site): hiding learn more from cloud page (datahub-project#11097) * fix(docs): Add correct usage of orFilters in search API docs (datahub-project#11082) Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com> * fix(ingest/mode): Regexp in mode name matcher didn't allow underscore (datahub-project#11098) * docs: Refactor customer stories section (datahub-project#10869) Co-authored-by: Jeff Merrick <jeff@wireform.io> * fix(release): fix full/slim suffix on tag (datahub-project#11087) * feat(config): support alternate hashing algorithm for doc id (datahub-project#10423) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> Co-authored-by: John Joyce <john@acryl.io> * fix(emitter): fix typo in get method of java kafka emitter (datahub-project#11007) * fix(ingest): use correct native data type in all SQLAlchemy sources by compiling data type using dialect (datahub-project#10898) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * chore: Update contributors list in PR labeler (datahub-project#11105) * feat(ingest): tweak stale entity removal messaging (datahub-project#11064) * fix(ingestion): enforce lastObserved timestamps in SystemMetadata (datahub-project#11104) * fix(ingest/powerbi): fix broken lineage between chart and dataset (datahub-project#11080) * feat(ingest/lookml): CLL support for sql set in sql_table_name attribute of lookml view (datahub-project#11069) * docs: update graphql docs on forms & structured properties (datahub-project#11100) * test(search): search openAPI v3 test (datahub-project#11049) * fix(ingest/tableau): prevent empty site content urls (datahub-project#11057) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(entity-client): implement client batch interface (datahub-project#11106) * fix(snowflake): avoid reporting warnings/info for sys tables (datahub-project#11114) * fix(ingest): downgrade column type mapping warning to info (datahub-project#11115) * feat(api): add AuditStamp to the V3 API entity/aspect response (datahub-project#11118) * fix(ingest/redshift): replace r'\n' with '\n' to avoid token error redshift serverless… (datahub-project#11111) * fix(entiy-client): handle null entityUrn case for restli (datahub-project#11122) * fix(sql-parser): prevent bad urns from alter table lineage (datahub-project#11092) * fix(ingest/bigquery): use small batch size if use_tables_list_query_v2 is set (datahub-project#11121) * fix(graphql): add missing entities to EntityTypeMapper and EntityTypeUrnMapper (datahub-project#10366) * feat(ui): Changes to allow editable dataset name (datahub-project#10608) Co-authored-by: Jay Kadambi <jayasimhan_venkatadri@optum.com> * fix: remove saxo (datahub-project#11127) * feat(mcl-processor): Update mcl processor hooks (datahub-project#11134) * fix(openapi): fix openapi v2 endpoints & v3 documentation update * Revert "fix(openapi): fix openapi v2 endpoints & v3 documentation update" This reverts commit 573c1cb. * docs(policies): updates to policies documentation (datahub-project#11073) * fix(openapi): fix openapi v2 and v3 docs update (datahub-project#11139) * feat(auth): grant type and acr values custom oidc parameters support (datahub-project#11116) * fix(mutator): mutator hook fixes (datahub-project#11140) * feat(search): support sorting on multiple fields (datahub-project#10775) * feat(ingest): various logging improvements (datahub-project#11126) * fix(ingestion/lookml): fix for sql parsing error (datahub-project#11079) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * feat(docs-site) cloud page spacing and content polishes (datahub-project#11141) * feat(ui) Enable editing structured props on fields (datahub-project#11042) * feat(tests): add md5 and last computed to testResult model (datahub-project#11117) * test(openapi): openapi regression smoke tests (datahub-project#11143) * fix(airflow): fix tox tests + update docs (datahub-project#11125) * docs: add chime to adoption stories (datahub-project#11142) * fix(ingest/databricks): Updating code to work with Databricks sdk 0.30 (datahub-project#11158) * fix(kafka-setup): add missing script to image (datahub-project#11190) * fix(config): fix hash algo config (datahub-project#11191) * test(smoke-test): updates to smoke-tests (datahub-project#11152) * fix(elasticsearch): refactor idHashAlgo setting (datahub-project#11193) * chore(kafka): kafka version bump (datahub-project#11211) * readd UsageStatsWorkUnit * fix merge problems * change logo --------- Co-authored-by: Chris Collins <chriscollins3456@gmail.com> Co-authored-by: John Joyce <john@acryl.io> Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> Co-authored-by: dushayntAW <158567391+dushayntAW@users.noreply.github.com> Co-authored-by: sagar-salvi-apptware <159135491+sagar-salvi-apptware@users.noreply.github.com> Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> Co-authored-by: Kevin Chun <kevin1chun@gmail.com> Co-authored-by: jordanjeremy <72943478+jordanjeremy@users.noreply.github.com> Co-authored-by: skrydal <piotr.skrydalewicz@gmail.com> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> Co-authored-by: sid-acryl <155424659+sid-acryl@users.noreply.github.com> Co-authored-by: Julien Jehannet <80408664+aviv-julienjehannet@users.noreply.github.com> Co-authored-by: Hendrik Richert <github@richert.li> Co-authored-by: Hendrik Richert <hendrik.richert@swisscom.com> Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com> Co-authored-by: Felix Lüdin <13187726+Masterchen09@users.noreply.github.com> Co-authored-by: Pirry <158024088+chardaway@users.noreply.github.com> Co-authored-by: Hyejin Yoon <0327jane@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: cburroughs <chris.burroughs@gmail.com> Co-authored-by: ksrinath <ksrinath@users.noreply.github.com> Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com> Co-authored-by: Kunal-kankriya <127090035+Kunal-kankriya@users.noreply.github.com> Co-authored-by: Shirshanka Das <shirshanka@apache.org> Co-authored-by: ipolding-cais <155455744+ipolding-cais@users.noreply.github.com> Co-authored-by: Tamas Nemeth <treff7es@gmail.com> Co-authored-by: Shubham Jagtap <132359390+shubhamjagtap639@users.noreply.github.com> Co-authored-by: haeniya <yanik.haeni@gmail.com> Co-authored-by: Yanik Häni <Yanik.Haeni1@swisscom.com> Co-authored-by: Gabe Lyons <itsgabelyons@gmail.com> Co-authored-by: Gabe Lyons <gabe.lyons@acryl.io> Co-authored-by: 808OVADOZE <52988741+shtephlee@users.noreply.github.com> Co-authored-by: noggi <anton.kuraev@acryl.io> Co-authored-by: Nicholas Pena <npena@foursquare.com> Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com> Co-authored-by: ethan-cartwright <ethan.cartwright.m@gmail.com> Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io> Co-authored-by: Nadav Gross <33874964+nadavgross@users.noreply.github.com> Co-authored-by: Patrick Franco Braz <patrickfbraz@poli.ufrj.br> Co-authored-by: pie1nthesky <39328908+pie1nthesky@users.noreply.github.com> Co-authored-by: Joel Pinto Mata (KPN-DSH-DEX team) <130968841+joelmataKPN@users.noreply.github.com> Co-authored-by: Ellie O'Neil <110510035+eboneil@users.noreply.github.com> Co-authored-by: Ajoy Majumdar <ajoymajumdar@hotmail.com> Co-authored-by: deepgarg-visa <149145061+deepgarg-visa@users.noreply.github.com> Co-authored-by: Tristan Heisler <tristankheisler@gmail.com> Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io> Co-authored-by: Davi Arnaut <davi.arnaut@acryl.io> Co-authored-by: Pedro Silva <pedro@acryl.io> Co-authored-by: amit-apptware <132869468+amit-apptware@users.noreply.github.com> Co-authored-by: Sam Black <sam.black@acryl.io> Co-authored-by: Raj Tekal <varadaraj_tekal@optum.com> Co-authored-by: Steffen Grohsschmiedt <gitbhub@steffeng.eu> Co-authored-by: jaegwon.seo <162448493+wornjs@users.noreply.github.com> Co-authored-by: Renan F. Lima <51028757+lima-renan@users.noreply.github.com> Co-authored-by: Matt Exchange <xkollar@users.noreply.github.com> Co-authored-by: Jonny Dixon <45681293+acrylJonny@users.noreply.github.com> Co-authored-by: Pedro Silva <pedro.cls93@gmail.com> Co-authored-by: Pinaki Bhattacharjee <pinakipb2@gmail.com> Co-authored-by: Jeff Merrick <jeff@wireform.io> Co-authored-by: skrydal <piotr.skrydalewicz@acryl.io> Co-authored-by: AndreasHegerNuritas <163423418+AndreasHegerNuritas@users.noreply.github.com> Co-authored-by: jayasimhankv <145704974+jayasimhankv@users.noreply.github.com> Co-authored-by: Jay Kadambi <jayasimhan_venkatadri@optum.com> Co-authored-by: David Leifker <david.leifker@acryl.io>
Follow up on #10466 to fix some breakages.
datahub initis now required - we won't auto-generate a default file for you._ensure_datahub_configandload_client_config, with a few additional changes inpipeline_config.pyand tests.Checklist
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores