fix(openapi): fix openapi v2 and v3 docs update

[david-leifker]

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• New Features

  • Enhanced API structure for property data, now encapsulating key attributes within a "value" object.
  • Updated methods in the EntityController to facilitate improved management of entity aspects, supporting both creation and updates.

• Bug Fixes

  • Addressed inconsistencies in the handling of the retentionTime property cardinality.

• Refactor

  • Refactored methods to improve modularity and extensibility in the handling of upsert operations across different entity types.

[coderabbitai]

Walkthrough

The recent changes enhance the API and entity management by restructuring JSON payloads for better organization and introducing a more modular approach to upsert operations. Key modifications include encapsulating certain properties in a new "value" object and refactoring controller methods to improve extensibility, allowing subclasses to define specific behaviors. This streamlining aims to improve data clarity, maintainability, and the overall functionality of entity aspect management.

Changes

Files	Change Summary
docs/api/tutorials/structured-properties.md	Introduced a new "value" object for retentionTime and retentionTime02 properties, changing retentionTime cardinality from "MULTIPLE" to "SINGLE" and adding createIfNotExists=false query parameter to API endpoints.
metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java	Altered toUpsertItem method from concrete implementation to abstract, allowing subclasses to implement specific logic, thus enhancing extensibility. Removed original parsing logic and updated exception handling.
metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java	Added new toUpsertItem method to manage upserting aspects, utilizing AspectRetriever and introducing structured handling for entity aspects including change types and audit stamps.
metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java	Similarly added new toUpsertItem method, enhancing aspect management for entities with improved capabilities for inserting or updating aspects based on provided parameters. New import statements for change management were also introduced.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant API
    participant AspectRetriever
    participant EntityController

    Client->>API: Send Upsert Request
    API->>EntityController: Call toUpsertItem
    EntityController->>AspectRetriever: Retrieve Aspect
    AspectRetriever-->>EntityController: Return Aspect Data
    EntityController->>API: Send ChangeItem
    API-->>Client: Return Success Response

Loading

🐰 In fields of green, changes arise,
New structures bloom under sunny skies.
With aspects now neatly wrapped and tight,
The code hops forward, a joyous sight!
Modular dances, each piece in tune,
Together we flourish, like flowers in June! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (8)

metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java (1)

724-731: Refactor toUpsertItem to an abstract method.

The toUpsertItem method has been refactored to an abstract method, indicating that subclasses must implement their own logic for upsert operations. This change enhances extensibility and allows subclasses to define specific behaviors for different entity types. Ensure that:

1. All subclasses correctly implement this method.
2. The new method signature aligns with the intended use cases and supports all necessary parameters.

This refactoring aligns with best practices for modularity and extensibility.

docs/api/tutorials/structured-properties.md (7)

161-191: Replace hard tabs with spaces.

The code snippet uses hard tabs for indentation, which is against the Markdownlint rule MD010. Replace hard tabs with spaces for consistency.

-	"value": {
+  "value": {

Tools

Markdownlint

161-161: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

162-162: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

163-163: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

164-164: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

165-165: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

166-166: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

167-167: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

168-168: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

169-169: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

170-170: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

171-171: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

172-172: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

173-173: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

174-174: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

175-175: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

176-176: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

177-177: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

178-178: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

179-179: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

180-180: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

181-181: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

182-182: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

183-183: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

184-184: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

185-185: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

186-186: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

187-187: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

188-188: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

189-189: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

190-190: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

191-191: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

485-494: Replace hard tabs with spaces.

The code snippet uses hard tabs for indentation, which is against the Markdownlint rule MD010. Replace hard tabs with spaces for consistency.

-	"value": {
+  "value": {

Tools

Markdownlint

485-485: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

486-486: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

487-487: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

488-488: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

489-489: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

490-490: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

491-491: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

492-492: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

493-493: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

494-494: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

640-658: Replace hard tabs with spaces.

The code snippet uses hard tabs for indentation, which is against the Markdownlint rule MD010. Replace hard tabs with spaces for consistency.

-	"value": {
+  "value": {

Tools

Markdownlint

640-640: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

641-641: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

642-642: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

643-643: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

644-644: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

645-645: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

646-646: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

647-647: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

648-648: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

649-649: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

650-650: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

651-651: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

652-652: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

653-653: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

654-654: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

655-655: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

656-656: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

657-657: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

658-658: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

705-720: Replace hard tabs with spaces.

The code snippet uses hard tabs for indentation, which is against the Markdownlint rule MD010. Replace hard tabs with spaces for consistency.

-	"value": {
+  "value": {

Tools

Markdownlint

705-705: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

706-706: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

707-707: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

708-708: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

709-709: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

710-710: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

711-711: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

712-712: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

713-713: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

714-714: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

715-715: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

716-716: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

717-717: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

718-718: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

719-719: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

720-720: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1128-1130: Replace hard tabs with spaces.

The code snippet uses hard tabs for indentation, which is against the Markdownlint rule MD010. Replace hard tabs with spaces for consistency.

-	"value": {
+  "value": {

Tools

Markdownlint

1128-1128: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1129-1129: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1130-1130: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1155-1157: Replace hard tabs with spaces.

The code snippet uses hard tabs for indentation, which is against the Markdownlint rule MD010. Replace hard tabs with spaces for consistency.

-	"value": {
+  "value": {

Tools

Markdownlint

1155-1155: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1156-1156: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1157-1157: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1296-1327: Replace hard tabs with spaces.

The code snippet uses hard tabs for indentation, which is against the Markdownlint rule MD010. Replace hard tabs with spaces for consistency.

-	"value": {
+  "value": {

Tools

Markdownlint

1296-1296: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1297-1297: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1298-1298: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1299-1299: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1300-1300: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1301-1301: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1302-1302: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1303-1303: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1304-1304: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1305-1305: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1306-1306: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1307-1307: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1308-1308: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1309-1309: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1310-1310: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1311-1311: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1312-1312: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1313-1313: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1314-1314: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1315-1315: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1316-1316: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1317-1317: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1318-1318: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1319-1319: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1320-1320: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1321-1321: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1322-1322: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1323-1323: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1324-1324: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1325-1325: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1326-1326: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1327-1327: Column: 1
Hard tabs

(MD010, no-hard-tabs)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 469654c and 1eaac69.

Files selected for processing (4)

• docs/api/tutorials/structured-properties.md (7 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/controller/GenericEntitiesController.java (4 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java (2 hunks)
• metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java (2 hunks)

Additional context used

Markdownlint

docs/api/tutorials/structured-properties.md

161-161: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

162-162: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

163-163: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

164-164: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

165-165: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

166-166: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

167-167: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

168-168: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

169-169: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

170-170: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

171-171: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

172-172: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

173-173: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

174-174: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

175-175: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

176-176: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

177-177: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

178-178: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

179-179: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

180-180: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

181-181: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

182-182: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

183-183: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

184-184: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

185-185: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

186-186: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

187-187: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

188-188: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

189-189: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

190-190: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

191-191: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

485-485: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

486-486: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

487-487: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

488-488: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

489-489: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

490-490: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

491-491: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

492-492: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

493-493: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

494-494: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

640-640: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

641-641: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

642-642: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

643-643: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

644-644: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

645-645: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

646-646: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

647-647: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

648-648: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

649-649: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

650-650: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

651-651: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

652-652: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

653-653: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

654-654: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

655-655: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

656-656: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

657-657: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

658-658: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

705-705: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

706-706: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

707-707: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

708-708: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

709-709: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

710-710: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

711-711: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

712-712: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

713-713: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

714-714: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

715-715: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

716-716: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

717-717: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

718-718: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

719-719: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

720-720: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1128-1128: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1129-1129: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1130-1130: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1155-1155: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1156-1156: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1157-1157: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1296-1296: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1297-1297: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1298-1298: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1299-1299: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1300-1300: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1301-1301: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1302-1302: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1303-1303: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1304-1304: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1305-1305: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1306-1306: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1307-1307: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1308-1308: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1309-1309: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1310-1310: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1311-1311: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1312-1312: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1313-1313: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1314-1314: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1315-1315: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1316-1316: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1317-1317: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1318-1318: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1319-1319: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1320-1320: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1321-1321: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1322-1322: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1323-1323: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1324-1324: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1325-1325: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1326-1326: Column: 1
Hard tabs

(MD010, no-hard-tabs)

---

1327-1327: Column: 1
Hard tabs

(MD010, no-hard-tabs)

Additional comments not posted (2)

metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v2/controller/EntityController.java (1)

267-287: Review the newly added toUpsertItem method.

The method toUpsertItem has been added to handle upsert operations. It constructs a ChangeItemImpl object with the appropriate change type based on createIfNotExists. The method appears to be well-structured, but ensure that:

1. The aspectRetriever is correctly initialized and used.
2. The jsonAspect is properly formatted and contains the necessary data.
3. The auditStamp is correctly generated and used for tracking changes.

Overall, the method is consistent with the described functionality and aligns with the existing code structure.

metadata-service/openapi-servlet/src/main/java/io/datahubproject/openapi/v3/controller/EntityController.java (1)

355-377: Review the newly added toUpsertItem method.

The method toUpsertItem has been added to handle upsert operations. It parses the JSON aspect, constructs a ChangeItemImpl object, and sets the appropriate change type. Ensure that:

1. The JSON parsing is robust and handles potential errors gracefully.
2. The aspectJson extraction is accurate and contains the necessary data.
3. The auditStamp is correctly generated for change tracking.

The method is consistent with its intended functionality and integrates well with the existing codebase.