feat(cli): add more details to get cli #10815
Conversation
WalkthroughThe updates primarily revise the DataHub CLI’s Changes
Poem
Tip AI model upgrade
|
github-actions
bot
added
ingestion
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- docs/how/updating-datahub.md (1 hunks)
- metadata-ingestion/src/datahub/cli/cli_utils.py (2 hunks)
- metadata-ingestion/src/datahub/cli/get_cli.py (2 hunks)
Additional context used
LanguageTool
docs/how/updating-datahub.md
[misspelling] ~42-~42: Did you mean “side effects” (=adverse effect, unintended consequence)? Open compounds are not hyphenated.
Context: ...- #10389 - Custom validators, mutators, side-effects dropped a previously required construct...(AFFECT_EFFECT)
[formatting] ~57-~57: If the ‘because’ clause is essential to the meaning, do not use a comma before the clause.
Context: ...e_compiled_code` option has been removed, because we now support capturing both source an...(COMMA_BEFORE_BECAUSE)
[uncategorized] ~60-~60: Possible missing comma found.
Context: ...UI. This does not affect URNs or lineage but primarily affects (improves) browsing e...(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~63-~63: The word ‘anyways’ is informal American English. Did you mean “anyway”?
Context: ... would have been broken since last year anyways). - #10278 - Renaming Presto-On-Hive So...(ANYWAYS)
[uncategorized] ~101-~101: Possible missing article found.
Context: ...tion is enabled, running ingestion with latest cli version will perform all required c...(AI_HYDRA_LEO_MISSING_THE)
[uncategorized] ~124-~124: This expression is usually spelled with a hyphen.
Context: ...a tuple of timestamps. - #8951: A great expectations based profiler has been added for the Unity C...(BASED_HYPHEN)
[uncategorized] ~124-~124: The preposition ‘to’ seems more likely in this position.
Context: ...ectations based profiler has been added for the Unity Catalog source. To use the ...(AI_HYDRA_LEO_REPLACE_FOR_TO)
[uncategorized] ~140-~140: A comma is probably missing here.
Context: ...llowed, this is no longer the case. For simplicity you can use thetypeparameter which ...(MISSING_COMMA_AFTER_INTRODUCTORY_PHRASE)
[uncategorized] ~188-~188: A different word order might sound more natural.
Context: ...ingdatahub putcommand. Policies can be also removed and re-created via UI. - #9077...(AI_HYDRA_LEO_WORD_ORDER)
[uncategorized] ~215-~215: Possible missing comma found.
Context: ...ing indices. Asystem-updatejob will run which will set indices to read-only and...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~215-~215: Possible missing comma found.
Context: ... backup/clone of each index. During the reindexing new components will be prevented from s...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~224-~224: It appears that a comma is missing.
Context: .... ### Other Notable Changes - In this release we now enable you to create and delete ...(DURING_THAT_TIME_COMMA)
[uncategorized] ~224-~224: Possible missing comma found.
Context: ...e the “Manage Home Page Posts” platform privilege you’ll see a new section in settings ca...(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~225-~225: Consider using a more formal alternative.
Context: ...ut our release notes for v0.10.5 to get more information and documentation on this new Browse ex...(MORE_INFO)
[uncategorized] ~228-~228: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ... container db (None) -> container schema and now we have platform_instance -> contai...(COMMA_COMPOUND_SENTENCE)
[style] ~231-~231: Consider using “who” when you are referring to people instead of objects.
Context: ... default. This will only affect users that were depending on this aspect for custo...(THAT_WHO)
[grammar] ~231-~231: The verb ‘depend’ can be stative. If ‘depending’ describes a state, change the sentence structure and use the base form of the verb.
Context: ...ult. This will only affect users that were depending on this aspect for custom functionality...(PROGRESSIVE_VERBS)
[uncategorized] ~248-~248: When ‘follow-up’ is used as a noun or modifier, it needs to be hyphenated.
Context: ... generated by the Okta source. And in a follow upokta_profile_to_username_regexhas be...(VERB_NOUN_CONFUSION)
[style] ~269-~269: Consider shortening this phrase to just ‘whether’, unless you mean ‘regardless of whether’.
Context: ...is disabled by default. You can control whether or not you want to see just the new search fil...(WHETHER)
[style] ~273-~273: Consider a shorter alternative to avoid wordiness.
Context: ...ll try to fetch their parent containers in order to generate this new aspect. For those dep...(IN_ORDER_TO_PREMIUM)
[uncategorized] ~273-~273: Possible missing comma found.
Context: ... whether running this upgrade job makes sense as it may be a heavy operation and take...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~273-~273: Possible missing comma found.
Context: ...sebrowsePathsV2aspects when running ingestion otherwise your browse sidebar will be o...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~274-~274: The word “however” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: ...e to do the same with the new experience, however you will have to generate `browsePathsV...(HOWEVER_SENTENCE)
[uncategorized] ~294-~294: Possible missing comma found.
Context: ...the fully qualified name of the catalog/schema instead of just the name. Unless you're...(AI_HYDRA_LEO_MISSING_COMMA)
[typographical] ~312-~312: The word “otherwise” is an adverb that can’t be used like a conjunction, and therefore needs to be separated from the sentence.
Context: .... ONLY breaking if you set this flag to true, otherwise behavior remains the same. - The Airflo...(THUS_SENTENCE)
[uncategorized] ~332-~332: Possible missing comma found.
Context: ...ing indices. Asystem-updatejob will run which will set indices to read-only and...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~332-~332: Possible missing comma found.
Context: ... backup/clone of each index. During the reindexing new components will be prevented from s...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~338-~338: Possible missing comma found.
Context: ...--atomicsetting for this particular upgrade since the system update job will be ter...(AI_HYDRA_LEO_MISSING_COMMA)
[formatting] ~357-~357: Consider inserting a comma after ‘login’ to make the sentence clearer.
Context: ... Changes - If anyone faces issues with login please clear your cookies. Some securit...(IF_CLAUSE_COMMA)
[uncategorized] ~363-~363: Possible missing preposition found.
Context: ...d it is shifted as plugin. Please refer updated documentation [Configuring Authorizatio...(AI_HYDRA_LEO_MISSING_TO)
[uncategorized] ~365-~365: Possible missing preposition found.
Context: ...main/resources/application.yaml). Refer documentation [Migration Of Plugins From application....(AI_HYDRA_LEO_MISSING_TO)
[uncategorized] ~368-~368: Did you mean “is”?
Context: ...ash with non-sharded tables. This means if stateful ingestion is enabled then old ...(IF_IS_PREMIUM)
[typographical] ~415-~415: Consider adding a comma.
Context: ...query. If you are usingbigquery-betathen change your recipes to use the typebi...(IF_THEN_COMMA)
[uncategorized] ~428-~428: Possible missing comma found.
Context: ...ries, the input no longer supports value but instead now accepts a list of values. T...(AI_HYDRA_LEO_MISSING_COMMA)
[uncategorized] ~428-~428: Possible missing comma found.
Context: ...of values. These values represent an OR relationship where the field value must match any of...(AI_HYDRA_LEO_MISSING_COMMA)
[style] ~459-~459: ‘with the intention of’ might be wordy. Consider a shorter alternative.
Context: ...d to a new format to align more closely with the intention of the feature. Learn more about the cha...(EN_WORDINESS_PREMIUM_WITH_THE_INTENTION_OF)
[style] ~467-~467: Consider using “incompatible” to avoid wordiness.
Context: ...on in debug mode. Previous versions are not compatible with this release. Upgrading to helm ...(NOT_ABLE_PREMIUM)
[typographical] ~563-~563: It appears that a comma is missing.
Context: ....8.36` ### Breaking Changes - In this release we introduce a brand new Business Gloss...(DURING_THAT_TIME_COMMA)
[style] ~563-~563: Consider a shorter alternative to avoid wordiness.
Context: ...ce comes some new ways of indexing data in order to make viewing and traversing the differe...(IN_ORDER_TO_PREMIUM)
[uncategorized] ~571-~571: Possible missing comma found.
Context: ...61 Dropped profiling is not reported by default as that caused a lot of spurious loggin...(AI_HYDRA_LEO_MISSING_COMMA)
Markdownlint
docs/how/updating-datahub.md
23-23: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
31-31: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
84-84: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
93-93: null
Fenced code blocks should have a language specified(MD040, fenced-code-language)
Additional comments not posted (4)
metadata-ingestion/src/datahub/cli/get_cli.py (2)
Line range hint
35-52: LGTM!The code changes are approved.
24-31: Ensure correct usage of theversionparameter.The new
versionparameter should be integrated correctly. Verify that the version parameter is being used correctly throughout the codebase.metadata-ingestion/src/datahub/cli/cli_utils.py (1)
557-562: LGTM!The code changes are approved. The
versionparameter is handled correctly.docs/how/updating-datahub.md (1)
25-25: Ensure clarity and accuracy of documentation.The documentation changes are clear and accurate. Ensure that the instructions are easy to follow.
| @@ -522,6 +522,7 @@ def get_aspects_for_entity( | |||
| aspects: List[str], | |||
| typed: bool = False, | |||
| cached_session_host: Optional[Tuple[Session, str]] = None, | |||
| version: int = 1, | |||
There was a problem hiding this comment.
Tip
Codebase Verification
Ensure correct usage of the version parameter.
The new version parameter is missing in several calls to the get_aspects_for_entity function. Please update the following files to include the version parameter:
smoke-test/tests/telemetry/telemetry_test.pysmoke-test/tests/delete/delete_test.pysmoke-test/tests/cli/datahub_cli.pymetadata-ingestion/examples/library/dataset_query_description.pymetadata-ingestion/examples/library/dataset_query_owners.pymetadata-ingestion/examples/library/dataset_query_entity_v2.pymetadata-ingestion/examples/library/dataset_query_tags.pymetadata-ingestion/examples/library/dataset_query_deprecation.pymetadata-ingestion/examples/library/dataset_query_domain.pymetadata-ingestion/examples/library/dataset_query_description_on_columns.pymetadata-ingestion/examples/library/dataset_query_terms.pymetadata-ingestion/src/datahub/cli/migrate.pymetadata-ingestion/src/datahub/cli/migration_utils.pymetadata-ingestion/src/datahub/cli/cli_utils.pymetadata-ingestion/src/datahub/cli/get_cli.pymetadata-ingestion/src/datahub/ingestion/source/metadata/lineage.pymetadata-ingestion/src/datahub/ingestion/graph/client.py
Analysis chain
Ensure correct usage of the version parameter.
The new version parameter should be integrated correctly. Verify that the version parameter is being used correctly throughout the codebase.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify all function calls to `get_aspects_for_entity` match the new signature.
# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg --type python $'get_aspects_for_entity'
Length of output: 72
Script:
#!/bin/bash
# Description: Verify all function calls to `get_aspects_for_entity` match the new signature.
# Test: Search for the function usage. Expect: Only occurrences of the new signature.
rg 'get_aspects_for_entity'
Length of output: 3859
Script:
#!/bin/bash
# Description: Verify all function calls to `get_aspects_for_entity` include the `version` parameter.
# List of files to check
files=$(rg -l 'get_aspects_for_entity')
# Check each file for the new function signature
for file in $files; do
echo "Checking $file"
rg 'get_aspects_for_entity\([^)]*version' $file || echo "Missing version parameter in $file"
done
Length of output: 8414
|
Suggest using a different way of switching to the detailed output format instead of using a version switch. Eg We might need version later if we have versioned entities and need to get metadata for a specific version of an entity. |
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- docs/how/updating-datahub.md (1 hunks)
- metadata-ingestion/src/datahub/cli/cli_utils.py (2 hunks)
- metadata-ingestion/src/datahub/cli/get_cli.py (2 hunks)
Files skipped from review as they are similar to previous changes (2)
- metadata-ingestion/src/datahub/cli/cli_utils.py
- metadata-ingestion/src/datahub/cli/get_cli.py
Additional context used
Markdownlint
docs/how/updating-datahub.md
23-23: Expected: 0 or 2; Actual: 1
Trailing spaces(MD009, no-trailing-spaces)
Additional comments not posted (1)
docs/how/updating-datahub.md (1)
25-25: Document CLI output format change clearly.The change to the CLI output format is documented correctly. Ensure that users understand the impact of this change and how to use the
--no-detailsflag to revert to the older format.
docs/how/updating-datahub.md
Outdated
| @@ -22,6 +22,7 @@ This file documents any backwards-incompatible changes in DataHub and assists pe | |||
|
|
|||
| - Protobuf CLI will no longer create binary encoded protoc custom properties. Flag added `-protocProp` in case this | |||
| behavior is required. | |||
| - `datahub get ...` CLI output format changed a bit. To use the older output format pass `datahub get --no-details ...` | |||
There was a problem hiding this comment.
Is there a downside to leaving the default to be the concise (--no-details) option? That way, we don't unintentionally break anyone who might be using this as an unofficial contract.
There was a problem hiding this comment.
Most people won't find out the flag exists. We have a lot of CLI commands but because of not enough docs folks never discover they exist. I was hoping to make a more sane default.
But I can revert this breaking change. Not a hard requirmeent to do the breaking change.
| "--details/--no-details", | ||
| required=False, | ||
| is_flag=True, | ||
| default=True, |
| required=False, | ||
| is_flag=True, | ||
| default=True, | ||
| help="Whether to .", |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- metadata-ingestion/src/datahub/cli/get_cli.py (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- metadata-ingestion/src/datahub/cli/get_cli.py
* feat(forms) Handle deleting forms references when hard deleting forms (datahub-project#10820) * refactor(ui): Misc improvements to the setup ingestion flow (ingest uplift 1/2) (datahub-project#10764) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * fix(ingestion/airflow-plugin): pipeline tasks discoverable in search (datahub-project#10819) * feat(ingest/transformer): tags to terms transformer (datahub-project#10758) Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> * fix(ingestion/unity-catalog): fixed issue with profiling with GE turned on (datahub-project#10752) Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> * feat(forms) Add java SDK for form entity PATCH + CRUD examples (datahub-project#10822) * feat(SDK) Add java SDK for structuredProperty entity PATCH + CRUD examples (datahub-project#10823) * feat(SDK) Add StructuredPropertyPatchBuilder in python sdk and provide sample CRUD files (datahub-project#10824) * feat(forms) Add CRUD endpoints to GraphQL for Form entities (datahub-project#10825) * add flag for includeSoftDeleted in scroll entities API (datahub-project#10831) * feat(deprecation) Return actor entity with deprecation aspect (datahub-project#10832) * feat(structuredProperties) Add CRUD graphql APIs for structured property entities (datahub-project#10826) * add scroll parameters to openapi v3 spec (datahub-project#10833) * fix(ingest): correct profile_day_of_week implementation (datahub-project#10818) * feat(ingest/glue): allow ingestion of empty databases from Glue (datahub-project#10666) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * feat(cli): add more details to get cli (datahub-project#10815) * fix(ingestion/glue): ensure date formatting works on all platforms for aws glue (datahub-project#10836) * fix(ingestion): fix datajob patcher (datahub-project#10827) * fix(smoke-test): add suffix in temp file creation (datahub-project#10841) * feat(ingest/glue): add helper method to permit user or group ownership (datahub-project#10784) * feat(): Show data platform instances in policy modal if they are set on the policy (datahub-project#10645) Co-authored-by: Hendrik Richert <hendrik.richert@swisscom.com> * docs(patch): add patch documentation for how implementation works (datahub-project#10010) Co-authored-by: John Joyce <john@acryl.io> * fix(jar): add missing custom-plugin-jar task (datahub-project#10847) * fix(): also check exceptions/stack trace when filtering log messages (datahub-project#10391) Co-authored-by: John Joyce <john@acryl.io> * docs(): Update posts.md (datahub-project#9893) Co-authored-by: Hyejin Yoon <0327jane@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore(ingest): update acryl-datahub-classify version (datahub-project#10844) * refactor(ingest): Refactor structured logging to support infos, warnings, and failures structured reporting to UI (datahub-project#10828) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(restli): log aspect-not-found as a warning rather than as an error (datahub-project#10834) * fix(ingest/nifi): remove duplicate upstream jobs (datahub-project#10849) * fix(smoke-test): test access to create/revoke personal access tokens (datahub-project#10848) * fix(smoke-test): missing test for move domain (datahub-project#10837) * ci: update usernames to not considered for community (datahub-project#10851) * env: change defaults for data contract visibility (datahub-project#10854) * fix(ingest/tableau): quote special characters in external URL (datahub-project#10842) * fix(smoke-test): fix flakiness of auto complete test * ci(ingest): pin dask dependency for feast (datahub-project#10865) * fix(ingestion/lookml): liquid template resolution and view-to-view cll (datahub-project#10542) * feat(ingest/audit): add client id and version in system metadata props (datahub-project#10829) * chore(ingest): Mypy 1.10.1 pin (datahub-project#10867) * docs: use acryl-datahub-actions as expected python package to install (datahub-project#10852) * docs: add new js snippet (datahub-project#10846) * refactor(ingestion): remove company domain for security reason (datahub-project#10839) * fix(ingestion/spark): Platform instance and column level lineage fix (datahub-project#10843) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(ingestion/tableau): optionally ingest multiple sites and create site containers (datahub-project#10498) Co-authored-by: Yanik Häni <Yanik.Haeni1@swisscom.com> * fix(ingestion/looker): Add sqlglot dependency and remove unused sqlparser (datahub-project#10874) * fix(manage-tokens): fix manage access token policy (datahub-project#10853) * Batch get entity endpoints (datahub-project#10880) * feat(system): support conditional write semantics (datahub-project#10868) * fix(build): upgrade vercel builds to Node 20.x (datahub-project#10890) * feat(ingest/lookml): shallow clone repos (datahub-project#10888) * fix(ingest/looker): add missing dependency (datahub-project#10876) * fix(ingest): only populate audit stamps where accurate (datahub-project#10604) * fix(ingest/dbt): always encode tag urns (datahub-project#10799) * fix(ingest/redshift): handle multiline alter table commands (datahub-project#10727) * fix(ingestion/looker): column name missing in explore (datahub-project#10892) * fix(lineage) Fix lineage source/dest filtering with explored per hop limit (datahub-project#10879) * feat(conditional-writes): misc updates and fixes (datahub-project#10901) * feat(ci): update outdated action (datahub-project#10899) * feat(rest-emitter): adding async flag to rest emitter (datahub-project#10902) Co-authored-by: Gabe Lyons <gabe.lyons@acryl.io> * feat(ingest): add snowflake-queries source (datahub-project#10835) * fix(ingest): improve `auto_materialize_referenced_tags_terms` error handling (datahub-project#10906) * docs: add new company to adoption list (datahub-project#10909) * refactor(redshift): Improve redshift error handling with new structured reporting system (datahub-project#10870) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * feat(ui) Finalize support for all entity types on forms (datahub-project#10915) * Index ExecutionRequestResults status field (datahub-project#10811) * feat(ingest): grafana connector (datahub-project#10891) Co-authored-by: Shirshanka Das <shirshanka@apache.org> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(gms) Add Form entity type to EntityTypeMapper (datahub-project#10916) * feat(dataset): add support for external url in Dataset (datahub-project#10877) * docs(saas-overview) added missing features to observe section (datahub-project#10913) Co-authored-by: John Joyce <john@acryl.io> * fix(ingest/spark): Fixing Micrometer warning (datahub-project#10882) * fix(structured properties): allow application of structured properties without schema file (datahub-project#10918) * fix(data-contracts-web) handle other schedule types (datahub-project#10919) * fix(ingestion/tableau): human-readable message for PERMISSIONS_MODE_SWITCHED error (datahub-project#10866) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * Add feature flag for view defintions (datahub-project#10914) Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io> * feat(ingest/BigQuery): refactor+parallelize dataset metadata extraction (datahub-project#10884) * fix(airflow): add error handling around render_template() (datahub-project#10907) * feat(ingestion/sqlglot): add optional `default_dialect` parameter to sqlglot lineage (datahub-project#10830) * feat(mcp-mutator): new mcp mutator plugin (datahub-project#10904) * fix(ingest/bigquery): changes helper function to decode unicode scape sequences (datahub-project#10845) * feat(ingest/postgres): fetch table sizes for profile (datahub-project#10864) * feat(ingest/abs): Adding azure blob storage ingestion source (datahub-project#10813) * fix(ingest/redshift): reduce severity of SQL parsing issues (datahub-project#10924) * fix(build): fix lint fix web react (datahub-project#10896) * fix(ingest/bigquery): handle quota exceeded for project.list requests (datahub-project#10912) * feat(ingest): report extractor failures more loudly (datahub-project#10908) * feat(ingest/snowflake): integrate snowflake-queries into main source (datahub-project#10905) * fix(ingest): fix docs build (datahub-project#10926) * fix(ingest/snowflake): fix test connection (datahub-project#10927) * fix(ingest/lookml): add view load failures to cache (datahub-project#10923) * docs(slack) overhauled setup instructions and screenshots (datahub-project#10922) Co-authored-by: John Joyce <john@acryl.io> * fix(airflow): Add comma parsing of owners to DataJobs (datahub-project#10903) * fix(entityservice): fix merging sideeffects (datahub-project#10937) * feat(ingest): Support System Ingestion Sources, Show and hide system ingestion sources with Command-S (datahub-project#10938) Co-authored-by: John Joyce <john@Johns-MBP.lan> * chore() Set a default lineage filtering end time on backend when a start time is present (datahub-project#10925) Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> Co-authored-by: John Joyce <john@Johns-MBP.lan> * Added relationships APIs to V3. Added these generic APIs to V3 swagger doc. (datahub-project#10939) * docs: add learning center to docs (datahub-project#10921) * doc: Update hubspot form id (datahub-project#10943) * chore(airflow): add python 3.11 w/ Airflow 2.9 to CI (datahub-project#10941) * fix(ingest/Glue): column upstream lineage between S3 and Glue (datahub-project#10895) * fix(ingest/abs): split abs utils into multiple files (datahub-project#10945) * doc(ingest/looker): fix doc for sql parsing documentation (datahub-project#10883) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(ingest/bigquery): Adding missing BigQuery types (datahub-project#10950) * fix(ingest/setup): feast and abs source setup (datahub-project#10951) * fix(connections) Harden adding /gms to connections in backend (datahub-project#10942) * feat(siblings) Add flag to prevent combining siblings in the UI (datahub-project#10952) * fix(docs): make graphql doc gen more automated (datahub-project#10953) * feat(ingest/athena): Add option for Athena partitioned profiling (datahub-project#10723) * fix(spark-lineage): default timeout for future responses (datahub-project#10947) * feat(datajob/flow): add environment filter using info aspects (datahub-project#10814) * fix(ui/ingest): correct privilege used to show tab (datahub-project#10483) Co-authored-by: Kunal-kankriya <127090035+Kunal-kankriya@users.noreply.github.com> * feat(ingest/looker): include dashboard urns in browse v2 (datahub-project#10955) * add a structured type to batchGet in OpenAPI V3 spec (datahub-project#10956) * fix(ui): scroll on the domain sidebar to show all domains (datahub-project#10966) * fix(ingest/sagemaker): resolve incorrect variable assignment for SageMaker API call (datahub-project#10965) * fix(airflow/build): Pinning mypy (datahub-project#10972) * Fixed a bug where the OpenAPI V3 spec was incorrect. The bug was introduced in datahub-project#10939. (datahub-project#10974) * fix(ingest/test): Fix for mssql integration tests (datahub-project#10978) * fix(entity-service) exist check correctly extracts status (datahub-project#10973) * fix(structuredProps) casing bug in StructuredPropertiesValidator (datahub-project#10982) * bugfix: use anyOf instead of allOf when creating references in openapi v3 spec (datahub-project#10986) * fix(ui): Remove ant less imports (datahub-project#10988) * feat(ingest/graph): Add get_results_by_filter to DataHubGraph (datahub-project#10987) * feat(ingest/cli): init does not actually support environment variables (datahub-project#10989) * fix(ingest/graph): Update get_results_by_filter graphql query (datahub-project#10991) * feat(ingest/spark): Promote beta plugin (datahub-project#10881) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(ingest): support domains in meta -> "datahub" section (datahub-project#10967) * feat(ingest): add `check server-config` command (datahub-project#10990) * feat(cli): Make consistent use of DataHubGraphClientConfig (datahub-project#10466) Deprecates get_url_and_token() in favor of a more complete option: load_graph_config() that returns a full DatahubClientConfig. This change was then propagated across previous usages of get_url_and_token so that connections to DataHub server from the client respect the full breadth of configuration specified by DatahubClientConfig. I.e: You can now specify disable_ssl_verification: true in your ~/.datahubenv file so that all cli functions to the server work when ssl certification is disabled. Fixes datahub-project#9705 * fix(ingest/s3): Fixing container creation when there is no folder in path (datahub-project#10993) * fix(ingest/looker): support platform instance for dashboards & charts (datahub-project#10771) * feat(ingest/bigquery): improve handling of information schema in sql parser (datahub-project#10985) * feat(ingest): improve `ingest deploy` command (datahub-project#10944) * fix(backend): allow excluding soft-deleted entities in relationship-queries; exclude soft-deleted members of groups (datahub-project#10920) - allow excluding soft-deleted entities in relationship-queries - exclude soft-deleted members of groups * fix(ingest/looker): downgrade missing chart type log level (datahub-project#10996) * doc(acryl-cloud): release docs for 0.3.4.x (datahub-project#10984) Co-authored-by: John Joyce <john@acryl.io> Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Pedro Silva <pedro@acryl.io> * fix(protobuf/build): Fix protobuf check jar script (datahub-project#11006) * fix(ui/ingest): Support invalid cron jobs (datahub-project#10998) * fix(ingest): fix graph config loading (datahub-project#11002) Co-authored-by: Pedro Silva <pedro@acryl.io> * feat(docs): Document __DATAHUB_TO_FILE_ directive (datahub-project#10968) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(graphql/upsertIngestionSource): Validate cron schedule; parse error in CLI (datahub-project#11011) * feat(ece): support custom ownership type urns in ECE generation (datahub-project#10999) * feat(assertion-v2): changed Validation tab to Quality and created new Governance tab (datahub-project#10935) * fix(ingestion/glue): Add support for missing config options for profiling in Glue (datahub-project#10858) * feat(propagation): Add models for schema field docs, tags, terms (datahub-project#2959) (datahub-project#11016) Co-authored-by: Chris Collins <chriscollins3456@gmail.com> * docs: standardize terminology to DataHub Cloud (datahub-project#11003) * fix(ingestion/transformer): replace the externalUrl container (datahub-project#11013) * docs(slack) troubleshoot docs (datahub-project#11014) * feat(propagation): Add graphql API (datahub-project#11030) Co-authored-by: Chris Collins <chriscollins3456@gmail.com> * feat(propagation): Add models for Action feature settings (datahub-project#11029) * docs(custom properties): Remove duplicate from sidebar (datahub-project#11033) * feat(models): Introducing Dataset Partitions Aspect (datahub-project#10997) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * feat(propagation): Add Documentation Propagation Settings (datahub-project#11038) * fix(models): chart schema fields mapping, add dataHubAction entity, t… (datahub-project#11040) * fix(ci): smoke test lint failures (datahub-project#11044) * docs: fix learning center color scheme & typo (datahub-project#11043) * feat: add cloud main page (datahub-project#11017) Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com> * feat(restore-indices): add additional step to also clear system metadata service (datahub-project#10662) Co-authored-by: John Joyce <john@acryl.io> * docs: fix typo (datahub-project#11046) * fix(lint): apply spotless (datahub-project#11050) * docs(airflow): example query to get datajobs for a dataflow (datahub-project#11034) * feat(cli): Add run-id option to put sub-command (datahub-project#11023) Adds an option to assign run-id to a given put command execution. This is useful when transformers do not exist for a given ingestion payload, we can follow up with custom metadata and assign it to an ingestion pipeline. * fix(ingest): improve sql error reporting calls (datahub-project#11025) * fix(airflow): fix CI setup (datahub-project#11031) * feat(ingest/dbt): add experimental `prefer_sql_parser_lineage` flag (datahub-project#11039) * fix(ingestion/lookml): enable stack-trace in lookml logs (datahub-project#10971) * (chore): Linting fix (datahub-project#11015) * chore(ci): update deprecated github actions (datahub-project#10977) * Fix ALB configuration example (datahub-project#10981) * chore(ingestion-base): bump base image packages (datahub-project#11053) * feat(cli): Trim report of dataHubExecutionRequestResult to max GMS size (datahub-project#11051) * fix(ingestion/lookml): emit dummy sql condition for lookml custom condition tag (datahub-project#11008) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(ingestion/powerbi): fix issue with broken report lineage (datahub-project#10910) * feat(ingest/tableau): add retry on timeout (datahub-project#10995) * change generate kafka connect properties from env (datahub-project#10545) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> * fix(ingest): fix oracle cronjob ingestion (datahub-project#11001) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> * chore(ci): revert update deprecated github actions (datahub-project#10977) (datahub-project#11062) * feat(ingest/dbt-cloud): update metadata_endpoint inference (datahub-project#11041) * build: Reduce size of datahub-frontend-react image by 50-ish% (datahub-project#10878) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> * fix(ci): Fix lint issue in datahub_ingestion_run_summary_provider.py (datahub-project#11063) * docs(ingest): update developing-a-transformer.md (datahub-project#11019) * feat(search-test): update search tests from datahub-project#10408 (datahub-project#11056) * feat(cli): add aspects parameter to DataHubGraph.get_entity_semityped (datahub-project#11009) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * docs(airflow): update min version for plugin v2 (datahub-project#11065) * doc(ingestion/tableau): doc update for derived permission (datahub-project#11054) Co-authored-by: Pedro Silva <pedro.cls93@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(py): remove dep on types-pkg_resources (datahub-project#11076) * feat(ingest/mode): add option to exclude restricted (datahub-project#11081) * fix(ingest): set lastObserved in sdk when unset (datahub-project#11071) * doc(ingest): Update capabilities (datahub-project#11072) * chore(vulnerability): Log Injection (datahub-project#11090) * chore(vulnerability): Information exposure through a stack trace (datahub-project#11091) * chore(vulnerability): Comparison of narrow type with wide type in loop condition (datahub-project#11089) * chore(vulnerability): Insertion of sensitive information into log files (datahub-project#11088) * chore(vulnerability): Risky Cryptographic Algorithm (datahub-project#11059) * chore(vulnerability): Overly permissive regex range (datahub-project#11061) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix: update customer data (datahub-project#11075) * fix(models): fixing the datasetPartition models (datahub-project#11085) Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * fix(ui): Adding view, forms GraphQL query, remove showing a fallback error message on unhandled GraphQL error (datahub-project#11084) Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * feat(docs-site): hiding learn more from cloud page (datahub-project#11097) * fix(docs): Add correct usage of orFilters in search API docs (datahub-project#11082) Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com> * fix(ingest/mode): Regexp in mode name matcher didn't allow underscore (datahub-project#11098) * docs: Refactor customer stories section (datahub-project#10869) Co-authored-by: Jeff Merrick <jeff@wireform.io> * fix(release): fix full/slim suffix on tag (datahub-project#11087) * feat(config): support alternate hashing algorithm for doc id (datahub-project#10423) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> Co-authored-by: John Joyce <john@acryl.io> * fix(emitter): fix typo in get method of java kafka emitter (datahub-project#11007) * fix(ingest): use correct native data type in all SQLAlchemy sources by compiling data type using dialect (datahub-project#10898) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * chore: Update contributors list in PR labeler (datahub-project#11105) * feat(ingest): tweak stale entity removal messaging (datahub-project#11064) * fix(ingestion): enforce lastObserved timestamps in SystemMetadata (datahub-project#11104) * fix(ingest/powerbi): fix broken lineage between chart and dataset (datahub-project#11080) * feat(ingest/lookml): CLL support for sql set in sql_table_name attribute of lookml view (datahub-project#11069) * docs: update graphql docs on forms & structured properties (datahub-project#11100) * test(search): search openAPI v3 test (datahub-project#11049) * fix(ingest/tableau): prevent empty site content urls (datahub-project#11057) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(entity-client): implement client batch interface (datahub-project#11106) * fix(snowflake): avoid reporting warnings/info for sys tables (datahub-project#11114) * fix(ingest): downgrade column type mapping warning to info (datahub-project#11115) * feat(api): add AuditStamp to the V3 API entity/aspect response (datahub-project#11118) * fix(ingest/redshift): replace r'\n' with '\n' to avoid token error redshift serverless… (datahub-project#11111) * fix(entiy-client): handle null entityUrn case for restli (datahub-project#11122) * fix(sql-parser): prevent bad urns from alter table lineage (datahub-project#11092) * fix(ingest/bigquery): use small batch size if use_tables_list_query_v2 is set (datahub-project#11121) * fix(graphql): add missing entities to EntityTypeMapper and EntityTypeUrnMapper (datahub-project#10366) * feat(ui): Changes to allow editable dataset name (datahub-project#10608) Co-authored-by: Jay Kadambi <jayasimhan_venkatadri@optum.com> * fix: remove saxo (datahub-project#11127) * feat(mcl-processor): Update mcl processor hooks (datahub-project#11134) * fix(openapi): fix openapi v2 endpoints & v3 documentation update * Revert "fix(openapi): fix openapi v2 endpoints & v3 documentation update" This reverts commit 573c1cb. * docs(policies): updates to policies documentation (datahub-project#11073) * fix(openapi): fix openapi v2 and v3 docs update (datahub-project#11139) * feat(auth): grant type and acr values custom oidc parameters support (datahub-project#11116) * fix(mutator): mutator hook fixes (datahub-project#11140) * feat(search): support sorting on multiple fields (datahub-project#10775) * feat(ingest): various logging improvements (datahub-project#11126) * fix(ingestion/lookml): fix for sql parsing error (datahub-project#11079) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * feat(docs-site) cloud page spacing and content polishes (datahub-project#11141) * feat(ui) Enable editing structured props on fields (datahub-project#11042) * feat(tests): add md5 and last computed to testResult model (datahub-project#11117) * test(openapi): openapi regression smoke tests (datahub-project#11143) * fix(airflow): fix tox tests + update docs (datahub-project#11125) * docs: add chime to adoption stories (datahub-project#11142) * fix(ingest/databricks): Updating code to work with Databricks sdk 0.30 (datahub-project#11158) * fix(kafka-setup): add missing script to image (datahub-project#11190) * fix(config): fix hash algo config (datahub-project#11191) * test(smoke-test): updates to smoke-tests (datahub-project#11152) * fix(elasticsearch): refactor idHashAlgo setting (datahub-project#11193) * chore(kafka): kafka version bump (datahub-project#11211) * readd UsageStatsWorkUnit * fix merge problems * change logo --------- Co-authored-by: Chris Collins <chriscollins3456@gmail.com> Co-authored-by: John Joyce <john@acryl.io> Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> Co-authored-by: dushayntAW <158567391+dushayntAW@users.noreply.github.com> Co-authored-by: sagar-salvi-apptware <159135491+sagar-salvi-apptware@users.noreply.github.com> Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> Co-authored-by: Kevin Chun <kevin1chun@gmail.com> Co-authored-by: jordanjeremy <72943478+jordanjeremy@users.noreply.github.com> Co-authored-by: skrydal <piotr.skrydalewicz@gmail.com> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> Co-authored-by: sid-acryl <155424659+sid-acryl@users.noreply.github.com> Co-authored-by: Julien Jehannet <80408664+aviv-julienjehannet@users.noreply.github.com> Co-authored-by: Hendrik Richert <github@richert.li> Co-authored-by: Hendrik Richert <hendrik.richert@swisscom.com> Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com> Co-authored-by: Felix Lüdin <13187726+Masterchen09@users.noreply.github.com> Co-authored-by: Pirry <158024088+chardaway@users.noreply.github.com> Co-authored-by: Hyejin Yoon <0327jane@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: cburroughs <chris.burroughs@gmail.com> Co-authored-by: ksrinath <ksrinath@users.noreply.github.com> Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com> Co-authored-by: Kunal-kankriya <127090035+Kunal-kankriya@users.noreply.github.com> Co-authored-by: Shirshanka Das <shirshanka@apache.org> Co-authored-by: ipolding-cais <155455744+ipolding-cais@users.noreply.github.com> Co-authored-by: Tamas Nemeth <treff7es@gmail.com> Co-authored-by: Shubham Jagtap <132359390+shubhamjagtap639@users.noreply.github.com> Co-authored-by: haeniya <yanik.haeni@gmail.com> Co-authored-by: Yanik Häni <Yanik.Haeni1@swisscom.com> Co-authored-by: Gabe Lyons <itsgabelyons@gmail.com> Co-authored-by: Gabe Lyons <gabe.lyons@acryl.io> Co-authored-by: 808OVADOZE <52988741+shtephlee@users.noreply.github.com> Co-authored-by: noggi <anton.kuraev@acryl.io> Co-authored-by: Nicholas Pena <npena@foursquare.com> Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com> Co-authored-by: ethan-cartwright <ethan.cartwright.m@gmail.com> Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io> Co-authored-by: Nadav Gross <33874964+nadavgross@users.noreply.github.com> Co-authored-by: Patrick Franco Braz <patrickfbraz@poli.ufrj.br> Co-authored-by: pie1nthesky <39328908+pie1nthesky@users.noreply.github.com> Co-authored-by: Joel Pinto Mata (KPN-DSH-DEX team) <130968841+joelmataKPN@users.noreply.github.com> Co-authored-by: Ellie O'Neil <110510035+eboneil@users.noreply.github.com> Co-authored-by: Ajoy Majumdar <ajoymajumdar@hotmail.com> Co-authored-by: deepgarg-visa <149145061+deepgarg-visa@users.noreply.github.com> Co-authored-by: Tristan Heisler <tristankheisler@gmail.com> Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io> Co-authored-by: Davi Arnaut <davi.arnaut@acryl.io> Co-authored-by: Pedro Silva <pedro@acryl.io> Co-authored-by: amit-apptware <132869468+amit-apptware@users.noreply.github.com> Co-authored-by: Sam Black <sam.black@acryl.io> Co-authored-by: Raj Tekal <varadaraj_tekal@optum.com> Co-authored-by: Steffen Grohsschmiedt <gitbhub@steffeng.eu> Co-authored-by: jaegwon.seo <162448493+wornjs@users.noreply.github.com> Co-authored-by: Renan F. Lima <51028757+lima-renan@users.noreply.github.com> Co-authored-by: Matt Exchange <xkollar@users.noreply.github.com> Co-authored-by: Jonny Dixon <45681293+acrylJonny@users.noreply.github.com> Co-authored-by: Pedro Silva <pedro.cls93@gmail.com> Co-authored-by: Pinaki Bhattacharjee <pinakipb2@gmail.com> Co-authored-by: Jeff Merrick <jeff@wireform.io> Co-authored-by: skrydal <piotr.skrydalewicz@acryl.io> Co-authored-by: AndreasHegerNuritas <163423418+AndreasHegerNuritas@users.noreply.github.com> Co-authored-by: jayasimhankv <145704974+jayasimhankv@users.noreply.github.com> Co-authored-by: Jay Kadambi <jayasimhan_venkatadri@optum.com> Co-authored-by: David Leifker <david.leifker@acryl.io>
EDIT
--details/--no-detailswith details to be true so screenshot args are out of date but output format is still valid.Format changed from
to
which shows a lot more auditing information. This is useful to debug issues in an easier manner.
Checklist
Summary by CodeRabbit
New Features
--details/--no-detailsflag to thegetCLI command, allowing users to toggle detailed output.Documentation
Enhancements
get_aspects_for_entityfunction to support detailed processing based on the newdetailsparameter.