Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ingest/bigquery): Correctly apply table pattern to read events; fix end time calculation; deprecate match_fully_qualified_names #9077

Merged
merged 1 commit into from
Oct 24, 2023
Merged

fix(ingest/bigquery): Correctly apply table pattern to read events; fix end time calculation; deprecate match_fully_qualified_names #9077

merged 1 commit into from
Oct 24, 2023

Conversation

asikowitz
Copy link
Collaborator

Would like a review from both @mayurinehate and @treff7es. Mayuri for the end time change, Tamas for the filter change.

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

@github-actions github-actions bot added the ingestion PR or Issue related to the ingestion of metadata label Oct 23, 2023
treff7es
treff7es approved these changes Oct 24, 2023
View reviewed changes
metadata-ingestion/src/datahub/ingestion/source/bigquery_v2/bigquery_config.py
@@ -119,8 +119,8 @@ class BigQueryV2Config(
)

match_fully_qualified_names: bool = Field(
default=False,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this break all existing bigquery ingestion where it was not set earlier?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've had a deprecation warning since I started... gotta follow up at some point. I'll add a doc change in a follow up though

@asikowitz asikowitz merged commit eb0b03d into datahub-project:master Oct 24, 2023
53 of 55 checks passed
@asikowitz asikowitz deleted the fix-bigquery-usage-table-pattern branch October 24, 2023 14:45
@maggiehays maggiehays added the hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ label Oct 26, 2023
@coderabbitai coderabbitai bot mentioned this pull request Jul 1, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@treff7es treff7es treff7es approved these changes

@mayurinehate mayurinehate Awaiting requested review from mayurinehate

Assignees
No one assigned
Labels
hacktoberfest-accepted Acceptance for hacktoberfest https://hacktoberfest.com/participation/ ingestion PR or Issue related to the ingestion of metadata
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asikowitz @treff7es @maggiehays