fix: resolve incorrect variable assignment for SageMaker API call

[TristanHeisler]

This pull request fixes the incorrect variable assignment during SageMaker model ingestion identified and described in #10893

Checklist

• The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
• Links to related issues (if applicable)
• Tests for the changes have been added/updated (if applicable)
• Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
• For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

• Refactor
  • Improved variable naming in the model ingestion process for clarity without changing functionality.

[coderabbitai]

Walkthrough

The recent updates in the SageMaker processors' models file primarily involve renaming a variable for improved clarity. The variable model_uri_groups was changed to model_image_groups within the get_model_wu function. This adjustment enhances code readability without altering its functionality or logic.

Changes

Files	Change Summary
metadata-ingestion/src/datahub/ingestion/.../models.py	Renamed variable model_uri_groups to model_image_groups in get_model_wu function for clarity.

Possibly related issues

• Sagemaker API call model_image_to_groups result assigned to wrong variable #10893: The issue describes a bug where the result of model_image_to_groups is assigned to the wrong variable model_uri_groups, leading to incorrect population of model_image_groups. The recent changes address this confusion by renaming model_uri_groups, which may clarify the intended usage and resolution of the bug.

Poem

🐇 In the land of code where rabbits play,
A variable danced in a clearer way.
From uri to image, a name so bright,
Enhancing our scripts, bringing pure delight!
With hops and jumps, the code’s now so neat,
Let’s celebrate changes, oh what a treat! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 8b88930 and 578a250.

Files selected for processing (1)

• metadata-ingestion/src/datahub/ingestion/source/aws/sagemaker_processors/models.py (1 hunks)

Files skipped from review due to trivial changes (1)

• metadata-ingestion/src/datahub/ingestion/source/aws/sagemaker_processors/models.py

[treff7es]

Thanks for the fix! 🙇