feat(propagation): Add models for Action feature settings #11029
Conversation
github-actions
bot
added
product
WalkthroughThis update enhances the GraphQL API by introducing new resolvers for managing document propagation settings and improving authorization capabilities for feature management. New data structures encapsulate global settings, and policies are expanded to include crucial privileges. Overall, these changes significantly enhance the API's functionality and granularity, enabling users to manage features and settings more effectively. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GraphQL_Engine
participant SettingsService
participant AuthorizationUtils
User->>GraphQL_Engine: Query for docPropagationSettings
GraphQL_Engine->>AuthorizationUtils: Check permissions
AuthorizationUtils-->>GraphQL_Engine: Permissions granted
GraphQL_Engine->>SettingsService: Fetch docPropagationSettings
SettingsService-->>GraphQL_Engine: Return settings
GraphQL_Engine-->>User: Respond with settings
sequenceDiagram
participant User
participant GraphQL_Engine
participant SettingsService
participant AuthorizationUtils
User->>GraphQL_Engine: Mutation to updateDocPropagationSettings
GraphQL_Engine->>AuthorizationUtils: Check permissions
AuthorizationUtils-->>GraphQL_Engine: Permissions granted
GraphQL_Engine->>SettingsService: Update docPropagationSettings
SettingsService-->>GraphQL_Engine: Confirmation of update
GraphQL_Engine-->>User: Acknowledge update
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (16)
- datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java (3 hunks)
- datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/authorization/AuthorizationUtils.java (1 hunks)
- datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/settings/docPropagation/DocPropagationSettingsResolver.java (1 hunks)
- datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/settings/docPropagation/UpdateDocPropagationSettingsResolver.java (1 hunks)
- datahub-graphql-core/src/main/resources/app.graphql (3 hunks)
- metadata-models/src/main/pegasus/com/linkedin/settings/global/ActionSettings.pdl (1 hunks)
- metadata-models/src/main/pegasus/com/linkedin/settings/global/DocPropagationFeatureSettings.pdl (1 hunks)
- metadata-models/src/main/pegasus/com/linkedin/settings/global/FeatureSettings.pdl (1 hunks)
- metadata-models/src/main/pegasus/com/linkedin/settings/global/GlobalSettingsInfo.pdl (1 hunks)
- metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json (7 hunks)
- metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json (7 hunks)
- metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json (7 hunks)
- metadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.json (7 hunks)
- metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json (7 hunks)
- metadata-service/war/src/main/resources/boot/policies.json (10 hunks)
- metadata-utils/src/main/java/com/linkedin/metadata/authorization/PoliciesConfig.java (2 hunks)
Additional comments not posted (59)
metadata-models/src/main/pegasus/com/linkedin/settings/global/DocPropagationFeatureSettings.pdl (3)
1-1: Namespace declaration is correct.The namespace aligns with the project's structure.
4-4: Record definition is correct.The record
DocPropagationFeatureSettingsappropriately includesFeatureSettings.
6-6: Field definition is correct.The field
columnPropagationEnabledis defined with a default value oftrue.metadata-models/src/main/pegasus/com/linkedin/settings/global/ActionSettings.pdl (3)
1-1: Namespace declaration is correct.The namespace aligns with the project's structure.
6-6: Record definition is correct.The record
ActionSettingsis appropriately documented.
10-10: Field definition is correct.The field
docColumnPropagationis appropriately documented.metadata-models/src/main/pegasus/com/linkedin/settings/global/FeatureSettings.pdl (3)
1-1: Namespace declaration is correct.The namespace aligns with the project's structure.
7-7: Record definition is correct.The record
FeatureSettingsis appropriately documented.
9-21: Field definitions are correct.The fields
enabled,config, andconfigVersionare appropriately documented.metadata-models/src/main/pegasus/com/linkedin/settings/global/GlobalSettingsInfo.pdl (1)
19-25: LGTM!The addition of the
docPropagationfield with default values enhances the configuration capabilities of theGlobalSettingsInforecord.datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/settings/docPropagation/DocPropagationSettingsResolver.java (4)
1-13: LGTM!The imports are appropriate and necessary for the functionality of the resolver.
15-24: LGTM!The class definition and constructor are correct and ensure that
settingsServiceis not null.
26-46: LGTM!The
getmethod correctly handles fetching and mapping the settings, and includes appropriate error handling.
48-56: LGTM!The
mapDocPropagationSettingsmethod correctly maps thecolumnPropagationEnabledfield.datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/settings/docPropagation/UpdateDocPropagationSettingsResolver.java (4)
1-17: LGTM!The imports are appropriate and necessary for the functionality of the resolver.
19-27: LGTM!The class definition and constructor are correct and ensure that
settingsServiceis not null.
29-71: LGTM!The
getmethod correctly handles updating settings, includes appropriate error handling and authorization checks.
73-77: LGTM!The
updateDocPropagationSettingsmethod correctly updates thecolumnPropagationEnabledfield based on the input.datahub-graphql-core/src/main/resources/app.graphql (6)
38-47: LGTM! Ensure the new mutations are used correctly in the codebase.The new mutations
updateDocPropagationSettingsandupdateActionSettingsare well-defined and their descriptions are clear.However, verify that these mutations are correctly used in the codebase.
549-557: LGTM! Ensure the new input type is used correctly in the codebase.The new input type
UpdateActionSettingsInputis well-defined and its description is clear.However, verify that this input type is correctly used in the codebase.
Verification successful
The new input type
UpdateActionSettingsInputis correctly used in the codebase.
- It is utilized in the
updateActionSettingsmutation withindatahub-graphql-core/src/main/resources/app.graphql.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new input type in the codebase. # Test: Search for the usage of the new input type. Expect: Only occurrences of the new input type. rg --type graphql -A 5 $'UpdateActionSettingsInput'Length of output: 82
Script:
#!/bin/bash # Description: Verify the usage of new input type in the codebase. # Test: Search for the usage of the new input type. Expect: Only occurrences of the new input type. rg -A 5 'UpdateActionSettingsInput'Length of output: 931
559-567: LGTM! Ensure the new type is used correctly in the codebase.The new type
ActionSettingsis well-defined and its description is clear.However, verify that this type is correctly used in the codebase.
Verification successful
The new type
ActionSettingsis correctly used in the codebase.The
ActionSettingstype is integrated into the GraphQL schema and appears in relevant contexts such asactionSettings,updateActionSettings, andUpdateActionSettingsInput.
datahub-graphql-core/src/main/resources/app.graphqlScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new type in the codebase. # Test: Search for the usage of the new type. Expect: Only occurrences of the new type. rg --type graphql -A 5 $'ActionSettings'Length of output: 71
Script:
#!/bin/bash # Description: Verify the usage of new type in the codebase. # Test: Search for the usage of the new type in .graphql files. rg 'ActionSettings' --glob '*.graphql' -A 5Length of output: 1816
20-25: LGTM! Ensure the new fields are used correctly in the codebase.The new fields
docPropagationSettingsandactionSettingsare well-defined and their descriptions are clear.However, verify that these fields are correctly used in the codebase.
579-587: LGTM! Ensure the new type is used correctly in the codebase.The new type
DocPropagationSettingsis well-defined and its description is clear.However, verify that this type is correctly used in the codebase.
Verification successful
Let's re-run the search without specifying the file type to locate the usage of
DocPropagationSettingsin the codebase.
The new type
DocPropagationSettingsis correctly used in the codebase.The type is referenced in the GraphQL schema and utilized in Java resolvers, ensuring its proper integration.
GraphQL Schema:
docPropagationSettings: DocPropagationSettingsupdateDocPropagationSettings(input: UpdateDocPropagationSettingsInput!): Boolean!input UpdateDocPropagationSettingsInputJava Resolvers:
DocPropagationSettingsResolverUpdateDocPropagationSettingsResolverScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new type in the codebase. # Test: Search for the usage of the new type. Expect: Only occurrences of the new type. rg --type graphql -A 5 $'DocPropagationSettings'Length of output: 79
Script:
#!/bin/bash # Description: Verify the usage of new type in the codebase. # Test: Search for the usage of the new type. Expect: Only occurrences of the new type. rg -A 5 'DocPropagationSettings'Length of output: 19908
569-577: LGTM! Ensure the new input type is used correctly in the codebase.The new input type
UpdateDocPropagationSettingsInputis well-defined and its description is clear.However, verify that this input type is correctly used in the codebase.
Verification successful
The new input type
UpdateDocPropagationSettingsInputis correctly used in the codebase.
- Defined in
datahub-graphql-core/src/main/resources/app.graphql- Utilized in
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/settings/docPropagation/UpdateDocPropagationSettingsResolver.javaScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new input type in the codebase. # Test: Search for the usage of the new input type. Expect: Only occurrences of the new input type. rg --type graphql -A 5 $'UpdateDocPropagationSettingsInput'Length of output: 90
Script:
#!/bin/bash # Description: Verify the usage of new input type in the codebase. # Test: Search for the usage of the new input type across all files. rg -A 5 'UpdateDocPropagationSettingsInput'Length of output: 4216
metadata-service/war/src/main/resources/boot/policies.json (4)
Line range hint
5-40:
LGTM! Ensure the new privilege is used correctly in the codebase.The addition of the
MANAGE_FEATURESprivilege to theprivilegeslist of policyurn:li:dataHubPolicy:0is consistent with the policy's purpose.However, verify that this privilege is correctly used in the codebase.
Verification successful
The
MANAGE_FEATURESprivilege is correctly integrated and used in the codebase.
- It is defined in
metadata-utils/src/main/java/com/linkedin/metadata/authorization/PoliciesConfig.java.- It is referenced in
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/authorization/AuthorizationUtils.java.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new privilege in the codebase. # Test: Search for the usage of the new privilege. Expect: Only occurrences of the new privilege. rg --type json -A 5 $'"MANAGE_FEATURES"'Length of output: 1729
Script:
#!/bin/bash # Description: Verify the usage of the new privilege in the entire codebase. # Test: Search for the usage of the new privilege. Expect: Occurrences of the new privilege in various files. rg 'MANAGE_FEATURES'Length of output: 924
258-277: LGTM! Ensure the new privilege is used correctly in the codebase.The addition of the
MANAGE_FEATURESprivilege to theprivilegeslist of policyurn:li:dataHubPolicy:editor-platform-policyis consistent with the policy's purpose.However, verify that this privilege is correctly used in the codebase.
Verification successful
The
MANAGE_FEATURESprivilege has been added to multiple policies. To ensure it's used correctly, we need to verify references to these policies in the codebase.
No issues found with the addition of the
MANAGE_FEATURESprivilege.The policies containing the
MANAGE_FEATURESprivilege are only referenced within thepolicies.jsonfile itself, indicating no direct usage issues in the codebase.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new privilege in the codebase. # Test: Search for the usage of the new privilege. Expect: Only occurrences of the new privilege. rg --type json -A 5 $'"MANAGE_FEATURES"'Length of output: 1729
Script:
#!/bin/bash # Description: Verify references to the policies that include the "MANAGE_FEATURES" privilege in the codebase. # Test: Search for references to the policies in the codebase. rg -i 'Root User - All Platform Privileges|Admins - Platform Policy|Editors - Platform Policy'Length of output: 432
Line range hint
52-76:
LGTM! Ensure the new privilege is used correctly in the codebase.The addition of the
MANAGE_FEATURESprivilege to theprivilegeslist of policyurn:li:dataHubPolicy:1is consistent with the policy's purpose.However, verify that this privilege is correctly used in the codebase.
Verification successful
Let's verify the usage of the
MANAGE_FEATURESprivilege in the codebase beyond the JSON configuration files to ensure it is correctly referenced and utilized.
Verification Successful: The
MANAGE_FEATURESprivilege is correctly defined and utilized in the codebase.
metadata-utils/src/main/java/com/linkedin/metadata/authorization/PoliciesConfig.java: The privilege is defined and described.datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/authorization/AuthorizationUtils.java: The privilege is referenced for authorization checks.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new privilege in the codebase. # Test: Search for the usage of the new privilege. Expect: Only occurrences of the new privilege. rg --type json -A 5 $'"MANAGE_FEATURES"'Length of output: 1729
Script:
#!/bin/bash # Description: Verify the usage of the new privilege in the codebase beyond JSON configuration files. # Test: Search for the usage of the new privilege in the codebase. Expect: Occurrences of the new privilege in the code logic. rg 'MANAGE_FEATURES'Length of output: 924
Line range hint
151-188:
LGTM! Ensure the new privilege is used correctly in the codebase.The addition of the
MANAGE_FEATURESprivilege to theprivilegeslist of policyurn:li:dataHubPolicy:admin-platform-policyis consistent with the policy's purpose.However, verify that this privilege is correctly used in the codebase.
Verification successful
The
MANAGE_FEATURESprivilege is correctly integrated into the application's authorization logic.
- The privilege is defined in
PoliciesConfig.java.- It is referenced in
AuthorizationUtils.javafor authorization checks.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new privilege in the codebase. # Test: Search for the usage of the new privilege. Expect: Only occurrences of the new privilege. rg --type json -A 5 $'"MANAGE_FEATURES"'Length of output: 1729
Script:
#!/bin/bash # Description: Verify the usage of new privilege in the codebase beyond JSON files. # Test: Search for the usage of the new privilege in the entire codebase. Expect: Occurrences of the new privilege in application logic. rg --type-add 'code:*.{js,ts,java,py,rb,go,php,cs,cpp}' '"MANAGE_FEATURES"'Length of output: 512
Script:
#!/bin/bash # Description: Verify the usage of new privilege in the Java codebase. # Test: Search for conditional logic or privilege checks involving the new privilege. rg --type java 'MANAGE_FEATURES'Length of output: 681
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/authorization/AuthorizationUtils.java (1)
401-404: LGTM! Ensure the new method is used correctly in the codebase.The new method
canManageFeaturesis well-defined and its functionality is clear.However, verify that this method is correctly used in the codebase.
Verification successful
The
canManageFeaturesmethod is correctly used in the codebase.The method is utilized in the
UpdateDocPropagationSettingsResolverclass to check authorization before managing feature settings, which is appropriate and aligns with its intended functionality.
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/settings/docPropagation/UpdateDocPropagationSettingsResolver.javaScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new method in the codebase. # Test: Search for the usage of the new method. Expect: Only occurrences of the new method. rg --type java -A 5 $'canManageFeatures'Length of output: 2052
Script:
#!/bin/bash # Description: Verify the usage context of the `canManageFeatures` method in the UpdateDocPropagationSettingsResolver.java file. # Fetch the surrounding lines of the usage of `canManageFeatures` to understand its context. rg --type java -A 10 -B 10 $'AuthorizationUtils.canManageFeatures' datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/settings/docPropagation/UpdateDocPropagationSettingsResolver.javaLength of output: 1196
metadata-utils/src/main/java/com/linkedin/metadata/authorization/PoliciesConfig.java (2)
166-169: LGTM! Addition ofMANAGE_FEATURES_PRIVILEGEis correct.The new privilege is defined correctly and follows the existing pattern.
196-197: LGTM! Update toPLATFORM_PRIVILEGESis correct.The new privilege is included in the platform privileges list, ensuring it is recognized by the system.
metadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.json (5)
642-686: Addition ofattributionfield inTagAssociation.The
attributionfield is a valuable addition, providing metadata attribution details. Ensure that theSearchableproperties are correctly implemented and tested.
795-813: Addition ofattributionfield inGlossaryTermAssociation.The
attributionfield is a valuable addition, providing metadata attribution details. Ensure that theSearchableproperties are correctly implemented and tested.
2849-2860: Addition ofattributionfield inSchemaField.The
attributionfield is a valuable addition, providing metadata attribution details. Ensure that theSearchableproperties are correctly implemented and tested.
3060-3071: Addition ofattributionfield inEditableSchemaFieldInfo.The
attributionfield is a valuable addition, providing metadata attribution details. Ensure that theSearchableproperties are correctly implemented and tested.
2879-2890: Addition ofattributionfield inGlossaryTerms.The
attributionfield is a valuable addition, providing metadata attribution details. Ensure that theSearchableproperties are correctly implemented and tested.metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json (6)
642-686: LGTM! Ensure consistent usage of theattributionfield.The addition of the
attributionfield in theTagAssociationrecord is well-structured and includes necessary searchable fields.However, verify that the
attributionfield is consistently used across all relevant records.Verification successful
Verification successful!
The
attributionfield is consistently used across various records, including the necessary searchable fields and attributes.
metadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent usage of the `attribution` field across all relevant records. # Test: Search for the `attribution` field usage. Expect: Consistent usage across all relevant records. rg --type json -A 5 $'"attribution"'Length of output: 7790
795-813: LGTM! Ensure consistent usage of theattributionfield.The addition of the
attributionfield in theGlossaryTermAssociationrecord is well-structured and includes necessary searchable fields.However, verify that the
attributionfield is consistently used across all relevant records.Verification successful
Consistent usage of the
attributionfield verified.The
attributionfield is consistently used across multiple records in the JSON files, maintaining the same structure and searchable attributes.
metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent usage of the `attribution` field across all relevant records. # Test: Search for the `attribution` field usage. Expect: Consistent usage across all relevant records. rg --type json -A 5 $'"attribution"'Length of output: 7790
2885-2896: LGTM! Ensure consistent usage of theattributionfield.The addition of the
attributionfield in theSchemaFieldrecord forGlossaryTermsis well-structured and includes necessary searchable fields.However, verify that the
attributionfield is consistently used across all relevant records.Verification successful
Consistent usage of the
attributionfield confirmed.The
attributionfield is consistently used across multiple records, defined asMetadataAttributionwith the necessary searchable fields.
metadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent usage of the `attribution` field across all relevant records. # Test: Search for the `attribution` field usage. Expect: Consistent usage across all relevant records. rg --type json -A 5 $'"attribution"'Length of output: 7790
3066-3077: LGTM! Ensure consistent usage of theattributionfield.The addition of the
attributionfield in theEditableSchemaFieldInforecord forGlobalTagsis well-structured and includes necessary searchable fields.However, verify that the
attributionfield is consistently used across all relevant records.Verification successful
Consistent usage of the
attributionfield verified.The
attributionfield is consistently used across multiple records with the same structure and searchable fields, ensuring uniform implementation.
metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent usage of the `attribution` field across all relevant records. # Test: Search for the `attribution` field usage. Expect: Consistent usage across all relevant records. rg --type json -A 5 $'"attribution"'Length of output: 7790
2855-2866: LGTM! Ensure consistent usage of theattributionfield.The addition of the
attributionfield in theSchemaFieldrecord forGlobalTagsis well-structured and includes necessary searchable fields.However, verify that the
attributionfield is consistently used across all relevant records.Verification successful
Verified: Consistent usage of the
attributionfield.The
attributionfield is consistently used across multiple relevant records, ensuring uniformity and correctness in its application.
metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.jsonmetadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.jsonScripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent usage of the `attribution` field across all relevant records. # Test: Search for the `attribution` field usage. Expect: Consistent usage across all relevant records. rg --type json -A 5 $'"attribution"'Length of output: 7790
3096-3107: LGTM! Ensure consistent usage of theattributionfield.The addition of the
attributionfield in theEditableSchemaFieldInforecord forGlossaryTermsis well-structured and includes necessary searchable fields.However, verify that the
attributionfield is consistently used across all relevant records.Verification successful
The
attributionfield is consistently used across all relevant records.The addition of the
attributionfield in theEditableSchemaFieldInforecord forGlossaryTermsis well-structured and consistently applied across multiple JSON files.
- metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json
- metadata-service/restli-api/src/main/snapshot/com.linkedin.operations.operations.snapshot.json
- metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json
- metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json
- metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.runs.snapshot.json
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistent usage of the `attribution` field across all relevant records. # Test: Search for the `attribution` field usage. Expect: Consistent usage across all relevant records. rg --type json -A 5 $'"attribution"'Length of output: 7790
datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/GmsGraphQLEngine.java (2)
1093-1095: Verify the correctness of the new resolver addition.The
DocPropagationSettingsResolveris correctly instantiated and registered as a data fetcher for thedocPropagationSettingsquery. Ensure that the resolver is implemented correctly and handles the necessary logic.
1349-1350: Verify the correctness of the new resolver addition.The
UpdateDocPropagationSettingsResolveris correctly instantiated and registered as a data fetcher for theupdateDocPropagationSettingsmutation. Ensure that the resolver is implemented correctly and handles the necessary logic.metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.aspects.snapshot.json (8)
905-935: Ensure the correctness of theattributionfield definition.The
attributionfield is correctly defined as a record with fields fortime,actor,source, andsourceDetail. This addition enhances metadata traceability.
936-949: Verify searchable paths forattribution.The searchable paths for
attributionfields (actor,source,time) are correctly defined. Ensure that these paths are integrated into the search functionality.
1059-1062: Ensure the correctness of theattributionfield definition.The
attributionfield is correctly defined as aMetadataAttributionrecord. This addition enhances metadata traceability.
1063-1076: Verify searchable paths forattribution.The searchable paths for
attributionfields (actor,source,time) are correctly defined. Ensure that these paths are integrated into the search functionality.
3127-3138: Ensure the correctness of theattributionfield definition inGlobalTags.The
attributionfield is correctly defined and integrated within theGlobalTagsfield of theSchemaFieldrecord. This addition enhances metadata traceability.
3157-3168: Ensure the correctness of theattributionfield definition inGlossaryTerms.The
attributionfield is correctly defined and integrated within theGlossaryTermsfield of theSchemaFieldrecord. This addition enhances metadata traceability.
3338-3349: Ensure the correctness of theattributionfield definition inEditableSchemaFieldInfo(GlobalTags).The
attributionfield is correctly defined and integrated within theGlobalTagsfield of theEditableSchemaFieldInforecord. This addition enhances metadata traceability.
3368-3379: Ensure the correctness of theattributionfield definition inEditableSchemaFieldInfo(GlossaryTerms).The
attributionfield is correctly defined and integrated within theGlossaryTermsfield of theEditableSchemaFieldInforecord. This addition enhances metadata traceability.metadata-service/restli-api/src/main/snapshot/com.linkedin.platform.platform.snapshot.json (2)
900-944: LGTM! Addition ofattributionfield enhances metadata tracking.The
attributionfield provides detailed information about metadata application, including time, actor, source, and source details. This addition improves the traceability and auditing of metadata changes.
1053-1071: LGTM! Addition ofattributionfield enhances metadata tracking.The
attributionfield provides detailed information about metadata application, including time, actor, source, and source details. This addition improves the traceability and auditing of metadata changes.metadata-service/restli-api/src/main/snapshot/com.linkedin.entity.entities.snapshot.json (5)
900-944: Addition ofattributionfield toTagAssociationis well-structured.The
attributionfield enhances traceability and accountability. Each sub-field is well-documented.
1053-1071: Addition ofattributionfield toGlossaryTermAssociationis well-structured.The
attributionfield enhances traceability and accountability. Each sub-field is well-documented.
3510-3521: Addition ofattributionfield toSchemaFieldis well-structured.The
attributionfield enhances traceability and accountability. Each sub-field is well-documented.
3721-3732: Addition ofattributionfield toEditableSchemaFieldInfois well-structured.The
attributionfield enhances traceability and accountability. Each sub-field is well-documented.
3751-3762: Addition ofattributionfield toEditableSchemaMetadatais well-structured.The
attributionfield enhances traceability and accountability. Each sub-field is well-documented.
metadata-models/src/main/pegasus/com/linkedin/settings/global/ActionSettings.pdl
Outdated
Show resolved
Hide resolved
|
@shirshanka Resolved. |
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- datahub-graphql-core/src/main/resources/app.graphql (3 hunks)
Additional comments not posted (4)
datahub-graphql-core/src/main/resources/app.graphql (4)
21-24: Addition ofdocPropagationSettingsfield inQuerytype looks good.The
docPropagationSettingsfield has been correctly added to theQuerytype to fetch global settings related to document propagation.
34-37: Addition ofupdateDocPropagationSettingsfield inMutationtype looks good.The
updateDocPropagationSettingsfield has been correctly added to theMutationtype to allow updates to the document propagation settings.
542-547: Addition ofUpdateDocPropagationSettingsInputinput type looks good.The
UpdateDocPropagationSettingsInputinput type has been correctly added to specify the parameters for updating document propagation settings.
552-557: Addition ofDocPropagationSettingstype looks good.The
DocPropagationSettingstype has been correctly added to encapsulate the global settings related to document propagation.
shirshanka
added
the
merge-pending-ci
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/settings/docPropagation/UpdateDocPropagationSettingsResolver.java (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- datahub-graphql-core/src/main/java/com/linkedin/datahub/graphql/resolvers/settings/docPropagation/UpdateDocPropagationSettingsResolver.java
* feat(forms) Handle deleting forms references when hard deleting forms (datahub-project#10820) * refactor(ui): Misc improvements to the setup ingestion flow (ingest uplift 1/2) (datahub-project#10764) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * fix(ingestion/airflow-plugin): pipeline tasks discoverable in search (datahub-project#10819) * feat(ingest/transformer): tags to terms transformer (datahub-project#10758) Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> * fix(ingestion/unity-catalog): fixed issue with profiling with GE turned on (datahub-project#10752) Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> * feat(forms) Add java SDK for form entity PATCH + CRUD examples (datahub-project#10822) * feat(SDK) Add java SDK for structuredProperty entity PATCH + CRUD examples (datahub-project#10823) * feat(SDK) Add StructuredPropertyPatchBuilder in python sdk and provide sample CRUD files (datahub-project#10824) * feat(forms) Add CRUD endpoints to GraphQL for Form entities (datahub-project#10825) * add flag for includeSoftDeleted in scroll entities API (datahub-project#10831) * feat(deprecation) Return actor entity with deprecation aspect (datahub-project#10832) * feat(structuredProperties) Add CRUD graphql APIs for structured property entities (datahub-project#10826) * add scroll parameters to openapi v3 spec (datahub-project#10833) * fix(ingest): correct profile_day_of_week implementation (datahub-project#10818) * feat(ingest/glue): allow ingestion of empty databases from Glue (datahub-project#10666) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * feat(cli): add more details to get cli (datahub-project#10815) * fix(ingestion/glue): ensure date formatting works on all platforms for aws glue (datahub-project#10836) * fix(ingestion): fix datajob patcher (datahub-project#10827) * fix(smoke-test): add suffix in temp file creation (datahub-project#10841) * feat(ingest/glue): add helper method to permit user or group ownership (datahub-project#10784) * feat(): Show data platform instances in policy modal if they are set on the policy (datahub-project#10645) Co-authored-by: Hendrik Richert <hendrik.richert@swisscom.com> * docs(patch): add patch documentation for how implementation works (datahub-project#10010) Co-authored-by: John Joyce <john@acryl.io> * fix(jar): add missing custom-plugin-jar task (datahub-project#10847) * fix(): also check exceptions/stack trace when filtering log messages (datahub-project#10391) Co-authored-by: John Joyce <john@acryl.io> * docs(): Update posts.md (datahub-project#9893) Co-authored-by: Hyejin Yoon <0327jane@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * chore(ingest): update acryl-datahub-classify version (datahub-project#10844) * refactor(ingest): Refactor structured logging to support infos, warnings, and failures structured reporting to UI (datahub-project#10828) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(restli): log aspect-not-found as a warning rather than as an error (datahub-project#10834) * fix(ingest/nifi): remove duplicate upstream jobs (datahub-project#10849) * fix(smoke-test): test access to create/revoke personal access tokens (datahub-project#10848) * fix(smoke-test): missing test for move domain (datahub-project#10837) * ci: update usernames to not considered for community (datahub-project#10851) * env: change defaults for data contract visibility (datahub-project#10854) * fix(ingest/tableau): quote special characters in external URL (datahub-project#10842) * fix(smoke-test): fix flakiness of auto complete test * ci(ingest): pin dask dependency for feast (datahub-project#10865) * fix(ingestion/lookml): liquid template resolution and view-to-view cll (datahub-project#10542) * feat(ingest/audit): add client id and version in system metadata props (datahub-project#10829) * chore(ingest): Mypy 1.10.1 pin (datahub-project#10867) * docs: use acryl-datahub-actions as expected python package to install (datahub-project#10852) * docs: add new js snippet (datahub-project#10846) * refactor(ingestion): remove company domain for security reason (datahub-project#10839) * fix(ingestion/spark): Platform instance and column level lineage fix (datahub-project#10843) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(ingestion/tableau): optionally ingest multiple sites and create site containers (datahub-project#10498) Co-authored-by: Yanik Häni <Yanik.Haeni1@swisscom.com> * fix(ingestion/looker): Add sqlglot dependency and remove unused sqlparser (datahub-project#10874) * fix(manage-tokens): fix manage access token policy (datahub-project#10853) * Batch get entity endpoints (datahub-project#10880) * feat(system): support conditional write semantics (datahub-project#10868) * fix(build): upgrade vercel builds to Node 20.x (datahub-project#10890) * feat(ingest/lookml): shallow clone repos (datahub-project#10888) * fix(ingest/looker): add missing dependency (datahub-project#10876) * fix(ingest): only populate audit stamps where accurate (datahub-project#10604) * fix(ingest/dbt): always encode tag urns (datahub-project#10799) * fix(ingest/redshift): handle multiline alter table commands (datahub-project#10727) * fix(ingestion/looker): column name missing in explore (datahub-project#10892) * fix(lineage) Fix lineage source/dest filtering with explored per hop limit (datahub-project#10879) * feat(conditional-writes): misc updates and fixes (datahub-project#10901) * feat(ci): update outdated action (datahub-project#10899) * feat(rest-emitter): adding async flag to rest emitter (datahub-project#10902) Co-authored-by: Gabe Lyons <gabe.lyons@acryl.io> * feat(ingest): add snowflake-queries source (datahub-project#10835) * fix(ingest): improve `auto_materialize_referenced_tags_terms` error handling (datahub-project#10906) * docs: add new company to adoption list (datahub-project#10909) * refactor(redshift): Improve redshift error handling with new structured reporting system (datahub-project#10870) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * feat(ui) Finalize support for all entity types on forms (datahub-project#10915) * Index ExecutionRequestResults status field (datahub-project#10811) * feat(ingest): grafana connector (datahub-project#10891) Co-authored-by: Shirshanka Das <shirshanka@apache.org> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(gms) Add Form entity type to EntityTypeMapper (datahub-project#10916) * feat(dataset): add support for external url in Dataset (datahub-project#10877) * docs(saas-overview) added missing features to observe section (datahub-project#10913) Co-authored-by: John Joyce <john@acryl.io> * fix(ingest/spark): Fixing Micrometer warning (datahub-project#10882) * fix(structured properties): allow application of structured properties without schema file (datahub-project#10918) * fix(data-contracts-web) handle other schedule types (datahub-project#10919) * fix(ingestion/tableau): human-readable message for PERMISSIONS_MODE_SWITCHED error (datahub-project#10866) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * Add feature flag for view defintions (datahub-project#10914) Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io> * feat(ingest/BigQuery): refactor+parallelize dataset metadata extraction (datahub-project#10884) * fix(airflow): add error handling around render_template() (datahub-project#10907) * feat(ingestion/sqlglot): add optional `default_dialect` parameter to sqlglot lineage (datahub-project#10830) * feat(mcp-mutator): new mcp mutator plugin (datahub-project#10904) * fix(ingest/bigquery): changes helper function to decode unicode scape sequences (datahub-project#10845) * feat(ingest/postgres): fetch table sizes for profile (datahub-project#10864) * feat(ingest/abs): Adding azure blob storage ingestion source (datahub-project#10813) * fix(ingest/redshift): reduce severity of SQL parsing issues (datahub-project#10924) * fix(build): fix lint fix web react (datahub-project#10896) * fix(ingest/bigquery): handle quota exceeded for project.list requests (datahub-project#10912) * feat(ingest): report extractor failures more loudly (datahub-project#10908) * feat(ingest/snowflake): integrate snowflake-queries into main source (datahub-project#10905) * fix(ingest): fix docs build (datahub-project#10926) * fix(ingest/snowflake): fix test connection (datahub-project#10927) * fix(ingest/lookml): add view load failures to cache (datahub-project#10923) * docs(slack) overhauled setup instructions and screenshots (datahub-project#10922) Co-authored-by: John Joyce <john@acryl.io> * fix(airflow): Add comma parsing of owners to DataJobs (datahub-project#10903) * fix(entityservice): fix merging sideeffects (datahub-project#10937) * feat(ingest): Support System Ingestion Sources, Show and hide system ingestion sources with Command-S (datahub-project#10938) Co-authored-by: John Joyce <john@Johns-MBP.lan> * chore() Set a default lineage filtering end time on backend when a start time is present (datahub-project#10925) Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> Co-authored-by: John Joyce <john@Johns-MBP.lan> * Added relationships APIs to V3. Added these generic APIs to V3 swagger doc. (datahub-project#10939) * docs: add learning center to docs (datahub-project#10921) * doc: Update hubspot form id (datahub-project#10943) * chore(airflow): add python 3.11 w/ Airflow 2.9 to CI (datahub-project#10941) * fix(ingest/Glue): column upstream lineage between S3 and Glue (datahub-project#10895) * fix(ingest/abs): split abs utils into multiple files (datahub-project#10945) * doc(ingest/looker): fix doc for sql parsing documentation (datahub-project#10883) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(ingest/bigquery): Adding missing BigQuery types (datahub-project#10950) * fix(ingest/setup): feast and abs source setup (datahub-project#10951) * fix(connections) Harden adding /gms to connections in backend (datahub-project#10942) * feat(siblings) Add flag to prevent combining siblings in the UI (datahub-project#10952) * fix(docs): make graphql doc gen more automated (datahub-project#10953) * feat(ingest/athena): Add option for Athena partitioned profiling (datahub-project#10723) * fix(spark-lineage): default timeout for future responses (datahub-project#10947) * feat(datajob/flow): add environment filter using info aspects (datahub-project#10814) * fix(ui/ingest): correct privilege used to show tab (datahub-project#10483) Co-authored-by: Kunal-kankriya <127090035+Kunal-kankriya@users.noreply.github.com> * feat(ingest/looker): include dashboard urns in browse v2 (datahub-project#10955) * add a structured type to batchGet in OpenAPI V3 spec (datahub-project#10956) * fix(ui): scroll on the domain sidebar to show all domains (datahub-project#10966) * fix(ingest/sagemaker): resolve incorrect variable assignment for SageMaker API call (datahub-project#10965) * fix(airflow/build): Pinning mypy (datahub-project#10972) * Fixed a bug where the OpenAPI V3 spec was incorrect. The bug was introduced in datahub-project#10939. (datahub-project#10974) * fix(ingest/test): Fix for mssql integration tests (datahub-project#10978) * fix(entity-service) exist check correctly extracts status (datahub-project#10973) * fix(structuredProps) casing bug in StructuredPropertiesValidator (datahub-project#10982) * bugfix: use anyOf instead of allOf when creating references in openapi v3 spec (datahub-project#10986) * fix(ui): Remove ant less imports (datahub-project#10988) * feat(ingest/graph): Add get_results_by_filter to DataHubGraph (datahub-project#10987) * feat(ingest/cli): init does not actually support environment variables (datahub-project#10989) * fix(ingest/graph): Update get_results_by_filter graphql query (datahub-project#10991) * feat(ingest/spark): Promote beta plugin (datahub-project#10881) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(ingest): support domains in meta -> "datahub" section (datahub-project#10967) * feat(ingest): add `check server-config` command (datahub-project#10990) * feat(cli): Make consistent use of DataHubGraphClientConfig (datahub-project#10466) Deprecates get_url_and_token() in favor of a more complete option: load_graph_config() that returns a full DatahubClientConfig. This change was then propagated across previous usages of get_url_and_token so that connections to DataHub server from the client respect the full breadth of configuration specified by DatahubClientConfig. I.e: You can now specify disable_ssl_verification: true in your ~/.datahubenv file so that all cli functions to the server work when ssl certification is disabled. Fixes datahub-project#9705 * fix(ingest/s3): Fixing container creation when there is no folder in path (datahub-project#10993) * fix(ingest/looker): support platform instance for dashboards & charts (datahub-project#10771) * feat(ingest/bigquery): improve handling of information schema in sql parser (datahub-project#10985) * feat(ingest): improve `ingest deploy` command (datahub-project#10944) * fix(backend): allow excluding soft-deleted entities in relationship-queries; exclude soft-deleted members of groups (datahub-project#10920) - allow excluding soft-deleted entities in relationship-queries - exclude soft-deleted members of groups * fix(ingest/looker): downgrade missing chart type log level (datahub-project#10996) * doc(acryl-cloud): release docs for 0.3.4.x (datahub-project#10984) Co-authored-by: John Joyce <john@acryl.io> Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Pedro Silva <pedro@acryl.io> * fix(protobuf/build): Fix protobuf check jar script (datahub-project#11006) * fix(ui/ingest): Support invalid cron jobs (datahub-project#10998) * fix(ingest): fix graph config loading (datahub-project#11002) Co-authored-by: Pedro Silva <pedro@acryl.io> * feat(docs): Document __DATAHUB_TO_FILE_ directive (datahub-project#10968) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(graphql/upsertIngestionSource): Validate cron schedule; parse error in CLI (datahub-project#11011) * feat(ece): support custom ownership type urns in ECE generation (datahub-project#10999) * feat(assertion-v2): changed Validation tab to Quality and created new Governance tab (datahub-project#10935) * fix(ingestion/glue): Add support for missing config options for profiling in Glue (datahub-project#10858) * feat(propagation): Add models for schema field docs, tags, terms (datahub-project#2959) (datahub-project#11016) Co-authored-by: Chris Collins <chriscollins3456@gmail.com> * docs: standardize terminology to DataHub Cloud (datahub-project#11003) * fix(ingestion/transformer): replace the externalUrl container (datahub-project#11013) * docs(slack) troubleshoot docs (datahub-project#11014) * feat(propagation): Add graphql API (datahub-project#11030) Co-authored-by: Chris Collins <chriscollins3456@gmail.com> * feat(propagation): Add models for Action feature settings (datahub-project#11029) * docs(custom properties): Remove duplicate from sidebar (datahub-project#11033) * feat(models): Introducing Dataset Partitions Aspect (datahub-project#10997) Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * feat(propagation): Add Documentation Propagation Settings (datahub-project#11038) * fix(models): chart schema fields mapping, add dataHubAction entity, t… (datahub-project#11040) * fix(ci): smoke test lint failures (datahub-project#11044) * docs: fix learning center color scheme & typo (datahub-project#11043) * feat: add cloud main page (datahub-project#11017) Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com> * feat(restore-indices): add additional step to also clear system metadata service (datahub-project#10662) Co-authored-by: John Joyce <john@acryl.io> * docs: fix typo (datahub-project#11046) * fix(lint): apply spotless (datahub-project#11050) * docs(airflow): example query to get datajobs for a dataflow (datahub-project#11034) * feat(cli): Add run-id option to put sub-command (datahub-project#11023) Adds an option to assign run-id to a given put command execution. This is useful when transformers do not exist for a given ingestion payload, we can follow up with custom metadata and assign it to an ingestion pipeline. * fix(ingest): improve sql error reporting calls (datahub-project#11025) * fix(airflow): fix CI setup (datahub-project#11031) * feat(ingest/dbt): add experimental `prefer_sql_parser_lineage` flag (datahub-project#11039) * fix(ingestion/lookml): enable stack-trace in lookml logs (datahub-project#10971) * (chore): Linting fix (datahub-project#11015) * chore(ci): update deprecated github actions (datahub-project#10977) * Fix ALB configuration example (datahub-project#10981) * chore(ingestion-base): bump base image packages (datahub-project#11053) * feat(cli): Trim report of dataHubExecutionRequestResult to max GMS size (datahub-project#11051) * fix(ingestion/lookml): emit dummy sql condition for lookml custom condition tag (datahub-project#11008) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(ingestion/powerbi): fix issue with broken report lineage (datahub-project#10910) * feat(ingest/tableau): add retry on timeout (datahub-project#10995) * change generate kafka connect properties from env (datahub-project#10545) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> * fix(ingest): fix oracle cronjob ingestion (datahub-project#11001) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> * chore(ci): revert update deprecated github actions (datahub-project#10977) (datahub-project#11062) * feat(ingest/dbt-cloud): update metadata_endpoint inference (datahub-project#11041) * build: Reduce size of datahub-frontend-react image by 50-ish% (datahub-project#10878) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> * fix(ci): Fix lint issue in datahub_ingestion_run_summary_provider.py (datahub-project#11063) * docs(ingest): update developing-a-transformer.md (datahub-project#11019) * feat(search-test): update search tests from datahub-project#10408 (datahub-project#11056) * feat(cli): add aspects parameter to DataHubGraph.get_entity_semityped (datahub-project#11009) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * docs(airflow): update min version for plugin v2 (datahub-project#11065) * doc(ingestion/tableau): doc update for derived permission (datahub-project#11054) Co-authored-by: Pedro Silva <pedro.cls93@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix(py): remove dep on types-pkg_resources (datahub-project#11076) * feat(ingest/mode): add option to exclude restricted (datahub-project#11081) * fix(ingest): set lastObserved in sdk when unset (datahub-project#11071) * doc(ingest): Update capabilities (datahub-project#11072) * chore(vulnerability): Log Injection (datahub-project#11090) * chore(vulnerability): Information exposure through a stack trace (datahub-project#11091) * chore(vulnerability): Comparison of narrow type with wide type in loop condition (datahub-project#11089) * chore(vulnerability): Insertion of sensitive information into log files (datahub-project#11088) * chore(vulnerability): Risky Cryptographic Algorithm (datahub-project#11059) * chore(vulnerability): Overly permissive regex range (datahub-project#11061) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * fix: update customer data (datahub-project#11075) * fix(models): fixing the datasetPartition models (datahub-project#11085) Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * fix(ui): Adding view, forms GraphQL query, remove showing a fallback error message on unhandled GraphQL error (datahub-project#11084) Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> * feat(docs-site): hiding learn more from cloud page (datahub-project#11097) * fix(docs): Add correct usage of orFilters in search API docs (datahub-project#11082) Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com> * fix(ingest/mode): Regexp in mode name matcher didn't allow underscore (datahub-project#11098) * docs: Refactor customer stories section (datahub-project#10869) Co-authored-by: Jeff Merrick <jeff@wireform.io> * fix(release): fix full/slim suffix on tag (datahub-project#11087) * feat(config): support alternate hashing algorithm for doc id (datahub-project#10423) Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> Co-authored-by: John Joyce <john@acryl.io> * fix(emitter): fix typo in get method of java kafka emitter (datahub-project#11007) * fix(ingest): use correct native data type in all SQLAlchemy sources by compiling data type using dialect (datahub-project#10898) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * chore: Update contributors list in PR labeler (datahub-project#11105) * feat(ingest): tweak stale entity removal messaging (datahub-project#11064) * fix(ingestion): enforce lastObserved timestamps in SystemMetadata (datahub-project#11104) * fix(ingest/powerbi): fix broken lineage between chart and dataset (datahub-project#11080) * feat(ingest/lookml): CLL support for sql set in sql_table_name attribute of lookml view (datahub-project#11069) * docs: update graphql docs on forms & structured properties (datahub-project#11100) * test(search): search openAPI v3 test (datahub-project#11049) * fix(ingest/tableau): prevent empty site content urls (datahub-project#11057) Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * feat(entity-client): implement client batch interface (datahub-project#11106) * fix(snowflake): avoid reporting warnings/info for sys tables (datahub-project#11114) * fix(ingest): downgrade column type mapping warning to info (datahub-project#11115) * feat(api): add AuditStamp to the V3 API entity/aspect response (datahub-project#11118) * fix(ingest/redshift): replace r'\n' with '\n' to avoid token error redshift serverless… (datahub-project#11111) * fix(entiy-client): handle null entityUrn case for restli (datahub-project#11122) * fix(sql-parser): prevent bad urns from alter table lineage (datahub-project#11092) * fix(ingest/bigquery): use small batch size if use_tables_list_query_v2 is set (datahub-project#11121) * fix(graphql): add missing entities to EntityTypeMapper and EntityTypeUrnMapper (datahub-project#10366) * feat(ui): Changes to allow editable dataset name (datahub-project#10608) Co-authored-by: Jay Kadambi <jayasimhan_venkatadri@optum.com> * fix: remove saxo (datahub-project#11127) * feat(mcl-processor): Update mcl processor hooks (datahub-project#11134) * fix(openapi): fix openapi v2 endpoints & v3 documentation update * Revert "fix(openapi): fix openapi v2 endpoints & v3 documentation update" This reverts commit 573c1cb. * docs(policies): updates to policies documentation (datahub-project#11073) * fix(openapi): fix openapi v2 and v3 docs update (datahub-project#11139) * feat(auth): grant type and acr values custom oidc parameters support (datahub-project#11116) * fix(mutator): mutator hook fixes (datahub-project#11140) * feat(search): support sorting on multiple fields (datahub-project#10775) * feat(ingest): various logging improvements (datahub-project#11126) * fix(ingestion/lookml): fix for sql parsing error (datahub-project#11079) Co-authored-by: Harshal Sheth <hsheth2@gmail.com> * feat(docs-site) cloud page spacing and content polishes (datahub-project#11141) * feat(ui) Enable editing structured props on fields (datahub-project#11042) * feat(tests): add md5 and last computed to testResult model (datahub-project#11117) * test(openapi): openapi regression smoke tests (datahub-project#11143) * fix(airflow): fix tox tests + update docs (datahub-project#11125) * docs: add chime to adoption stories (datahub-project#11142) * fix(ingest/databricks): Updating code to work with Databricks sdk 0.30 (datahub-project#11158) * fix(kafka-setup): add missing script to image (datahub-project#11190) * fix(config): fix hash algo config (datahub-project#11191) * test(smoke-test): updates to smoke-tests (datahub-project#11152) * fix(elasticsearch): refactor idHashAlgo setting (datahub-project#11193) * chore(kafka): kafka version bump (datahub-project#11211) * readd UsageStatsWorkUnit * fix merge problems * change logo --------- Co-authored-by: Chris Collins <chriscollins3456@gmail.com> Co-authored-by: John Joyce <john@acryl.io> Co-authored-by: John Joyce <john@Johns-MBP.lan> Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal> Co-authored-by: dushayntAW <158567391+dushayntAW@users.noreply.github.com> Co-authored-by: sagar-salvi-apptware <159135491+sagar-salvi-apptware@users.noreply.github.com> Co-authored-by: Aseem Bansal <asmbansal2@gmail.com> Co-authored-by: Kevin Chun <kevin1chun@gmail.com> Co-authored-by: jordanjeremy <72943478+jordanjeremy@users.noreply.github.com> Co-authored-by: skrydal <piotr.skrydalewicz@gmail.com> Co-authored-by: Harshal Sheth <hsheth2@gmail.com> Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com> Co-authored-by: sid-acryl <155424659+sid-acryl@users.noreply.github.com> Co-authored-by: Julien Jehannet <80408664+aviv-julienjehannet@users.noreply.github.com> Co-authored-by: Hendrik Richert <github@richert.li> Co-authored-by: Hendrik Richert <hendrik.richert@swisscom.com> Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com> Co-authored-by: Felix Lüdin <13187726+Masterchen09@users.noreply.github.com> Co-authored-by: Pirry <158024088+chardaway@users.noreply.github.com> Co-authored-by: Hyejin Yoon <0327jane@gmail.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: cburroughs <chris.burroughs@gmail.com> Co-authored-by: ksrinath <ksrinath@users.noreply.github.com> Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com> Co-authored-by: Kunal-kankriya <127090035+Kunal-kankriya@users.noreply.github.com> Co-authored-by: Shirshanka Das <shirshanka@apache.org> Co-authored-by: ipolding-cais <155455744+ipolding-cais@users.noreply.github.com> Co-authored-by: Tamas Nemeth <treff7es@gmail.com> Co-authored-by: Shubham Jagtap <132359390+shubhamjagtap639@users.noreply.github.com> Co-authored-by: haeniya <yanik.haeni@gmail.com> Co-authored-by: Yanik Häni <Yanik.Haeni1@swisscom.com> Co-authored-by: Gabe Lyons <itsgabelyons@gmail.com> Co-authored-by: Gabe Lyons <gabe.lyons@acryl.io> Co-authored-by: 808OVADOZE <52988741+shtephlee@users.noreply.github.com> Co-authored-by: noggi <anton.kuraev@acryl.io> Co-authored-by: Nicholas Pena <npena@foursquare.com> Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com> Co-authored-by: ethan-cartwright <ethan.cartwright.m@gmail.com> Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io> Co-authored-by: Nadav Gross <33874964+nadavgross@users.noreply.github.com> Co-authored-by: Patrick Franco Braz <patrickfbraz@poli.ufrj.br> Co-authored-by: pie1nthesky <39328908+pie1nthesky@users.noreply.github.com> Co-authored-by: Joel Pinto Mata (KPN-DSH-DEX team) <130968841+joelmataKPN@users.noreply.github.com> Co-authored-by: Ellie O'Neil <110510035+eboneil@users.noreply.github.com> Co-authored-by: Ajoy Majumdar <ajoymajumdar@hotmail.com> Co-authored-by: deepgarg-visa <149145061+deepgarg-visa@users.noreply.github.com> Co-authored-by: Tristan Heisler <tristankheisler@gmail.com> Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io> Co-authored-by: Davi Arnaut <davi.arnaut@acryl.io> Co-authored-by: Pedro Silva <pedro@acryl.io> Co-authored-by: amit-apptware <132869468+amit-apptware@users.noreply.github.com> Co-authored-by: Sam Black <sam.black@acryl.io> Co-authored-by: Raj Tekal <varadaraj_tekal@optum.com> Co-authored-by: Steffen Grohsschmiedt <gitbhub@steffeng.eu> Co-authored-by: jaegwon.seo <162448493+wornjs@users.noreply.github.com> Co-authored-by: Renan F. Lima <51028757+lima-renan@users.noreply.github.com> Co-authored-by: Matt Exchange <xkollar@users.noreply.github.com> Co-authored-by: Jonny Dixon <45681293+acrylJonny@users.noreply.github.com> Co-authored-by: Pedro Silva <pedro.cls93@gmail.com> Co-authored-by: Pinaki Bhattacharjee <pinakipb2@gmail.com> Co-authored-by: Jeff Merrick <jeff@wireform.io> Co-authored-by: skrydal <piotr.skrydalewicz@acryl.io> Co-authored-by: AndreasHegerNuritas <163423418+AndreasHegerNuritas@users.noreply.github.com> Co-authored-by: jayasimhankv <145704974+jayasimhankv@users.noreply.github.com> Co-authored-by: Jay Kadambi <jayasimhan_venkatadri@optum.com> Co-authored-by: David Leifker <david.leifker@acryl.io>
This PR adds model extensions to support action feature toggling.
Checklist
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Chores