Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(acryl-cloud): release docs for 0.3.4.x #10984

Merged
merged 8 commits into from
Jul 26, 2024
Merged

doc(acryl-cloud): release docs for 0.3.4.x #10984

merged 8 commits into from
Jul 26, 2024

Conversation

anshbansal
Copy link
Collaborator

@anshbansal anshbansal commented Jul 24, 2024

Checklist

  • The PR conforms to DataHub's Contributing Guideline (particularly Commit Message Format)
  • Links to related issues (if applicable)
  • Tests for the changes have been added/updated (if applicable)
  • Docs related to the changes have been added/updated (if applicable). If a new feature has been added a Usage Guide has been added for the same.
  • For any breaking change/potential downtime/deprecation/big changes an entry has been made in Updating DataHub

Summary by CodeRabbit

  • New Features

    • Added release notes for version 0.3.4 of the DataHub project, highlighting significant updates and new connectors.
    • Introduced a new sidebar entry for easy access to the latest release notes.
  • Improvements

    • Enhanced SQL parsing capabilities for better compatibility with the Common Language Layer.
    • Improved lineage tracking and added support for additional data sources such as Grafana and Azure Blob.
  • Recommendations

    • Strongly recommend upgrading CLI/SDK to version v0.13.3.4 for optimal performance.

Copy link
Contributor

coderabbitai bot commented Jul 24, 2024

Walkthrough

The recent update enhances the DataHub project documentation by adding release notes for version 0.3.4. This release includes substantial improvements such as new ingestion capabilities, updated connectors, and better compatibility features. Users are encouraged to upgrade their CLI/SDK to benefit from these enhancements and fixes.

Changes

File(s) Change Summary
docs-website/sidebars.js, docs/managed-datahub/release-notes/v_0_3_4.md Added a new entry for version 0.3.4 in the sidebar and introduced corresponding release notes, detailing critical updates, CLI recommendations, new connectors, and ingestion improvements.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant CLI
    participant SDK
    participant Docs

    User->>CLI: Upgrade to v0.13.3.4
    CLI->>SDK: Notify about upgrades and enhancements
    SDK-->>User: Confirm upgrade successful
    User->>Docs: Access release notes for v0.3.4
    Docs-->>User: Display updates and new features
Loading

Poem

🐰 In fields of data, bright and wide,
Version 0.3.4, we take in stride!
New connectors hop, and updates gleam,
With CLI at hand, we chase the dream.
So gather 'round, dear friends of code,
Together we flourish on this new road! 🌱


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the docs Issues and Improvements to docs label Jul 24, 2024
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (7)
docs/managed-datahub/release-notes/v_0_3_4.md (7)

4-6: Use atx style for the header.

The header style should be consistent throughout the document.

- Release Availability Date
- ---
+ ## Release Availability Date
Tools
Markdownlint

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-10: Use atx style for the header and format the URL as a markdown link.

The header style should be consistent throughout the document, and the URL should be formatted for better readability.

- Recommended CLI/SDK
- ---
+ ## Recommended CLI/SDK
- `v0.13.3.4` with release notes at https://github.com/acryldata/datahub/releases/tag/v0.13.3.4
+ `v0.13.3.4` with release notes at [GitHub](https://github.com/acryldata/datahub/releases/tag/v0.13.3.4)
Tools
Markdownlint

8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


10-10: null
Bare URL used

(MD034, no-bare-urls)


14-29: Fix the indentation of the unordered list.

The indentation should be consistent for better readability.

- - Ingestion changes
-     - Looker had a big overhaul merged for sql parsing which should help with CLL. Sid is going to be doing a followup with any edge cases
-     - Tracking CLI versions in system metadata
-     - Async options added in CLI
-     - Bunch of airflow fixes
-         - Soft deleted entities now come back
-         - cleanup DAG in docs
-     - New grafana connector (Testing)
-     - New azure blob connector
-     - Glue to s3 lineage
-     - snowflake queries source
-     - powerbi dataset profiling
-     - file source supports reading from s3
+ - Ingestion changes
+   - Looker had a big overhaul merged for sql parsing which should help with CLL. Sid will be doing a followup with any edge cases
+   - Tracking CLI versions in system metadata
+   - Async options added in CLI
+   - Bunch of airflow fixes
+     - Soft deleted entities now come back
+     - cleanup DAG in docs
+   - New grafana connector (Testing)
+   - New azure blob connector
+   - Glue to s3 lineage
+   - snowflake queries source
+   - powerbi dataset profiling
+   - file source supports reading from s3
Tools
LanguageTool

[style] ~18-~18: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint

18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


22-22: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


23-23: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


24-24: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Format the URL as a markdown link.

The URL should be formatted for better readability.

- Since `v0.3.3` these changes from OSS DataHub https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c have been pulled in.
+ Since `v0.3.3` these changes from OSS DataHub [GitHub](https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c) have been pulled in.
Tools
Markdownlint

32-32: null
Bare URL used

(MD034, no-bare-urls)


12-12: Add a comma after "version" and before "then".

A comma is needed to improve readability.

- If you are using an older CLI/SDK version then please upgrade it.
+ If you are using an older CLI/SDK version, then please upgrade it.
Tools
LanguageTool

[typographical] ~12-~12: Consider adding a comma.
Context: ...f you are using an older CLI/SDK version then please upgrade it. This applies for all...

(IF_THEN_COMMA)


[uncategorized] ~12-~12: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...e as we keep on pushing fixes in the CLI and it helps us support you better. ## Rel...

(COMMA_COMPOUND_SENTENCE)


12-12: Add a comma before "and".

A comma is needed before "and" to separate the clauses.

- This is a strong recommendation to upgrade as we keep on pushing fixes in the CLI and it helps us support you better.
+ This is a strong recommendation to upgrade as we keep on pushing fixes in the CLI, and it helps us support you better.
Tools
LanguageTool

[typographical] ~12-~12: Consider adding a comma.
Context: ...f you are using an older CLI/SDK version then please upgrade it. This applies for all...

(IF_THEN_COMMA)


[uncategorized] ~12-~12: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...e as we keep on pushing fixes in the CLI and it helps us support you better. ## Rel...

(COMMA_COMPOUND_SENTENCE)


18-18: Use "will" instead of "going to".

"Will" is more appropriate for indicating certainty.

- Sid is going to be doing a followup with any edge cases
+ Sid will be doing a followup with any edge cases
Tools
LanguageTool

[style] ~18-~18: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint

18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 4921967 and cf14814.

Files selected for processing (2)
  • docs-website/sidebars.js (1 hunks)
  • docs/managed-datahub/release-notes/v_0_3_4.md (1 hunks)
Files skipped from review due to trivial changes (1)
  • docs-website/sidebars.js
Additional context used
LanguageTool
docs/managed-datahub/release-notes/v_0_3_4.md

[typographical] ~12-~12: Consider adding a comma.
Context: ...f you are using an older CLI/SDK version then please upgrade it. This applies for all...

(IF_THEN_COMMA)


[uncategorized] ~12-~12: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...e as we keep on pushing fixes in the CLI and it helps us support you better. ## Rel...

(COMMA_COMPOUND_SENTENCE)


[style] ~18-~18: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint
docs/managed-datahub/release-notes/v_0_3_4.md

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


22-22: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


23-23: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


24-24: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


10-10: null
Bare URL used

(MD034, no-bare-urls)


32-32: null
Bare URL used

(MD034, no-bare-urls)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between cf14814 and 512624a.

Files selected for processing (1)
  • docs/managed-datahub/release-notes/v_0_3_4.md (1 hunks)
Additional context used
LanguageTool
docs/managed-datahub/release-notes/v_0_3_4.md

[typographical] ~12-~12: Consider adding a comma.
Context: ...f you are using an older CLI/SDK version then please upgrade it. This applies for all...

(IF_THEN_COMMA)


[uncategorized] ~12-~12: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...e as we keep on pushing fixes in the CLI and it helps us support you better. ## Rel...

(COMMA_COMPOUND_SENTENCE)


[style] ~25-~25: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint
docs/managed-datahub/release-notes/v_0_3_4.md

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


30-30: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


31-31: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


35-35: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


36-36: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


10-10: null
Bare URL used

(MD034, no-bare-urls)


39-39: null
Bare URL used

(MD034, no-bare-urls)

Comment on lines 14 to 21
## Release Changelog
---

- Product changes
- [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
- [cross-instance share] Display share failures correctly, handle URLs correctly
- [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
- [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix unordered list indentation.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation.

-  - [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
-  - [cross-instance share] Display share failures correctly, handle URLs correctly
-  - [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
-  - [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
+  - [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
+  - [cross-instance share] Display share failures correctly, handle URLs correctly
+  - [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
+  - [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph

Committable suggestion was skipped due to low confidence.

Tools
Markdownlint

18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

Comment on lines 1 to 6
# v0.3.4
---

Release Availability Date
---
TBD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use consistent heading styles.

The heading styles should be consistent throughout the document. It's recommended to use atx style (e.g., # Heading) for all headings.

-# v0.3.4
----
-Release Availability Date
----
+## v0.3.4
+
+## Release Availability Date
+
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
# v0.3.4
---
Release Availability Date
---
TBD
## v0.3.4
## Release Availability Date
TBD
Tools
Markdownlint

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)



- Ingestion changes
- Looker had a big overhaul merged for sql parsing which should help with CLL. Sid is going to be doing a followup with any edge cases
Copy link
Contributor

@coderabbitai coderabbitai bot Jul 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'will' instead of 'going to'.

Use ‘will’ instead of ‘going to’ if the following action is certain.

-Sid is going to be doing a followup with any edge cases
+Sid will be doing a followup with any edge cases
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Looker had a big overhaul merged for sql parsing which should help with CLL. Sid is going to be doing a followup with any edge cases
- Looker had a big overhaul merged for sql parsing which should help with CLL. Sid will be doing a followup with any edge cases
Tools
LanguageTool

[style] ~25-~25: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint

25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anshbansal information about acryl devs should not appear

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 512624a and 5f18312.

Files selected for processing (1)
  • docs/managed-datahub/release-notes/v_0_3_4.md (1 hunks)
Additional context used
LanguageTool
docs/managed-datahub/release-notes/v_0_3_4.md

[typographical] ~12-~12: Consider adding a comma.
Context: ...f you are using an older CLI/SDK version then please upgrade it. This applies for all...

(IF_THEN_COMMA)


[uncategorized] ~12-~12: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short).
Context: ...e as we keep on pushing fixes in the CLI and it helps us support you better. ## Rel...

(COMMA_COMPOUND_SENTENCE)


[style] ~25-~25: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint
docs/managed-datahub/release-notes/v_0_3_4.md

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


30-30: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


31-31: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


35-35: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


36-36: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


39-39: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


10-10: null
Bare URL used

(MD034, no-bare-urls)


42-42: null
Bare URL used

(MD034, no-bare-urls)

Additional comments not posted (1)
docs/managed-datahub/release-notes/v_0_3_4.md (1)

1-2: Use consistent heading styles.

The heading style should be consistent throughout the document. It's recommended to use atx style (e.g., # v0.3.4) for all headings.

-# v0.3.4
----
+# v0.3.4
+

Likely invalid or redundant comment.

docs/managed-datahub/release-notes/v_0_3_4.md Show resolved Hide resolved
docs/managed-datahub/release-notes/v_0_3_4.md Show resolved Hide resolved
docs/managed-datahub/release-notes/v_0_3_4.md Outdated Show resolved Hide resolved
Comment on lines 42 to 43
- Since `v0.3.3` these changes from OSS DataHub https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c have been pulled in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Format the URL properly.

Avoid using bare URLs. Format the URL properly.

-Since `v0.3.3` these changes from OSS DataHub https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c have been pulled in.
+Since `v0.3.3`, these changes from OSS DataHub have been pulled in: [OSS DataHub Changes](https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c).
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Since `v0.3.3` these changes from OSS DataHub https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c have been pulled in.
Since `v0.3.3`, these changes from OSS DataHub have been pulled in: [OSS DataHub Changes](https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c).
Tools
Markdownlint

42-42: null
Bare URL used

(MD034, no-bare-urls)

Comment on lines 17 to 21
- Product changes
- [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
- [cross-instance share] Display share failures correctly, handle URLs correctly
- [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
- [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix unordered list indentation.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation.

-    - [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
-    - [cross-instance share] Display share failures correctly, handle URLs correctly
-    - [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
-    - [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
+  - [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
+  - [cross-instance share] Display share failures correctly, handle URLs correctly
+  - [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
+  - [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Product changes
- [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
- [cross-instance share] Display share failures correctly, handle URLs correctly
- [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
- [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
- Product changes
- [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
- [cross-instance share] Display share failures correctly, handle URLs correctly
- [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
- [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
Tools
Markdownlint

18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

Comment on lines 24 to 36
- Ingestion changes
- Looker had a big overhaul merged for sql parsing which should help with CLL. Sid is going to be doing a followup with any edge cases
- Tracking CLI versions in system metadata
- Async options added in CLI
- Bunch of airflow fixes
- Soft deleted entities now come back
- cleanup DAG in docs
- New grafana connector (Testing)
- New azure blob connector
- Glue to s3 lineage
- snowflake queries source
- powerbi dataset profiling
- file source supports reading from s3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix unordered list indentation and stylistic issue.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation. Use "will" instead of "going to" for certainty.

-    - Looker had a big overhaul merged for sql parsing which should help with CLL. Sid is going to be doing a followup with any edge cases
-    - Tracking CLI versions in system metadata
-    - Async options added in CLI
-    - Bunch of airflow fixes
-        - Soft deleted entities now come back
-        - cleanup DAG in docs
-    - New grafana connector (Testing)
-    - New azure blob connector
-    - Glue to s3 lineage
-    - snowflake queries source
-    - powerbi dataset profiling
-    - file source supports reading from s3
+  - Looker had a big overhaul merged for sql parsing which should help with CLL. Sid will be doing a followup with any edge cases
+  - Tracking CLI versions in system metadata
+  - Async options added in CLI
+  - Bunch of airflow fixes
+    - Soft deleted entities now come back
+    - cleanup DAG in docs
+  - New grafana connector (Testing)
+  - New azure blob connector
+  - Glue to s3 lineage
+  - snowflake queries source
+  - powerbi dataset profiling
+  - file source supports reading from s3
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Ingestion changes
- Looker had a big overhaul merged for sql parsing which should help with CLL. Sid is going to be doing a followup with any edge cases
- Tracking CLI versions in system metadata
- Async options added in CLI
- Bunch of airflow fixes
- Soft deleted entities now come back
- cleanup DAG in docs
- New grafana connector (Testing)
- New azure blob connector
- Glue to s3 lineage
- snowflake queries source
- powerbi dataset profiling
- file source supports reading from s3
- Ingestion changes
- Looker had a big overhaul merged for sql parsing which should help with CLL. Sid will be doing a followup with any edge cases
- Tracking CLI versions in system metadata
- Async options added in CLI
- Bunch of airflow fixes
- Soft deleted entities now come back
- cleanup DAG in docs
- New grafana connector (Testing)
- New azure blob connector
- Glue to s3 lineage
- snowflake queries source
- powerbi dataset profiling
- file source supports reading from s3
Tools
LanguageTool

[style] ~25-~25: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint

25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


30-30: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


31-31: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


35-35: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


36-36: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

Copy link
Collaborator

@pedro93 pedro93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The language seems pretty lacking. We should have more fleshed out and professional.

anshbansal and others added 4 commits July 26, 2024 14:13
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (7)
docs/managed-datahub/release-notes/v_0_3_4.md (7)

1-6: Use consistent heading styles.

The heading styles should be consistent throughout the document. It's recommended to use atx style (e.g., # Heading) for all headings.

-# v0.3.4
----
-Release Availability Date
----
+## v0.3.4
+
+## Release Availability Date
+
Tools
Markdownlint

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-10: Use consistent heading styles and format URLs.

The heading style should be consistent throughout the document. It's recommended to use atx style (e.g., ## Recommended CLI/SDK) for all headings. Additionally, format the URL properly to avoid using bare URLs.

-Recommended CLI/SDK
----
-- `v0.13.3.4` with release notes at https://github.com/acryldata/datahub/releases/tag/v0.13.3.4
+## Recommended CLI/SDK
+
+- `v0.13.3.4` with release notes at [v0.13.3.4 Release Notes](https://github.com/acryldata/datahub/releases/tag/v0.13.3.4)
Tools
Markdownlint

8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


10-10: null
Bare URL used

(MD034, no-bare-urls)


12-12: Add commas for clarity.

Consider adding commas for better readability and to connect independent clauses correctly.

-If you are using an older CLI/SDK version, then please upgrade it. This applies for all CLI/SDK usages, if you are using it through your terminal, GitHub Actions, Airflow, in Python SDK somewhere, Java SDK, etc. This is a strong recommendation to upgrade, as we keep on pushing fixes in the CLI, and it helps us support you better.

17-21: Fix unordered list indentation.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation.

-    - [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
-    - [cross-instance share] Display share failures correctly, handle URLs correctly
-    - [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
-    - [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
+  - [notifications] Send test notifications to Slack user or group from settings, minor other fixes for slack integration experience
+  - [cross-instance share] Display share failures correctly, handle URLs correctly
+  - [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
+  - [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
Tools
Markdownlint

18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


24-36: Fix unordered list indentation and stylistic issue.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation. Use "will" instead of "going to" for certainty.

-    - Looker had a big overhaul merged for sql parsing which should help with CLL. Sid is going to be doing a followup with any edge cases
-    - Tracking CLI versions in system metadata
-    - Async options added in CLI
-    - Bunch of airflow fixes
-        - Soft deleted entities now come back
-        - cleanup DAG in docs
-    - New grafana connector (Testing)
-    - New azure blob connector
-    - Glue to s3 lineage
-    - snowflake queries source
-    - powerbi dataset profiling
-    - file source supports reading from s3
+  - Looker had a big overhaul merged for sql parsing which should help with CLL. Sid will be doing a followup with any edge cases
+  - Tracking CLI versions in system metadata
+  - Async options added in CLI
+  - Bunch of airflow fixes
+    - Soft deleted entities now come back
+    - cleanup DAG in docs
+  - New grafana connector (Testing)
+  - New azure blob connector
+  - Glue to s3 lineage
+  - snowflake queries source
+  - powerbi dataset profiling
+  - file source supports reading from s3
Tools
LanguageTool

[style] ~25-~25: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint

25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


30-30: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


31-31: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


35-35: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


36-36: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


39-39: Fix unordered list indentation.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation.

-    - Initial support for custom MCP mutator hooks
+  - Initial support for custom MCP mutator hooks
Tools
Markdownlint

39-39: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


42-42: Format the URL properly.

Avoid using bare URLs. Format the URL properly.

-Since `v0.3.3` these changes from OSS DataHub https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c have been pulled in.
+Since `v0.3.3`, these changes from OSS DataHub have been pulled in: [OSS DataHub Changes](https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c).
Tools
Markdownlint

42-42: null
Bare URL used

(MD034, no-bare-urls)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5f18312 and 5b44c3c.

Files selected for processing (1)
  • docs/managed-datahub/release-notes/v_0_3_4.md (1 hunks)
Additional context used
LanguageTool
docs/managed-datahub/release-notes/v_0_3_4.md

[style] ~25-~25: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint
docs/managed-datahub/release-notes/v_0_3_4.md

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


30-30: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


31-31: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


35-35: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


36-36: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


39-39: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


10-10: null
Bare URL used

(MD034, no-bare-urls)


42-42: null
Bare URL used

(MD034, no-bare-urls)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Outside diff range, codebase verification and nitpick comments (6)
docs/managed-datahub/release-notes/v_0_3_4.md (6)

1-6: Use consistent heading styles.

The heading styles should be consistent throughout the document. It's recommended to use atx style (e.g., ## Heading) for all headings.

-# v0.3.4
----
-Release Availability Date
----
+## v0.3.4
+
+## Release Availability Date
+
Tools
Markdownlint

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-10: Use consistent heading styles and format URLs.

The heading style should be consistent throughout the document. It's recommended to use atx style (e.g., ## Recommended CLI/SDK) for all headings. Additionally, format the URL properly to avoid using bare URLs.

-Recommended CLI/SDK
----
-- `v0.13.3.4` with release notes at https://github.com/acryldata/datahub/releases/tag/v0.13.3.4
+## Recommended CLI/SDK
+
+- `v0.13.3.4` with release notes at [v0.13.3.4 Release Notes](https://github.com/acryldata/datahub/releases/tag/v0.13.3.4)
Tools
Markdownlint

8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


10-10: null
Bare URL used

(MD034, no-bare-urls)


12-12: Add commas for clarity.

Consider adding commas for better readability and to connect independent clauses correctly.

-If you are using an older CLI/SDK version, then please upgrade it. This applies for all CLI/SDK usages, if you are using it through your terminal, GitHub Actions, Airflow, in Python SDK somewhere, Java SDK, etc. This is a strong recommendation to upgrade, as we keep on pushing fixes in the CLI, and it helps us support you better.

17-21: Fix unordered list indentation.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation.

-    - [notifications] Send test notifications to Slack user or group from settings, other minor fixes for slack integration experience
-    - [cross-instance share] Display share failures correctly, handle URLs correctly
-    - [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
-    - [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
+  - [notifications] Send test notifications to Slack user or group from settings, other minor fixes for slack integration experience
+  - [cross-instance share] Display share failures correctly, handle URLs correctly
+  - [siblings] fix siblings split feature flag for autocomplete, disallow creation of assertions on merged sibling page, fix bug in editing an assertion on merged lineage node
+  - [lineage - v2] minor fixes to lineage counts, cll lineage resolution, respecting soft deletion on lineage graph
Tools
Markdownlint

18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


24-36: Fix unordered list indentation and stylistic issue.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation. Use "will" instead of "going to" for certainty.

-    - Looker had a big overhaul merged for sql parsing which should help with CLL. Sid is going to be doing a followup with any edge cases
-    - Tracking CLI versions in system metadata
-    - Async options added in CLI
-    - Bunch of airflow fixes
-        - Soft deleted entities now come back
-        - cleanup DAG in docs
-    - New grafana connector (Testing)
-    - New azure blob connector
-    - Glue to s3 lineage
-    - snowflake queries source
-    - powerbi dataset profiling
-    - file source supports reading from s3
+  - Looker had a big overhaul merged for sql parsing which should help with CLL. Sid will be doing a followup with any edge cases
+  - Tracking CLI versions in system metadata
+  - Async options added in CLI
+  - Bunch of airflow fixes
+    - Soft deleted entities now come back
+    - cleanup DAG in docs
+  - New grafana connector (Testing)
+  - New azure blob connector
+  - Glue to s3 lineage
+  - snowflake queries source
+  - powerbi dataset profiling
+  - file source supports reading from s3
Tools
LanguageTool

[style] ~25-~25: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint

25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


30-30: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


31-31: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


35-35: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


36-36: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


38-42: Fix unordered list indentation and format the URL properly.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation. Avoid using bare URLs. Format the URL properly.

-    - Initial support for custom MCP mutator hooks
-
- Since `v0.3.3` these changes from OSS DataHub https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c have been pulled in.
+  - Initial support for custom MCP mutator hooks
+
+Since `v0.3.3`, these changes from OSS DataHub have been pulled in: [OSS DataHub Changes](https://github.com/datahub-project/datahub/compare/92e9a5823bc14e81f0f21c55a68c493c3bbe87b9...8d874ad1e4bef9d7afbe20fb3cb457566a15c61c).
Tools
Markdownlint

39-39: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


42-42: null
Bare URL used

(MD034, no-bare-urls)

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5b44c3c and aab3f93.

Files selected for processing (1)
  • docs/managed-datahub/release-notes/v_0_3_4.md (1 hunks)
Additional context used
LanguageTool
docs/managed-datahub/release-notes/v_0_3_4.md

[style] ~25-~25: Use ‘will’ instead of ‘going to’ if the following action is certain.
Context: ...parsing which should help with CLL. Sid is going to be doing a followup with any edge cases...

(GOING_TO_WILL)

Markdownlint
docs/managed-datahub/release-notes/v_0_3_4.md

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


30-30: Expected: 4; Actual: 8
Unordered list indentation

(MD007, ul-indent)


31-31: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


35-35: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


36-36: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


39-39: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


10-10: null
Bare URL used

(MD034, no-bare-urls)


42-42: null
Bare URL used

(MD034, no-bare-urls)

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between aab3f93 and 5a63b36.

Files selected for processing (1)
  • docs/managed-datahub/release-notes/v_0_3_4.md (1 hunks)
Additional context used
LanguageTool
docs/managed-datahub/release-notes/v_0_3_4.md

[style] ~18-~18: As a shorter alternative for ‘able to’, consider using “can now”.
Context: ...oduct changes - [notifications] You are now able to send test notifications to Slack user o...

(BE_ABLE_TO)


[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nc REST sink capabilities in CLI. - Added documentation on how to cleanup obsolet...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[misspelling] ~28-~28: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: ...LI. - Added documentation on how to cleanup obsolete airflow pipelines and tasks fr...

(CLEAN_UP)


[style] ~33-~33: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...es, and operations all in one go. - Added dataset profiling to PowerBI. - Add...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~34-~34: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ded dataset profiling to PowerBI. - Added a file source integration (S3 / Local F...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

Markdownlint
docs/managed-datahub/release-notes/v_0_3_4.md

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


30-30: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


31-31: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


37-37: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


10-10: null
Bare URL used

(MD034, no-bare-urls)

Additional comments not posted (8)
docs/managed-datahub/release-notes/v_0_3_4.md (8)

4-5: Use consistent heading styles.

The heading style should be consistent throughout the document. It's recommended to use atx style (e.g., ## Release Availability Date) for all headings.

Tools
Markdownlint

4-4: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


8-10: Use consistent heading styles and format URLs.

The heading style should be consistent throughout the document. It's recommended to use atx style (e.g., ## Recommended CLI/SDK) for all headings. Additionally, format the URL properly to avoid using bare URLs.

Tools
Markdownlint

8-8: Expected: atx; Actual: setext
Heading style

(MD003, heading-style)


10-10: null
Bare URL used

(MD034, no-bare-urls)


12-12: Add commas for clarity.

Consider adding commas for better readability and to connect independent clauses correctly.


14-14: Use consistent heading styles.

The heading style should be consistent throughout the document. It's recommended to use atx style (e.g., ## Release Changelog) for all headings.


17-21: Fix unordered list indentation.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation.

Tools
LanguageTool

[style] ~18-~18: As a shorter alternative for ‘able to’, consider using “can now”.
Context: ...oduct changes - [notifications] You are now able to send test notifications to Slack user o...

(BE_ABLE_TO)

Markdownlint

18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


19-19: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


20-20: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


21-21: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


23-36: Fix unordered list indentation and stylistic issues.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation. Additionally, reword sentences to avoid repetition and correct the use of "cleanup".

Tools
LanguageTool

[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nc REST sink capabilities in CLI. - Added documentation on how to cleanup obsolet...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[misspelling] ~28-~28: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: ...LI. - Added documentation on how to cleanup obsolete airflow pipelines and tasks fr...

(CLEAN_UP)


[style] ~33-~33: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...es, and operations all in one go. - Added dataset profiling to PowerBI. - Add...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~34-~34: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ded dataset profiling to PowerBI. - Added a file source integration (S3 / Local F...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

Markdownlint

25-25: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


26-26: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


27-27: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


29-29: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


30-30: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


31-31: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


32-32: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


36-37: Fix unordered list indentation.

The indentation of unordered list items should be consistent. Use 2 spaces for each level of indentation.

Tools
Markdownlint

37-37: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


39-39: Format the URL properly.

Avoid using bare URLs. Format the URL properly.

---

- Product changes
- [notifications] You are now able to send test notifications to Slack user or group from settings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'can now' instead of 'able to'.

As a shorter alternative for ‘able to’, consider using “can now”.

-    - [notifications] You are now able to send test notifications to Slack user or group from settings.
+    - [notifications] You can now send test notifications to Slack user or group from settings.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- [notifications] You are now able to send test notifications to Slack user or group from settings.
- [notifications] You can now send test notifications to Slack user or group from settings.
Tools
LanguageTool

[style] ~18-~18: As a shorter alternative for ‘able to’, consider using “can now”.
Context: ...oduct changes - [notifications] You are now able to send test notifications to Slack user o...

(BE_ABLE_TO)

Markdownlint

18-18: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

Comment on lines +33 to +34
- Added dataset profiling to PowerBI.
- Added a file source integration (S3 / Local Files), this is to add files as datasets. Not to be confused with the metadata file source that loads MCPs into DataHub.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reword sentences to avoid repetition.

Three successive sentences begin with the same word. Consider rewording the sentences or use a thesaurus to find a synonym.

-    - Added dataset profiling to PowerBI.
-    - Added a file source integration (S3 / Local Files), this is to add files as datasets. Not to be confused with the metadata file source that loads MCPs into DataHub.
+    - Dataset profiling has been added to PowerBI.
+    - A file source integration (S3 / Local Files) has been added to include files as datasets. This should not be confused with the metadata file source that loads MCPs into DataHub.
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- Added dataset profiling to PowerBI.
- Added a file source integration (S3 / Local Files), this is to add files as datasets. Not to be confused with the metadata file source that loads MCPs into DataHub.
- Dataset profiling has been added to PowerBI.
- A file source integration (S3 / Local Files) has been added to include files as datasets. This should not be confused with the metadata file source that loads MCPs into DataHub.
Tools
LanguageTool

[style] ~33-~33: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...es, and operations all in one go. - Added dataset profiling to PowerBI. - Add...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[style] ~34-~34: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...ded dataset profiling to PowerBI. - Added a file source integration (S3 / Local F...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)

Markdownlint

33-33: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)


34-34: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

Comment on lines +1 to +2
# v0.3.4
---
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use consistent heading styles.

The heading style should be consistent throughout the document. It's recommended to use atx style (e.g., ## v0.3.4) for all headings.

-# v0.3.4
---
+## v0.3.4
+

Committable suggestion was skipped due to low confidence.

- Added support for SQL parsing in Looker source to more correctly represent column-level-lineage. Please report any edge cases issues to the Acryl team as we will be closely monitoring this integration.
- Added cli version in system metadata at the aspect level for tracking purposes.
- Added async REST sink capabilities in CLI.
- Added documentation on how to cleanup obsolete airflow pipelines and tasks from Datahub
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reword sentence to avoid repetition and correct "cleanup".

Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym. Also, use "clean up" instead of "cleanup".

-    - Added documentation on how to cleanup obsolete airflow pipelines and tasks from Datahub
+    - Added documentation on how to clean up obsolete airflow pipelines and tasks from Datahub

Committable suggestion was skipped due to low confidence.

Tools
LanguageTool

[style] ~28-~28: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...nc REST sink capabilities in CLI. - Added documentation on how to cleanup obsolet...

(ENGLISH_WORD_REPEAT_BEGINNING_RULE)


[misspelling] ~28-~28: Did you mean the phrasal verb “clean up” instead of the noun ‘cleanup’?
Context: ...LI. - Added documentation on how to cleanup obsolete airflow pipelines and tasks fr...

(CLEAN_UP)

Markdownlint

28-28: Expected: 2; Actual: 4
Unordered list indentation

(MD007, ul-indent)

@anshbansal anshbansal merged commit 236043b into master Jul 26, 2024
33 checks passed
@anshbansal anshbansal deleted the ab-docs-0-3-4 branch July 26, 2024 09:53
arosanda added a commit to infobip/datahub that referenced this pull request Sep 23, 2024
* feat(forms) Handle deleting forms references when hard deleting forms (datahub-project#10820)

* refactor(ui): Misc improvements to the setup ingestion flow (ingest uplift 1/2)  (datahub-project#10764)

Co-authored-by: John Joyce <john@Johns-MBP.lan>
Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal>

* fix(ingestion/airflow-plugin): pipeline tasks discoverable in search (datahub-project#10819)

* feat(ingest/transformer): tags to terms transformer (datahub-project#10758)

Co-authored-by: Aseem Bansal <asmbansal2@gmail.com>

* fix(ingestion/unity-catalog): fixed issue with profiling with GE turned on (datahub-project#10752)

Co-authored-by: Aseem Bansal <asmbansal2@gmail.com>

* feat(forms) Add java SDK for form entity PATCH + CRUD examples (datahub-project#10822)

* feat(SDK) Add java SDK for structuredProperty entity PATCH + CRUD examples (datahub-project#10823)

* feat(SDK) Add StructuredPropertyPatchBuilder in python sdk and provide sample CRUD files (datahub-project#10824)

* feat(forms) Add CRUD endpoints to GraphQL for Form entities (datahub-project#10825)

* add flag for includeSoftDeleted in scroll entities API (datahub-project#10831)

* feat(deprecation) Return actor entity with deprecation aspect (datahub-project#10832)

* feat(structuredProperties) Add CRUD graphql APIs for structured property entities (datahub-project#10826)

* add scroll parameters to openapi v3 spec (datahub-project#10833)

* fix(ingest): correct profile_day_of_week implementation (datahub-project#10818)

* feat(ingest/glue): allow ingestion of empty databases from Glue (datahub-project#10666)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* feat(cli): add more details to get cli (datahub-project#10815)

* fix(ingestion/glue): ensure date formatting works on all platforms for aws glue (datahub-project#10836)

* fix(ingestion): fix datajob patcher (datahub-project#10827)

* fix(smoke-test): add suffix in temp file creation (datahub-project#10841)

* feat(ingest/glue): add helper method to permit user or group ownership (datahub-project#10784)

* feat(): Show data platform instances in policy modal if they are set on the policy (datahub-project#10645)

Co-authored-by: Hendrik Richert <hendrik.richert@swisscom.com>

* docs(patch): add patch documentation for how implementation works (datahub-project#10010)

Co-authored-by: John Joyce <john@acryl.io>

* fix(jar): add missing custom-plugin-jar task (datahub-project#10847)

* fix(): also check exceptions/stack trace when filtering log messages (datahub-project#10391)

Co-authored-by: John Joyce <john@acryl.io>

* docs(): Update posts.md (datahub-project#9893)

Co-authored-by: Hyejin Yoon <0327jane@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* chore(ingest): update acryl-datahub-classify version (datahub-project#10844)

* refactor(ingest): Refactor structured logging to support infos, warnings, and failures structured reporting to UI (datahub-project#10828)

Co-authored-by: John Joyce <john@Johns-MBP.lan>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* fix(restli): log aspect-not-found as a warning rather than as an error (datahub-project#10834)

* fix(ingest/nifi): remove duplicate upstream jobs (datahub-project#10849)

* fix(smoke-test): test access to create/revoke personal access tokens (datahub-project#10848)

* fix(smoke-test): missing test for move domain (datahub-project#10837)

* ci: update usernames to not considered for community (datahub-project#10851)

* env: change defaults for data contract visibility (datahub-project#10854)

* fix(ingest/tableau): quote special characters in external URL (datahub-project#10842)

* fix(smoke-test): fix flakiness of auto complete test

* ci(ingest): pin dask dependency for feast (datahub-project#10865)

* fix(ingestion/lookml): liquid template resolution and view-to-view cll (datahub-project#10542)

* feat(ingest/audit): add client id and version in system metadata props (datahub-project#10829)

* chore(ingest): Mypy 1.10.1 pin (datahub-project#10867)

* docs: use acryl-datahub-actions as expected python package to install (datahub-project#10852)

* docs: add new js snippet (datahub-project#10846)

* refactor(ingestion): remove company domain for security reason (datahub-project#10839)

* fix(ingestion/spark): Platform instance and column level lineage fix (datahub-project#10843)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* feat(ingestion/tableau): optionally ingest multiple sites and create site containers (datahub-project#10498)

Co-authored-by: Yanik Häni <Yanik.Haeni1@swisscom.com>

* fix(ingestion/looker): Add sqlglot dependency and remove unused sqlparser (datahub-project#10874)

* fix(manage-tokens): fix manage access token policy (datahub-project#10853)

* Batch get entity endpoints (datahub-project#10880)

* feat(system): support conditional write semantics (datahub-project#10868)

* fix(build): upgrade vercel builds to Node 20.x (datahub-project#10890)

* feat(ingest/lookml): shallow clone repos (datahub-project#10888)

* fix(ingest/looker): add missing dependency (datahub-project#10876)

* fix(ingest): only populate audit stamps where accurate (datahub-project#10604)

* fix(ingest/dbt): always encode tag urns (datahub-project#10799)

* fix(ingest/redshift): handle multiline alter table commands (datahub-project#10727)

* fix(ingestion/looker): column name missing in explore (datahub-project#10892)

* fix(lineage) Fix lineage source/dest filtering with explored per hop limit (datahub-project#10879)

* feat(conditional-writes): misc updates and fixes (datahub-project#10901)

* feat(ci): update outdated action (datahub-project#10899)

* feat(rest-emitter): adding async flag to rest emitter (datahub-project#10902)

Co-authored-by: Gabe Lyons <gabe.lyons@acryl.io>

* feat(ingest): add snowflake-queries source (datahub-project#10835)

* fix(ingest): improve `auto_materialize_referenced_tags_terms` error handling (datahub-project#10906)

* docs: add new company to adoption list (datahub-project#10909)

* refactor(redshift): Improve redshift error handling with new structured reporting system (datahub-project#10870)

Co-authored-by: John Joyce <john@Johns-MBP.lan>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* feat(ui) Finalize support for all entity types on forms (datahub-project#10915)

* Index ExecutionRequestResults status field (datahub-project#10811)

* feat(ingest): grafana connector (datahub-project#10891)

Co-authored-by: Shirshanka Das <shirshanka@apache.org>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* fix(gms) Add Form entity type to EntityTypeMapper (datahub-project#10916)

* feat(dataset): add support for external url in Dataset (datahub-project#10877)

* docs(saas-overview) added missing features to observe section (datahub-project#10913)

Co-authored-by: John Joyce <john@acryl.io>

* fix(ingest/spark): Fixing Micrometer warning (datahub-project#10882)

* fix(structured properties): allow application of structured properties without schema file (datahub-project#10918)

* fix(data-contracts-web) handle other schedule types (datahub-project#10919)

* fix(ingestion/tableau): human-readable message for PERMISSIONS_MODE_SWITCHED error (datahub-project#10866)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* Add feature flag for view defintions (datahub-project#10914)

Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io>

* feat(ingest/BigQuery): refactor+parallelize dataset metadata extraction (datahub-project#10884)

* fix(airflow): add error handling around render_template() (datahub-project#10907)

* feat(ingestion/sqlglot): add optional `default_dialect` parameter to sqlglot lineage (datahub-project#10830)

* feat(mcp-mutator): new mcp mutator plugin (datahub-project#10904)

* fix(ingest/bigquery): changes helper function to decode unicode scape sequences (datahub-project#10845)

* feat(ingest/postgres): fetch table sizes for profile (datahub-project#10864)

* feat(ingest/abs): Adding azure blob storage ingestion source (datahub-project#10813)

* fix(ingest/redshift): reduce severity of SQL parsing issues (datahub-project#10924)

* fix(build): fix lint fix web react (datahub-project#10896)

* fix(ingest/bigquery): handle quota exceeded for project.list requests (datahub-project#10912)

* feat(ingest): report extractor failures more loudly (datahub-project#10908)

* feat(ingest/snowflake): integrate snowflake-queries into main source (datahub-project#10905)

* fix(ingest): fix docs build (datahub-project#10926)

* fix(ingest/snowflake): fix test connection (datahub-project#10927)

* fix(ingest/lookml): add view load failures to cache (datahub-project#10923)

* docs(slack) overhauled setup instructions and screenshots (datahub-project#10922)

Co-authored-by: John Joyce <john@acryl.io>

* fix(airflow): Add comma parsing of owners to DataJobs (datahub-project#10903)

* fix(entityservice): fix merging sideeffects (datahub-project#10937)

* feat(ingest): Support System Ingestion Sources, Show and hide system ingestion sources with Command-S (datahub-project#10938)

Co-authored-by: John Joyce <john@Johns-MBP.lan>

* chore() Set a default lineage filtering end time on backend when a start time is present (datahub-project#10925)

Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal>
Co-authored-by: John Joyce <john@Johns-MBP.lan>

* Added relationships APIs to V3. Added these generic APIs to V3 swagger doc. (datahub-project#10939)

* docs: add learning center to docs (datahub-project#10921)

* doc: Update hubspot form id (datahub-project#10943)

* chore(airflow): add python 3.11 w/ Airflow 2.9 to CI (datahub-project#10941)

* fix(ingest/Glue): column upstream lineage between S3 and Glue (datahub-project#10895)

* fix(ingest/abs): split abs utils into multiple files (datahub-project#10945)

* doc(ingest/looker): fix doc for sql parsing documentation (datahub-project#10883)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* fix(ingest/bigquery): Adding missing BigQuery types (datahub-project#10950)

* fix(ingest/setup): feast and abs source setup (datahub-project#10951)

* fix(connections) Harden adding /gms to connections in backend (datahub-project#10942)

* feat(siblings) Add flag to prevent combining siblings in the UI (datahub-project#10952)

* fix(docs): make graphql doc gen more automated (datahub-project#10953)

* feat(ingest/athena): Add option for Athena partitioned profiling (datahub-project#10723)

* fix(spark-lineage): default timeout for future responses (datahub-project#10947)

* feat(datajob/flow): add environment filter using info aspects (datahub-project#10814)

* fix(ui/ingest): correct privilege used to show tab (datahub-project#10483)

Co-authored-by: Kunal-kankriya <127090035+Kunal-kankriya@users.noreply.github.com>

* feat(ingest/looker): include dashboard urns in browse v2 (datahub-project#10955)

* add a structured type to batchGet in OpenAPI V3 spec (datahub-project#10956)

* fix(ui): scroll on the domain sidebar to show all domains (datahub-project#10966)

* fix(ingest/sagemaker): resolve incorrect variable assignment for SageMaker API call (datahub-project#10965)

* fix(airflow/build): Pinning mypy (datahub-project#10972)

* Fixed a bug where the OpenAPI V3 spec was incorrect. The bug was introduced in datahub-project#10939. (datahub-project#10974)

* fix(ingest/test): Fix for mssql integration tests (datahub-project#10978)

* fix(entity-service) exist check correctly extracts status (datahub-project#10973)

* fix(structuredProps) casing bug in StructuredPropertiesValidator (datahub-project#10982)

* bugfix: use anyOf instead of allOf when creating references in openapi v3 spec (datahub-project#10986)

* fix(ui): Remove ant less imports (datahub-project#10988)

* feat(ingest/graph): Add get_results_by_filter to DataHubGraph (datahub-project#10987)

* feat(ingest/cli): init does not actually support environment variables (datahub-project#10989)

* fix(ingest/graph): Update get_results_by_filter graphql query (datahub-project#10991)

* feat(ingest/spark): Promote beta plugin (datahub-project#10881)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* feat(ingest): support domains in meta -> "datahub" section (datahub-project#10967)

* feat(ingest): add `check server-config` command (datahub-project#10990)

* feat(cli): Make consistent use of DataHubGraphClientConfig (datahub-project#10466)

Deprecates get_url_and_token() in favor of a more complete option: load_graph_config() that returns a full DatahubClientConfig.
This change was then propagated across previous usages of get_url_and_token so that connections to DataHub server from the client respect the full breadth of configuration specified by DatahubClientConfig.

I.e: You can now specify disable_ssl_verification: true in your ~/.datahubenv file so that all cli functions to the server work when ssl certification is disabled.

Fixes datahub-project#9705

* fix(ingest/s3): Fixing container creation when there is no folder in path (datahub-project#10993)

* fix(ingest/looker): support platform instance for dashboards & charts (datahub-project#10771)

* feat(ingest/bigquery): improve handling of information schema in sql parser (datahub-project#10985)

* feat(ingest): improve `ingest deploy` command (datahub-project#10944)

* fix(backend): allow excluding soft-deleted entities in relationship-queries; exclude soft-deleted members of groups (datahub-project#10920)

- allow excluding soft-deleted entities in relationship-queries
- exclude soft-deleted members of groups

* fix(ingest/looker): downgrade missing chart type log level (datahub-project#10996)

* doc(acryl-cloud): release docs for 0.3.4.x (datahub-project#10984)

Co-authored-by: John Joyce <john@acryl.io>
Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Pedro Silva <pedro@acryl.io>

* fix(protobuf/build): Fix protobuf check jar script (datahub-project#11006)

* fix(ui/ingest): Support invalid cron jobs (datahub-project#10998)

* fix(ingest): fix graph config loading (datahub-project#11002)

Co-authored-by: Pedro Silva <pedro@acryl.io>

* feat(docs): Document __DATAHUB_TO_FILE_ directive (datahub-project#10968)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* fix(graphql/upsertIngestionSource): Validate cron schedule; parse error in CLI (datahub-project#11011)

* feat(ece): support custom ownership type urns in ECE generation (datahub-project#10999)

* feat(assertion-v2): changed Validation tab to Quality and created new Governance tab (datahub-project#10935)

* fix(ingestion/glue): Add support for missing config options for profiling in Glue (datahub-project#10858)

* feat(propagation): Add models for schema field docs, tags, terms (datahub-project#2959) (datahub-project#11016)

Co-authored-by: Chris Collins <chriscollins3456@gmail.com>

* docs: standardize terminology to DataHub Cloud (datahub-project#11003)

* fix(ingestion/transformer): replace the externalUrl container (datahub-project#11013)

* docs(slack) troubleshoot docs (datahub-project#11014)

* feat(propagation): Add graphql API (datahub-project#11030)

Co-authored-by: Chris Collins <chriscollins3456@gmail.com>

* feat(propagation):  Add models for Action feature settings (datahub-project#11029)

* docs(custom properties): Remove duplicate from sidebar (datahub-project#11033)

* feat(models): Introducing Dataset Partitions Aspect (datahub-project#10997)

Co-authored-by: John Joyce <john@Johns-MBP.lan>
Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal>

* feat(propagation): Add Documentation Propagation Settings (datahub-project#11038)

* fix(models): chart schema fields mapping, add dataHubAction entity, t… (datahub-project#11040)

* fix(ci): smoke test lint failures (datahub-project#11044)

* docs: fix learning center color scheme & typo (datahub-project#11043)

* feat: add cloud main page (datahub-project#11017)

Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com>

* feat(restore-indices): add additional step to also clear system metadata service (datahub-project#10662)

Co-authored-by: John Joyce <john@acryl.io>

* docs: fix typo (datahub-project#11046)

* fix(lint): apply spotless (datahub-project#11050)

* docs(airflow): example query to get datajobs for a dataflow (datahub-project#11034)

* feat(cli): Add run-id option to put sub-command (datahub-project#11023)

Adds an option to assign run-id to a given put command execution. 
This is useful when transformers do not exist for a given ingestion payload, we can follow up with custom metadata and assign it to an ingestion pipeline.

* fix(ingest): improve sql error reporting calls (datahub-project#11025)

* fix(airflow): fix CI setup (datahub-project#11031)

* feat(ingest/dbt): add experimental `prefer_sql_parser_lineage` flag (datahub-project#11039)

* fix(ingestion/lookml): enable stack-trace in lookml logs (datahub-project#10971)

* (chore): Linting fix (datahub-project#11015)

* chore(ci): update deprecated github actions (datahub-project#10977)

* Fix ALB configuration example (datahub-project#10981)

* chore(ingestion-base): bump base image packages (datahub-project#11053)

* feat(cli): Trim report of dataHubExecutionRequestResult to max GMS size (datahub-project#11051)

* fix(ingestion/lookml): emit dummy sql condition for lookml custom condition tag (datahub-project#11008)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* fix(ingestion/powerbi): fix issue with broken report lineage (datahub-project#10910)

* feat(ingest/tableau): add retry on timeout (datahub-project#10995)

* change generate kafka connect properties from env (datahub-project#10545)

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>

* fix(ingest): fix oracle cronjob ingestion (datahub-project#11001)

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>

* chore(ci): revert update deprecated github actions (datahub-project#10977) (datahub-project#11062)

* feat(ingest/dbt-cloud): update metadata_endpoint inference (datahub-project#11041)

* build: Reduce size of datahub-frontend-react image by 50-ish% (datahub-project#10878)

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>

* fix(ci): Fix lint issue in datahub_ingestion_run_summary_provider.py (datahub-project#11063)

* docs(ingest): update developing-a-transformer.md (datahub-project#11019)

* feat(search-test): update search tests from datahub-project#10408 (datahub-project#11056)

* feat(cli): add aspects parameter to DataHubGraph.get_entity_semityped (datahub-project#11009)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* docs(airflow): update min version for plugin v2 (datahub-project#11065)

* doc(ingestion/tableau): doc update for derived permission (datahub-project#11054)

Co-authored-by: Pedro Silva <pedro.cls93@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* fix(py): remove dep on types-pkg_resources (datahub-project#11076)

* feat(ingest/mode): add option to exclude restricted (datahub-project#11081)

* fix(ingest): set lastObserved in sdk when unset (datahub-project#11071)

* doc(ingest): Update capabilities (datahub-project#11072)

* chore(vulnerability): Log Injection (datahub-project#11090)

* chore(vulnerability): Information exposure through a stack trace (datahub-project#11091)

* chore(vulnerability): Comparison of narrow type with wide type in loop condition (datahub-project#11089)

* chore(vulnerability): Insertion of sensitive information into log files (datahub-project#11088)

* chore(vulnerability): Risky Cryptographic Algorithm (datahub-project#11059)

* chore(vulnerability): Overly permissive regex range (datahub-project#11061)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* fix: update customer data (datahub-project#11075)

* fix(models): fixing the datasetPartition models (datahub-project#11085)

Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal>

* fix(ui): Adding view, forms GraphQL query, remove showing a fallback error message on unhandled GraphQL error (datahub-project#11084)

Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal>

* feat(docs-site): hiding learn more from cloud page (datahub-project#11097)

* fix(docs): Add correct usage of orFilters in search API docs (datahub-project#11082)

Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com>

* fix(ingest/mode): Regexp in mode name matcher didn't allow underscore (datahub-project#11098)

* docs: Refactor customer stories section (datahub-project#10869)

Co-authored-by: Jeff Merrick <jeff@wireform.io>

* fix(release): fix full/slim suffix on tag (datahub-project#11087)

* feat(config): support alternate hashing algorithm for doc id (datahub-project#10423)

Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
Co-authored-by: John Joyce <john@acryl.io>

* fix(emitter): fix typo in get method of java kafka emitter (datahub-project#11007)

* fix(ingest): use correct native data type in all SQLAlchemy sources by compiling data type using dialect (datahub-project#10898)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* chore: Update contributors list in PR labeler (datahub-project#11105)

* feat(ingest): tweak stale entity removal messaging (datahub-project#11064)

* fix(ingestion): enforce lastObserved timestamps in SystemMetadata (datahub-project#11104)

* fix(ingest/powerbi): fix broken lineage between chart and dataset (datahub-project#11080)

* feat(ingest/lookml): CLL support for sql set in sql_table_name attribute of lookml view (datahub-project#11069)

* docs: update graphql docs on forms & structured properties (datahub-project#11100)

* test(search): search openAPI v3 test (datahub-project#11049)

* fix(ingest/tableau): prevent empty site content urls (datahub-project#11057)

Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>

* feat(entity-client): implement client batch interface (datahub-project#11106)

* fix(snowflake): avoid reporting warnings/info for sys tables (datahub-project#11114)

* fix(ingest): downgrade column type mapping warning to info (datahub-project#11115)

* feat(api): add AuditStamp to the V3 API entity/aspect response (datahub-project#11118)

* fix(ingest/redshift): replace r'\n' with '\n' to avoid token error redshift serverless… (datahub-project#11111)

* fix(entiy-client): handle null entityUrn case for restli (datahub-project#11122)

* fix(sql-parser): prevent bad urns from alter table lineage (datahub-project#11092)

* fix(ingest/bigquery): use small batch size if use_tables_list_query_v2 is set (datahub-project#11121)

* fix(graphql): add missing entities to EntityTypeMapper and EntityTypeUrnMapper (datahub-project#10366)

* feat(ui): Changes to allow editable dataset name (datahub-project#10608)

Co-authored-by: Jay Kadambi <jayasimhan_venkatadri@optum.com>

* fix: remove saxo (datahub-project#11127)

* feat(mcl-processor): Update mcl processor hooks (datahub-project#11134)

* fix(openapi): fix openapi v2 endpoints & v3 documentation update

* Revert "fix(openapi): fix openapi v2 endpoints & v3 documentation update"

This reverts commit 573c1cb.

* docs(policies): updates to policies documentation (datahub-project#11073)

* fix(openapi): fix openapi v2 and v3 docs update (datahub-project#11139)

* feat(auth): grant type and acr values custom oidc parameters support (datahub-project#11116)

* fix(mutator): mutator hook fixes (datahub-project#11140)

* feat(search): support sorting on multiple fields (datahub-project#10775)

* feat(ingest): various logging improvements (datahub-project#11126)

* fix(ingestion/lookml): fix for sql parsing error (datahub-project#11079)

Co-authored-by: Harshal Sheth <hsheth2@gmail.com>

* feat(docs-site) cloud page spacing and content polishes (datahub-project#11141)

* feat(ui) Enable editing structured props on fields (datahub-project#11042)

* feat(tests): add md5 and last computed to testResult model (datahub-project#11117)

* test(openapi): openapi regression smoke tests (datahub-project#11143)

* fix(airflow): fix tox tests + update docs (datahub-project#11125)

* docs: add chime to adoption stories (datahub-project#11142)

* fix(ingest/databricks): Updating code to work with Databricks sdk 0.30 (datahub-project#11158)

* fix(kafka-setup): add missing script to image (datahub-project#11190)

* fix(config): fix hash algo config (datahub-project#11191)

* test(smoke-test): updates to smoke-tests (datahub-project#11152)

* fix(elasticsearch): refactor idHashAlgo setting (datahub-project#11193)

* chore(kafka): kafka version bump (datahub-project#11211)

* readd UsageStatsWorkUnit

* fix merge problems

* change logo

---------

Co-authored-by: Chris Collins <chriscollins3456@gmail.com>
Co-authored-by: John Joyce <john@acryl.io>
Co-authored-by: John Joyce <john@Johns-MBP.lan>
Co-authored-by: John Joyce <john@ip-192-168-1-200.us-west-2.compute.internal>
Co-authored-by: dushayntAW <158567391+dushayntAW@users.noreply.github.com>
Co-authored-by: sagar-salvi-apptware <159135491+sagar-salvi-apptware@users.noreply.github.com>
Co-authored-by: Aseem Bansal <asmbansal2@gmail.com>
Co-authored-by: Kevin Chun <kevin1chun@gmail.com>
Co-authored-by: jordanjeremy <72943478+jordanjeremy@users.noreply.github.com>
Co-authored-by: skrydal <piotr.skrydalewicz@gmail.com>
Co-authored-by: Harshal Sheth <hsheth2@gmail.com>
Co-authored-by: david-leifker <114954101+david-leifker@users.noreply.github.com>
Co-authored-by: sid-acryl <155424659+sid-acryl@users.noreply.github.com>
Co-authored-by: Julien Jehannet <80408664+aviv-julienjehannet@users.noreply.github.com>
Co-authored-by: Hendrik Richert <github@richert.li>
Co-authored-by: Hendrik Richert <hendrik.richert@swisscom.com>
Co-authored-by: RyanHolstien <RyanHolstien@users.noreply.github.com>
Co-authored-by: Felix Lüdin <13187726+Masterchen09@users.noreply.github.com>
Co-authored-by: Pirry <158024088+chardaway@users.noreply.github.com>
Co-authored-by: Hyejin Yoon <0327jane@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: cburroughs <chris.burroughs@gmail.com>
Co-authored-by: ksrinath <ksrinath@users.noreply.github.com>
Co-authored-by: Mayuri Nehate <33225191+mayurinehate@users.noreply.github.com>
Co-authored-by: Kunal-kankriya <127090035+Kunal-kankriya@users.noreply.github.com>
Co-authored-by: Shirshanka Das <shirshanka@apache.org>
Co-authored-by: ipolding-cais <155455744+ipolding-cais@users.noreply.github.com>
Co-authored-by: Tamas Nemeth <treff7es@gmail.com>
Co-authored-by: Shubham Jagtap <132359390+shubhamjagtap639@users.noreply.github.com>
Co-authored-by: haeniya <yanik.haeni@gmail.com>
Co-authored-by: Yanik Häni <Yanik.Haeni1@swisscom.com>
Co-authored-by: Gabe Lyons <itsgabelyons@gmail.com>
Co-authored-by: Gabe Lyons <gabe.lyons@acryl.io>
Co-authored-by: 808OVADOZE <52988741+shtephlee@users.noreply.github.com>
Co-authored-by: noggi <anton.kuraev@acryl.io>
Co-authored-by: Nicholas Pena <npena@foursquare.com>
Co-authored-by: Jay <159848059+jayacryl@users.noreply.github.com>
Co-authored-by: ethan-cartwright <ethan.cartwright.m@gmail.com>
Co-authored-by: Ethan Cartwright <ethan.cartwright@acryl.io>
Co-authored-by: Nadav Gross <33874964+nadavgross@users.noreply.github.com>
Co-authored-by: Patrick Franco Braz <patrickfbraz@poli.ufrj.br>
Co-authored-by: pie1nthesky <39328908+pie1nthesky@users.noreply.github.com>
Co-authored-by: Joel Pinto Mata (KPN-DSH-DEX team) <130968841+joelmataKPN@users.noreply.github.com>
Co-authored-by: Ellie O'Neil <110510035+eboneil@users.noreply.github.com>
Co-authored-by: Ajoy Majumdar <ajoymajumdar@hotmail.com>
Co-authored-by: deepgarg-visa <149145061+deepgarg-visa@users.noreply.github.com>
Co-authored-by: Tristan Heisler <tristankheisler@gmail.com>
Co-authored-by: Andrew Sikowitz <andrew.sikowitz@acryl.io>
Co-authored-by: Davi Arnaut <davi.arnaut@acryl.io>
Co-authored-by: Pedro Silva <pedro@acryl.io>
Co-authored-by: amit-apptware <132869468+amit-apptware@users.noreply.github.com>
Co-authored-by: Sam Black <sam.black@acryl.io>
Co-authored-by: Raj Tekal <varadaraj_tekal@optum.com>
Co-authored-by: Steffen Grohsschmiedt <gitbhub@steffeng.eu>
Co-authored-by: jaegwon.seo <162448493+wornjs@users.noreply.github.com>
Co-authored-by: Renan F. Lima <51028757+lima-renan@users.noreply.github.com>
Co-authored-by: Matt Exchange <xkollar@users.noreply.github.com>
Co-authored-by: Jonny Dixon <45681293+acrylJonny@users.noreply.github.com>
Co-authored-by: Pedro Silva <pedro.cls93@gmail.com>
Co-authored-by: Pinaki Bhattacharjee <pinakipb2@gmail.com>
Co-authored-by: Jeff Merrick <jeff@wireform.io>
Co-authored-by: skrydal <piotr.skrydalewicz@acryl.io>
Co-authored-by: AndreasHegerNuritas <163423418+AndreasHegerNuritas@users.noreply.github.com>
Co-authored-by: jayasimhankv <145704974+jayasimhankv@users.noreply.github.com>
Co-authored-by: Jay Kadambi <jayasimhan_venkatadri@optum.com>
Co-authored-by: David Leifker <david.leifker@acryl.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and Improvements to docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants