connection/jobs table update: track server connid, add user/id to jobs table #308

ixcat · 2020-10-30T21:14:41Z

to fix issue #87, #275 (add user/server connection to jobs table).

ideally, connection ID would be directly available via MyM; for the moment,
hack in a query to retrieve connection ID on connection and use this for
jobs table logging.

supersedes: #276

addresses: #276 (comment):

r.e. recurse: adjust to direct mym calls
r.e. indexing: feature too new, save ref and index that

status/remaining:

base functionality
unit test

… foreign key attributes.

Add options for foreign key attributes

Pull out assert outside of the loop

Update test comment to reflect open issue

…s table to fix issue #87, #275 (add user/server connection to jobs table). ideally, connection ID would be directly available via MyM; for the moment, hack in a query to retrieve connection ID on connection and use this for jobs table logging.

guzman-raphael · 2020-10-30T21:20:17Z

@ixcat You will need to target a stage-external-storage* like branch first in order for the tests to work properly. Can you create another branch, e.g. stage-external-storage2 since the current stage is already being used fro #303?

ixcat · 2020-10-30T21:29:30Z

ah right, got confused. will readjust.

…ssue-87-ext2

Add options for foreign key attributes

…7-ext2

TestPopulate currently tests 2x populate calls - - 1x in regular populate mode - in this case, SessionAnalysis logs the session_id as the 'session_analysis' field - 1x in paralell populate mode - in this case, SessionAnalysis logs the job key from the jobs table as the 'session_analysis' field

guzman-raphael

Looking good! Thanks for getting this test case together; I like it 😄.
Only a few minor nits on comment docs. Not necessary to implement exactly my suggestion but just looking to maintain some consistency.

+dj/+internal/AutoPopulate.m

+dj/Connection.m

+dj/conn.m

guzman-raphael and others added 7 commits October 30, 2020 15:10

Add support for nullable nonprimary key attributes and unique for all…

7bfefd7

… foreign key attributes.

Merge pull request #302 from guzman-raphael/fix-null-index-fks

e636334

Add options for foreign key attributes

Pull out assert outside of the loop.

ec0799b

Merge pull request #304 from guzman-raphael/fix-null-index-fks

ff91556

Pull out assert outside of the loop

Update test comment to reflect open issue.

1be18d5

Merge pull request #306 from guzman-raphael/fix-null-index-fks

5a9df6d

Update test comment to reflect open issue

ixcat mentioned this pull request Oct 30, 2020

connection/jobs table update: track server connid, add user/id to jobs table #276

Closed

ixcat changed the base branch from external-storage to stage-external-storage-jobid October 30, 2020 21:33

ixcat and others added 5 commits October 30, 2020 17:03

Merge remote-tracking branch 'upstream/stage-external-storage' into i…

2d1b490

…ssue-87-ext2

Merge pull request #303 from datajoint/stage-external-storage

508f0d1

Add options for foreign key attributes

Merge remote-tracking branch 'upstream/external-storage' into issue-8…

e6039c2

…7-ext2

./+dj/Connection.m: set serverId as uint64

c779cea

ixcat marked this pull request as ready for review November 7, 2020 19:25

dimitri-yatsenko approved these changes Nov 8, 2020

View reviewed changes

guzman-raphael requested changes Nov 12, 2020

View reviewed changes

+dj/+internal/AutoPopulate.m Outdated Show resolved Hide resolved

+dj/+internal/AutoPopulate.m Outdated Show resolved Hide resolved

+dj/Connection.m Outdated Show resolved Hide resolved

+dj/conn.m Outdated Show resolved Hide resolved

incorporate connection id naming from @guzman-raphael

5a383fb

guzman-raphael approved these changes Nov 27, 2020

View reviewed changes

guzman-raphael merged commit c92cff0 into datajoint:stage-external-storage-jobid Nov 27, 2020

guzman-raphael mentioned this pull request Nov 27, 2020

Stage -> External Storage #314

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

connection/jobs table update: track server connid, add user/id to jobs table #308

connection/jobs table update: track server connid, add user/id to jobs table #308

ixcat commented Oct 30, 2020 •

edited

Loading

guzman-raphael commented Oct 30, 2020

ixcat commented Oct 30, 2020

guzman-raphael left a comment

connection/jobs table update: track server connid, add user/id to jobs table #308

connection/jobs table update: track server connid, add user/id to jobs table #308

Conversation

ixcat commented Oct 30, 2020 • edited Loading

guzman-raphael commented Oct 30, 2020

ixcat commented Oct 30, 2020

guzman-raphael left a comment

Choose a reason for hiding this comment

ixcat commented Oct 30, 2020 •

edited

Loading