Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit log #7

Closed
simonw opened this issue Aug 30, 2024 · 3 comments
Closed

Audit log #7

simonw opened this issue Aug 30, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Contributor

simonw commented Aug 30, 2024

Record who made what changes to ACLs and when.

I can display this on the bottom of the table page from #4 (and then in other places too later on).

@simonw simonw added the enhancement New feature or request label Aug 30, 2024
@simonw
Copy link
Contributor Author

simonw commented Aug 31, 2024

@simonw
Copy link
Contributor Author

simonw commented Aug 31, 2024

Ran this:

files-to-prompt datasette_acl/__init__.py datasette_acl/templates/table_acls.html | llm --system 'Suggest changes to add an Audit history list at the bottom of the table_acls page showing all changes made to that table in the past' -m claude-3.5-sonnet

Result: https://gist.github.com/simonw/de11a5f38cc580872a8a478f3d7fe6be

simonw added a commit that referenced this issue Aug 31, 2024
@simonw
Copy link
Contributor Author

simonw commented Aug 31, 2024

This will do for the moment:

CleanShot 2024-08-30 at 18 21 58@2x

It cuts off at 50 items. It would be neat to be able to link to a full paginated/faceted/filtered view of the entire audit log for viewing beyond 50. That's tricky as the table is in an internal database, but it would be neat to figure out a way to do that.

@simonw simonw closed this as completed Aug 31, 2024
simonw added a commit that referenced this issue Aug 31, 2024
@simonw simonw added this to the Feature complete milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant