Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage user permissions for the table #9

Closed
simonw opened this issue Aug 31, 2024 · 4 comments
Closed

Manage user permissions for the table #9

simonw opened this issue Aug 31, 2024 · 4 comments
Labels
enhancement New feature or request
Milestone
Feature complete

Comments

@simonw
Copy link
Contributor

simonw commented Aug 31, 2024

No we have user permissions from:

I'm going to add the ability to set them on the table page.
@simonw simonw added the enhancement New feature or request label Aug 31, 2024
@datasette datasette deleted a comment Aug 31, 2024
@simonw
Copy link
Contributor Author

simonw commented Aug 31, 2024

Initial attempt at a UI - doesn't quite work yet:

CleanShot 2024-08-30 at 23 10 10@2x

@simonw
Copy link
Contributor Author

simonw commented Aug 31, 2024

Got it working:

users

@simonw
Copy link
Contributor Author

simonw commented Aug 31, 2024

Needs tests and docs.

simonw added a commit that referenced this issue Aug 31, 2024
@simonw
UI for managing user permissions and adding new users, refs #9
10fc72a
simonw added a commit that referenced this issue Aug 31, 2024
@simonw
Update messages tests, broke tests for #9
53ec8de
simonw added a commit that referenced this issue Aug 31, 2024
@simonw
Finish refactor to use paramaterized tests, refs #9
b03b985
simonw added a commit that referenced this issue Aug 31, 2024
@simonw
Skip the dynamic groups OneSecondCache if running under pytest
8ac74d8 
This was causing weird test failures where a second test didn't work because it failed
to re-populate the dynamic groups ACL thanks to the 1 second cache. Refs #9
simonw added a commit that referenced this issue Aug 31, 2024
@simonw
More tests, including first user permissions test - refs #9
ea0e092
simonw referenced this issue in simonw/til Aug 31, 2024
@simonw
Using namedtuple for pytest parameterized tests
0f04937
simonw added a commit that referenced this issue Aug 31, 2024
@simonw
Test for editing existing user, refs #9
54ed941
@simonw simonw closed this as completed in 9bdd47f Aug 31, 2024
@simonw
Copy link
Contributor Author

simonw commented Aug 31, 2024

Wrote a TIL about the test pattern I am using: https://til.simonwillison.net/pytest/namedtuple-parameterized-tests

simonw added a commit that referenced this issue Aug 31, 2024
@simonw
Release 0.2a0
31e8d98 
Refs #7, #8, #9
@simonw simonw added this to the Feature complete milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
Feature complete
Development

No branches or pull requests
1 participant
@simonw