Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle failures - to avoid long runs that break and then all compute time is lost #31

Open
DBCerigo opened this issue Oct 7, 2021 · 1 comment

Comments

@DBCerigo
Copy link
Contributor

DBCerigo commented Oct 7, 2021

Currently, the run loop runs all model-validation combinations and stores the result in memory and once all complete it then writes all the result to file. If a model-validation combination breaks, then whole loop breaks, and all the prior model-validation combination results are lost, resulting in wasted compute + waiting time for those model-validation combinations.

We could try to implement a solution to this.

@alex-hh
Copy link
Contributor

alex-hh commented Oct 10, 2021

Another option would be to incrementally add lines to csvs, rather than building all the results and then saving? This could also remove the pandas dependency if that is not used elsewhere.

floracharbo added a commit to floracharbo/kotsu that referenced this issue Jun 12, 2022
Proposed solution to issue datavaluepeople#31

Save results immediately for each model-validation combination. If the code breaks before the end of the loops, the results can be recovered from the results file rather than re-computed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants