Save results gradually in run #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposed solution to issue datavaluepeople#31 Save results immediately for each model-validation combination. If the code breaks before the end of the loops, the results can be recovered from the results file rather than re-computed.
|
Nice 😸 Unit tests for it are the next task :) |
add the test_interruption_results_saving test in test_run.py this checks that all goes well in a scenario when the run fails before all results were saved, and the run is run again, recovering previously saved results.
Codecov Report
@@ Coverage Diff @@
## main #46 +/- ##
===========================================
+ Coverage 99.25% 100.00% +0.74%
===========================================
Files 6 6
Lines 134 136 +2
===========================================
+ Hits 133 136 +3
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed solution to issue #31
Save results immediately for each model-validation combination. If the code breaks before the end of the loops, the results can be recovered from the results file rather than re-computed.
I haven't, I will do if this PR is accepted :)