Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check compatibility of LineUp 4 string filter object with provenance graph #331

Closed
2 tasks
thinkh opened this issue Mar 25, 2020 · 2 comments
Closed
2 tasks
Assignees
Labels
priority: high type: technical debt Describes or removes a technical debt

Comments

@thinkh
Copy link
Member

thinkh commented Mar 25, 2020

With PR lineupjs/lineupjs#274 the return value of a string filter got formalized as IStringFilter. It is now possible to store if the user filtered the string column for missing values. The filter event that tdp_core listens will now return an IStringFilter.

We must check the following points:

@thinkh thinkh added type: technical debt Describes or removes a technical debt priority: high labels Mar 25, 2020
@thinkh thinkh self-assigned this Mar 25, 2020
@thinkh
Copy link
Member Author

thinkh commented Mar 25, 2020

The filter event of LineUp v3 and v4 before PR lineupjs/lineupjs#274 returns a string or a regexp (e.g., AB or /AB/gm).

LineUp v4 with PR lineupjs/lineupjs#274 returns the IStringFilter object (e.g., {filter: "AB", filterMissing: false}, {filter: /AB/gm, filterMissing: false}, or {filter: null, filterMissing: true}). Hence, we must handle these cases and remain backwards compatibility.

@thinkh
Copy link
Member Author

thinkh commented Mar 30, 2020

@oltionchampari Please continue my implementation in branch https://github.com/datavisyn/tdp_core/tree/thinkh/331_string-filter-compatibility

  • Extend the tests for restoreRegExp in cmds.test.ts so that they support all old AND the new filter interface
  • Refactor the restoreRegExp implementation
  • Apply the restoreRegExp only to filters in the setColumnImpl function

You can run the tests with npm run test:web:tdp_core from your workspace.

oltionchampari added a commit that referenced this issue Mar 31, 2020
oltionchampari added a commit that referenced this issue Mar 31, 2020
oltionchampari added a commit that referenced this issue Mar 31, 2020
regExp before turning it to  a string

#331
oltionchampari added a commit that referenced this issue Mar 31, 2020
oltionchampari added a commit that referenced this issue Mar 31, 2020
thinkh added a commit that referenced this issue Apr 3, 2020
@thinkh thinkh closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: technical debt Describes or removes a technical debt
Projects
None yet
Development

No branches or pull requests

2 participants