The ViewWrapper removes the HTML if the instance is destroyed and the visible state is kept

[lehnerchristian]

ViewWrapper deletes its own node from the DOM

The ViewWrapper class removes its own HTML node a detail view is mounted in when the instance is destroyed: https://github.com/datavisyn/tdp_core/blob/develop/src/base/ViewWrapper.ts#L209

The problem is that the node is only created when the ViewWrapper is initialized (see https://github.com/datavisyn/tdp_core/blob/develop/src/base/ViewWrapper.ts#L64), which is done differently in many apps, but generally speaking the ViewWrappers are instantiated when the detail view chooser is built

Visible state is kept when destroying the instance

A second related problem is that if the view is destroyed the ViewWrappers visible state is not set to false, which leads to the bug that if the ViewWrapper instance is destroyed and the main ranking view in an application is clicked that suddenly a detail view is instantiated without choosing a view from the detail view chooser. in the following example matches && this.visible is true although visible should be false when the instance was destroyed:
see https://github.com/datavisyn/tdp_core/blob/develop/src/base/ViewWrapper.ts#L298-L300

[lehnerchristian]

we agreed that the node should be removed when the destroy method is invoked, because that is what is expected. so closing this ticket