Avoid deleting the HTML node when destroying ViewWrapper instance and set visible state correctly

[lehnerchristian]

ViewWrapper deletes its own node from the DOM

for a description, please see the linked ticket

please test this behavior in your applications if it has any side-effects.

but as far as I can see it shouldn't. the current behavior of our detail views is that the ViewWrapper instances are created once and then the detail views are only shown and hidden via a CSS class.

but node of those instances should not be deleted, because the ViewWrapper class is only instantiated when the detail view chooser is built.

as far as I can see the destroy method of the ViewWrapper class was never called in the projects I have set up locally

Edit:

another option would be to insert the HTML node again into the DOM, because we still have the reference to it in this.node

Visible state is kept when destroying the instance

by setting the visible attribute of the ViewWrapper instance back to false we avoid recrating a view when we click on the centra LineUp table. see https://github.com/datavisyn/tdp_core/blob/develop/src/base/ViewWrapper.ts#L298-L300

[lehnerchristian]

I've close #336 , because we agreed on destroying the ViewWrapper should of course actually delete the HTML node.

New Description:

The actual problem was that when the visible setter is called on a ViewWrapper instance the update method is invoked.

The update method checked if the instance is actually available and && this.node.getBoundingClientRect().width > 0 which not true in this case.

the size of the node depends on the active CSS class of the HTML element the detail views are in, which is set from the outside and currently app specific as it looks to me.

however if this check is present my React view does not render correctly as it is not updated anymore

@thinkh , @puehringer and @dg-datavisyn , please re-review and check with your apps

[thinkh]

This change does not affect Ordino, since Ordino uses its own ViewWrapper class ... (see Caleydo/ordino). Hence, I will approve this change.