Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create extension point to connect the touring panel/Refactor LineupSidePanel #285

Merged
merged 71 commits into from
Mar 13, 2020

Conversation

oltionchampari
Copy link
Contributor

@oltionchampari oltionchampari commented Jan 9, 2020

Closes #257

Developer documentation:
https://wiki.datavisyn.io/tdp/tutorials/lineup-panel/lineup-side-panel
https://wiki.datavisyn.io/tdp/tutorials/lineup-panel/how-to-add-line-up-panel-tab
https://wiki.datavisyn.io/tdp/tutorials/lineup-panel/how-to-add-a-new-tdp-ranking-button

Summary

  • Refactored and extracted the LineupSidePanel class into several different files to make it more scalable
  • Added tabbing functionality to the side panel in able to have different content inside of it
  • Created extension point to add further tabs to the side panel

paneltab

To register to the above extension point:

import { EP_TDP_CORE_LINEUP_PANEL_TAB, IPanelTabExtensionDesc } from 'tdp_core/src/extensions';

  registry.push(EP_TDP_CORE_LINEUP_PANEL_TAB, 'statisticalAnalysisPanel', function () {
    return System.import('./TouringPanel');
  }, <IPanelTabExtensionDesc>{
    cssClass: 'fa-calculator',
    title: 'Statistical Analysis',
    order: 10,
    width: '45em',
    shortcut: true
  });

Factory method name /entry point can be defined:

factory:'<my factory method>'

If not defined the default factory method name is

create() 

TODO

  • Test side panel in application where it is used in top mode

@oltionchampari oltionchampari added type: refactor Refactor the current implementation release: minor PR merge results in a new minor version labels Jan 9, 2020
@oltionchampari oltionchampari requested a review from thinkh January 9, 2020 07:06
@oltionchampari oltionchampari requested a review from thinkh March 3, 2020 13:12
@oltionchampari
Copy link
Contributor Author

I retested the side panel in patentbay in top mode again and it works as expected.

Prefer native JS functions if they offer the same functionality.
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oltionchampari Thanks for your recent changes! Now it looks good. 👍

@lehnerchristian Please review this PR. If you have questions please let us know. We can also schedule a meeting if you have more to discuss.

oltionchampari and others added 2 commits March 5, 2020 09:09
…m:datavisyn/tdp_core into ochampari/10_tourdino-lineup-panel-button
src/lineup/internal/LineUpPanelActions.ts Outdated Show resolved Hide resolved
src/lineup/internal/LineUpPanelActions.ts Outdated Show resolved Hide resolved
src/extensions.ts Outdated Show resolved Hide resolved
src/lineup/internal/panel/PanelTab.ts Outdated Show resolved Hide resolved
src/lineup/internal/panel/PanelTab.ts Outdated Show resolved Hide resolved
src/lineup/internal/panel/PanelTab.ts Outdated Show resolved Hide resolved
src/lineup/internal/panel/PanelTabContainer.ts Outdated Show resolved Hide resolved
src/lineup/internal/panel/SearchBoxProvider.ts Outdated Show resolved Hide resolved
@lehnerchristian
Copy link

lehnerchristian commented Mar 12, 2020

I have just some minor questions and some comments on typings / unused variables. the rest looks fine to me

src/lineup/internal/LineUpPanelActions.ts Outdated Show resolved Hide resolved
src/lineup/internal/LineUpPanelActions.ts Outdated Show resolved Hide resolved
src/lineup/internal/panel/PanelTab.ts Outdated Show resolved Hide resolved
src/lineup/internal/panel/PanelTab.ts Outdated Show resolved Hide resolved
src/lineup/internal/panel/PanelTabContainer.ts Outdated Show resolved Hide resolved
src/lineup/internal/panel/SearchBoxProvider.ts Outdated Show resolved Hide resolved
thinkh added 2 commits March 13, 2020 14:53
Remove PanelTabEvents and pass the PanelTab directly to the extension point to match other framework implementation.
oltionchampari and others added 4 commits March 13, 2020 16:30
…sion-point

Refactor PanelTab extension point
This change fits the "Ranking Configuration" tab and the "Statistical Analysis" tabs (tourdino) next to each other.
Before the the whole tdpView was scrolling when the content of the side panel was too long.

Now only the tab panel content ist scrolling, but the tabs and the header remain fixed.
@thinkh
Copy link
Member

thinkh commented Mar 13, 2020

@lehnerchristian Thanks for your valuable review. We addressed your comments with the last few commits. As we agreed eariler today in a call, I'm gonna merge the this PR even though you haven't revised it again.

@thinkh thinkh merged commit cfb32b7 into develop Mar 13, 2020
@thinkh thinkh deleted the ochampari/10_tourdino-lineup-panel-button branch March 13, 2020 19:06
@dvvanessastoiber dvvanessastoiber mentioned this pull request Mar 18, 2020
29 tasks
@ghost ghost mentioned this pull request Mar 19, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: minor PR merge results in a new minor version type: refactor Refactor the current implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants