-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create extension point to connect the touring panel/Refactor LineupSidePanel #285
Conversation
The parameter are unused in the class and can be removed.
I retested the side panel in patentbay in top mode again and it works as expected. |
Prefer native JS functions if they offer the same functionality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oltionchampari Thanks for your recent changes! Now it looks good. 👍
@lehnerchristian Please review this PR. If you have questions please let us know. We can also schedule a meeting if you have more to discuss.
…m:datavisyn/tdp_core into ochampari/10_tourdino-lineup-panel-button
…ino-lineup-panel-button
I have just some minor questions and some comments on typings / unused variables. the rest looks fine to me |
to innerHTML() #257
…ino-lineup-panel-button
Remove PanelTabEvents and pass the PanelTab directly to the extension point to match other framework implementation.
…sion-point Refactor PanelTab extension point
This change fits the "Ranking Configuration" tab and the "Statistical Analysis" tabs (tourdino) next to each other.
Before the the whole tdpView was scrolling when the content of the side panel was too long. Now only the tab panel content ist scrolling, but the tabs and the header remain fixed.
@lehnerchristian Thanks for your valuable review. We addressed your comments with the last few commits. As we agreed eariler today in a call, I'm gonna merge the this PR even though you haven't revised it again. |
Closes #257
Developer documentation:
https://wiki.datavisyn.io/tdp/tutorials/lineup-panel/lineup-side-panel
https://wiki.datavisyn.io/tdp/tutorials/lineup-panel/how-to-add-line-up-panel-tab
https://wiki.datavisyn.io/tdp/tutorials/lineup-panel/how-to-add-a-new-tdp-ranking-button
Summary
To register to the above extension point:
Factory method name /entry point can be defined:
factory:'<my factory method>'
If not defined the default factory method name is
TODO