Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor PanelTab extension point #319

Merged
merged 1 commit into from
Mar 13, 2020
Merged

Refactor PanelTab extension point #319

merged 1 commit into from
Mar 13, 2020

Conversation

thinkh
Copy link
Member

@thinkh thinkh commented Mar 13, 2020

Remove PanelTabEvents and pass the PanelTab directly to the extension point to match other framework implementation (as suggested by @lehnerchristian in #285 (comment))

@thinkh
Refactor PanelTab EP
e5d204e 
Remove PanelTabEvents and pass the PanelTab directly to the extension point to match other framework implementation.
@thinkh thinkh added type: refactor Refactor the current implementation release: minor PR merge results in a new minor version labels Mar 13, 2020
@thinkh thinkh requested a review from oltionchampari March 13, 2020 14:39
@thinkh thinkh requested a review from lehnerchristian as a code owner March 13, 2020 14:39
@thinkh thinkh mentioned this pull request Mar 13, 2020
Merged
oltionchampari
oltionchampari approved these changes Mar 13, 2020
View reviewed changes
Copy link
Contributor

@oltionchampari oltionchampari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks cleaner to me, and it works exactly the same.

@oltionchampari oltionchampari merged commit 8a2d8ad into ochampari/10_tourdino-lineup-panel-button Mar 13, 2020
@oltionchampari oltionchampari deleted the thinkh/refactor-paneltab-extension-point branch March 13, 2020 15:30
@dvvanessastoiber dvvanessastoiber mentioned this pull request Mar 18, 2020
Merged
29 tasks
@datavisyn-bot datavisyn-bot mentioned this pull request Mar 19, 2020
Closed
2 tasks
@ghost ghost mentioned this pull request Mar 19, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oltionchampari oltionchampari oltionchampari approved these changes

@lehnerchristian lehnerchristian Awaiting requested review from lehnerchristian

Assignees

@oltionchampari oltionchampari

Labels
release: minor PR merge results in a new minor version type: refactor Refactor the current implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thinkh @oltionchampari