Release 16.0.0 #778
Merged
Release 16.0.0 #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add optional `diffSubtypes` to `IMultiSelectionAdapter` - Remove `ReprovisynMultiSelectionAdapter` - Add generics to `MultiSelectionAdapter` - Comment functions of `MultiSelectionAdapter`
Unecessary convoluted call
- Add and refactor return types `Promise<any>` to `Promise<void>` - Switch to async/await where possible - await `removeDynamicColumns` before `addDynamicColumns` -> previously it was not waited for the removal
* Added build-storybook to build script * Add tdp_core/dist alias to the storybook webpack config * updated version of storybook (#736) Co-authored-by: Moritz Heckmann <moritz.heckmann@datavisyn.io> Co-authored-by: dvmoritzschoefl <77104411+dvmoritzschoefl@users.noreply.github.com> Co-authored-by: Moritz Heckmann <moritz.heckmann@datavisyn.io>
Probably a missing type cast in PR #729
Waiting for `this.built` will never resolve/terminate and show an infite loading icon. Reason: `this.built` is created with `build()` in line 355 and it is only resolved after the `build()` call is complete. With the changes to the selection adapter the `this.selectionAdapter.selectionChanged` now returns a valid promise. Previously, `context.add()` did not return it's promise (see 919cfb2#diff-f0f07e4a6ac30a813315b152545245d4cf26830e01b701f3e82ff7b5c22363a7R18). Now, we are waiting until all dynamic columns are added. The circle closes when we add the columns which calls `withoutTracking()` which in-turn is waiting for the resolved `this.built` promise. As far as I can see, we always call `withoutTracking` on a built/resolved ranking view. In the other places (line 377 and 400) we have a dedicated `await this.built;` before triggering changes to dynamic columns. In my tests adding and removing columns via score and selection adapter worked as before. I also tested reloading the page and checked the result of the session. In all cases it looks the same as before.
Bumps [pyjwt](https://github.com/jpadilla/pyjwt) from 2.1.0 to 2.4.0. - [Release notes](https://github.com/jpadilla/pyjwt/releases) - [Changelog](https://github.com/jpadilla/pyjwt/blob/master/CHANGELOG.rst) - [Commits](jpadilla/pyjwt@2.1.0...2.4.0) --- updated-dependencies: - dependency-name: pyjwt dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
* Add rdkit image to router (not working? ignoring prefix/namespace?) Add api to make rdkit produce SVGs Add optional extra flavor for rdkit in setup.py Add tests (working in a standalone project) Add models for molecule parsing Add utils for rdkit-stuff * Reformat + fix imports (via make format) Add prefix/namespace-functionality to visyn_server in the same way, flask has it Cleanup tests * Make tests not run if you don't have rdkit * Fix linter errors * Change tag from default (none) to images and change docstring (from "todo move" to actual) * Make rdkit mandatory * Remove router namespace support for fastapi and add warning if it's used Remove murcko wrapper Remove unneccesary fastapi object creation Remove create_api in img_api Add app via init_app instead of via registry * Changed path form /image/ to /rdkit/ Changed kind of parameters from url params to query params, i.e. /rdkit/C -> /rdkit/?structure=C due to slashes Adapted tests Better / more correct type hints * Change to return no content (+ proper no content response code) * Fix imports * Add structured image column, renderer, and filter dialog for SMILES strings to ranking (#755) * Add molecule column + renderer for LineUp #741 * Implement fetch structured image #741 * Add SMILES renderer and column to Ranking.tsx #741 * Adapt to latest rdkit API changes * Add custom structure image filter dialog (wip) * Add loading icon + error msg to filter dialog * Remove orphan import * Fix linter warnings and improve code * Deny to set string filter * Fix lint * Fix `filter = null` case * Rename folder to `structureImage` and add index.ts * Update dist files * Add empty summary renderer Otherwise an error is thrown when switching visualizations for the smiles column * Fix lint * Nest structured image i18n strings * Set default column width for smiles column * Set row height based on smiles column width * Set min/max domain for number col domain Related to #718 The parameter default, i.e. `min = Number.NaN`, is only used if the parameter is `undefined`. However, when the parameter is `null` it does not assign `Number.NaN`. With this commit `null` and `undefined` result in `Number.NaN`. * Set default summary renderer for smiles col * StructuredImageColumn extends ValueColumn - Removes all string related dialogs and functionality (e.g., group, sort, ...) - Add rename dialog - Remove `order` to default -> in menu: rename then filter Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io> Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com> * Minor improvements and feedback incorporation Co-authored-by: Holger Stitz <holger.stitz@datavisyn.io> Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io> Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
* Add test_db fixture * Reformatting * Simplify + fail better + test fixture * Fix weird import corner case * Fixed import order * Move test dev dependencies from requirements_dev to main, so things depending on core also have it. Also, mark both db-tests as xfail. Co-authored-by: Michael Puehringer <michael.puehringer@datavisyn.io> Co-authored-by: Michael Pühringer <51900829+puehringer@users.noreply.github.com>
ghost
approved these changes
Sep 8, 2022
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
evt.preventDefault()#772)Release dependencies first
In case of dependent Phovea/TDP repositories follow dependency tree from the top:
🏁 Finish line