Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TravisCI, CircleCI, GitlabCI, etc for checking PRs #14

Closed
engnadeau opened this issue Sep 27, 2018 · 2 comments
Closed

Use TravisCI, CircleCI, GitlabCI, etc for checking PRs #14

engnadeau opened this issue Sep 27, 2018 · 2 comments

Comments

@engnadeau
Copy link
Contributor

Feature request

  • Tests should be run by a CI service for every commit/PR
  • Only passing PRs should be merged
This was referenced Sep 27, 2018
Closed
Closed
@davidnsousa
Copy link
Owner

@nnadeau is this an obligate requirement for JOSS? The automated tests that I have created as required by JOSS can be run with the MATLAB tool runtests. And this is done manually every time before a new commit. But as far as I know this (MATALAB tests) cannot be done automatically in the cloud with these TravisCL-like tools.

davidnsousa added a commit that referenced this issue Sep 28, 2018
@davidnsousa
working on issues #10, #11 and #14
50c9d8a
davidnsousa added a commit that referenced this issue Sep 28, 2018
@davidnsousa
fixed issues #10, #11 and #14
f323ab8
davidnsousa added a commit that referenced this issue Sep 28, 2018
@davidnsousa
fixed issues #10, #11 and #14
9e4c52b
@davidnsousa
Copy link
Owner

@nnadeau I found how to do this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidnsousa @engnadeau