Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #65
This merge request will change the following things:
I was having some issues with my device with respect to publishing rates and it turned out it was related to #65. The issue was that it seems there are two different channels to get the device to send data asynchronously to the host:
vs.writeAsyncDataOutputFrequency(...)
and the output types withvs.writeAsyncDataOutputType(...)
. It can be turned off with0 == VNOFF
. If turned off the ouput frequency has no meaning (I removed the calls).BinaryOutputRegister
: The publish rate is defined as a fraction of the sensor imu rate. This will be delivered next to the async output.If both modes are configured, they will also be both delivered and can lead to higher rates than expected. The change I applied, is to reconfigure the device to not use async data output at all and only publish the data requested through the
BinaryOutputRegister
.