Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding commit hooks without running #147

Merged
merged 6 commits into from
Apr 8, 2022
Merged

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Mar 30, 2022

resolves #123 part 1

Description

Breaking up #124 into two PRs to split out review, pushing up pre-commit hooks/ new code additions.

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-bigquery next" section.

@cla-bot cla-bot bot added the cla:yes label Mar 30, 2022
@kwigley kwigley marked this pull request as ready for review April 8, 2022 18:26
Copy link
Contributor

@kwigley kwigley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, I had one requested change

.github/workflows/main.yml Outdated Show resolved Hide resolved
McKnight-42 and others added 2 commits April 8, 2022 13:32
* adding all code changes from black, pre-commit, mypy

* adding changelog

* new mypy ignores came up
@kwigley kwigley self-requested a review April 8, 2022 18:40
@McKnight-42 McKnight-42 merged commit ca38a82 into main Apr 8, 2022
@McKnight-42 McKnight-42 deleted the CT-241/add_precommit_hooks branch April 8, 2022 18:54
siephen pushed a commit to AgencyPMG/dbt-bigquery that referenced this pull request May 16, 2022
* adding commit hooks without running

* adding changelog entry

* adding mypy ignores

* adding final mypy ignores

* remove duplicate pip install

* adding all code changes from black, pre-commit, mypy (dbt-labs#148)

* adding all code changes from black, pre-commit, mypy

* adding changelog

* new mypy ignores came up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-241] Add black formatter and precommit hooks
2 participants