adding all code changes from black, pre-commit, mypy #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leahwicz
reviewed
Apr 4, 2022
dbt/adapters/bigquery/__init__.py
Outdated
| adapter=BigQueryAdapter, | ||
| credentials=BigQueryCredentials, | ||
| include_path=bigquery.PACKAGE_PATH) | ||
| adapter=BigQueryAdapter, credentials=BigQueryCredentials, include_path=bigquery.PACKAGE_PATH |
There was a problem hiding this comment.
@iknox-fa is this right where this is being consolidated to a single line? If it is, then cool. It just looks weird to me
…abs/dbt-bigquery into CT-241/code_format_changes
kwigley
approved these changes
Apr 8, 2022
McKnight-42
added a commit
that referenced
this pull request
Apr 8, 2022
* adding commit hooks without running * adding changelog entry * adding mypy ignores * adding final mypy ignores * remove duplicate pip install * adding all code changes from black, pre-commit, mypy (#148) * adding all code changes from black, pre-commit, mypy * adding changelog * new mypy ignores came up
siephen
pushed a commit
to AgencyPMG/dbt-bigquery
that referenced
this pull request
May 16, 2022
* adding commit hooks without running * adding changelog entry * adding mypy ignores * adding final mypy ignores * remove duplicate pip install * adding all code changes from black, pre-commit, mypy (dbt-labs#148) * adding all code changes from black, pre-commit, mypy * adding changelog * new mypy ignores came up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves # #124
Description
adds the code changes to pre-commit-black pr
Checklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.