-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add type boolean #313
add type boolean #313
Conversation
This is looking awesome @jpmmcneill ! Here's the next steps for this PR:
It will be the same process as above for dbt-redshift, dbt-snowflake, and dbt-spark. (Unfortunately, new tests aren't inherited and executed automatically -- they need to be added explicitly). Updating
|
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core | |
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter |
To this:
git+https://github.com/jpmmcneill/dbt-core.git@jpmmcneill/type-boolean#egg=dbt-core&subdirectory=core
git+https://github.com/jpmmcneill/dbt-core.git@jpmmcneill/type-boolean#egg=dbt-tests-adapter&subdirectory=tests/adapter
Then commit and push. CI in GitHub Actions should kick off here automatically.
@dbeatty10 thanks for the guides! This should be ready for a proper review now :) |
@jpmmcneill Now that dbt-labs/dbt-core#5875 has been merged, just two things and then this should be ready!
If all looks good after CI runs, then we'll merge. |
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
resolves #315
required for dbt-labs/dbt-core#5739
Description
dbt-bigquery patch as required for dbt-labs/dbt-core#5739 via dbt-labs/dbt-core#5875.
Checklist
changie new
to create a changelog entry