Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type boolean #313

Merged
merged 4 commits into from
Sep 22, 2022
Merged

add type boolean #313

merged 4 commits into from
Sep 22, 2022

Conversation

jpmmcneill
Copy link
Contributor

@jpmmcneill jpmmcneill commented Sep 18, 2022

resolves #315

required for dbt-labs/dbt-core#5739

Description

dbt-bigquery patch as required for dbt-labs/dbt-core#5739 via dbt-labs/dbt-core#5875.

Checklist

@dbeatty10
Copy link
Contributor

This is looking awesome @jpmmcneill !

Here's the next steps for this PR:

  1. Run changie new per these instructions and commit and push the resulting file.
  2. Commit and push a change to dev-requirements.txt for the purposes of CI via GitHub Actions (see "Updating dev-requirements.txt" below for more details)
    • Since we'll want your adapter branch to be using your dbt-core PR branch rather than the main branch of dbt-core
  3. Once all the PRs are passing CI and get approved, we'll merge the dbt-core PR first.
  4. Then you'll undo your changes to dev-requirements.txt (and commit and push) and we'll re-run the CI tests in GitHub.
  5. Once that is passing CI and gets approved, then it can be merged.

It will be the same process as above for dbt-redshift, dbt-snowflake, and dbt-spark. (Unfortunately, new tests aren't inherited and executed automatically -- they need to be added explicitly).

Updating dev-requirements.txt (temporarily)

Change these lines:

git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-core&subdirectory=core
git+https://github.com/dbt-labs/dbt-core.git#egg=dbt-tests-adapter&subdirectory=tests/adapter

To this:

git+https://github.com/jpmmcneill/dbt-core.git@jpmmcneill/type-boolean#egg=dbt-core&subdirectory=core
git+https://github.com/jpmmcneill/dbt-core.git@jpmmcneill/type-boolean#egg=dbt-tests-adapter&subdirectory=tests/adapter

Then commit and push. CI in GitHub Actions should kick off here automatically.

@jpmmcneill jpmmcneill marked this pull request as ready for review September 19, 2022 22:29
@jpmmcneill
Copy link
Contributor Author

@dbeatty10 thanks for the guides! This should be ready for a proper review now :)

@dbeatty10 dbeatty10 added Team:Adapters triage:ready-for-review Externally contributed PR has functional approval, ready for code review from Core engineering labels Sep 20, 2022
@dbeatty10
Copy link
Contributor

@jpmmcneill Now that dbt-labs/dbt-core#5875 has been merged, just two things and then this should be ready!

  1. Click the "update branch" button (or merge the latest changes from main some other way)
  2. Restore the original version of dbt-requirements.txt

If all looks good after CI runs, then we'll merge.

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
@dbeatty10 dbeatty10 merged commit 24a787f into dbt-labs:main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes triage:ready-for-review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1209] [Feature] Cross-database macro for type_boolean()
2 participants