Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add type boolean #313

Merged
merged 4 commits into from
Sep 22, 2022
Merged

add type boolean #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5259c7a
add type boolean
jpmmcneill Sep 18, 2022
840f7f8
changie result
jpmmcneill Sep 19, 2022
cd04a91
Merge branch 'main' into jpmmcneill/bigquery-type-boolean
jpmmcneill Sep 22, 2022
27d2817
dont pull main
jpmmcneill Sep 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Features-20220919-232721.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Features
body: add type_boolean as a data type macro
time: 2022-09-19T23:27:21.864912+01:00
custom:
Author: jpmmcneill
Issue: "315"
PR: "313"
1 change: 1 addition & 0 deletions dbt/adapters/bigquery/column.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ class BigQueryColumn(Column):
"TIMESTAMP": "TIMESTAMP",
"FLOAT": "FLOAT64",
"INTEGER": "INT64",
"BOOLEAN": "BOOLEAN",
"RECORD": "RECORD",
}
fields: List[Self] # type: ignore
Expand Down
5 changes: 5 additions & 0 deletions tests/functional/adapter/utils/test_data_types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
from dbt.tests.adapter.utils.data_types.test_type_numeric import BaseTypeNumeric
from dbt.tests.adapter.utils.data_types.test_type_string import BaseTypeString
from dbt.tests.adapter.utils.data_types.test_type_timestamp import BaseTypeTimestamp
from dbt.tests.adapter.utils.data_types.test_type_boolean import BaseTypeBoolean


class TestTypeBigInt(BaseTypeBigInt):
Expand All @@ -31,4 +32,8 @@ class TestTypeString(BaseTypeString):
class TestTypeTimestamp(BaseTypeTimestamp):
pass


class TestTypeBoolean(BaseTypeBoolean):
pass