Remove python 3.8 for dbt 1.8 (#10869)

* Remove Python 3.8 from various places (#10861) * Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <peter.webb@dbtlabs.com> * Revise test to reflect change in dbt-common * Add another unit test. --------- Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
dbt-labs · Oct 18, 2024 · 1285917 · 1285917
1 parent 924ce2d
commit 1285917
Show file tree

Hide file tree

Showing 11 changed files with 20 additions and 22 deletions.
diff --git a/.changes/unreleased/Under the Hood-20241016-144056.yaml b/.changes/unreleased/Under the Hood-20241016-144056.yaml
@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Remove support and testing for Python 3.8, which is now EOL.
+time: 2024-10-16T14:40:56.451972-04:00
+custom:
+ Author: gshank peterallenwebb
+ Issue: "10861"
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -52,7 +52,7 @@ jobs:
  - name: Set up Python
  uses: actions/setup-python@v5
  with:
- python-version: '3.8'
+ python-version: '3.9'
 
  - name: Install python dependencies
  run: |
@@ -74,7 +74,7 @@ jobs:
  strategy:
  fail-fast: false
  matrix:
- python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]
+ python-version: [ "3.9", "3.10", "3.11", "3.12" ]
 
  env:
  TOXENV: "unit"
@@ -139,7 +139,7 @@ jobs:
  - name: generate include
  id: generate-include
  run: |
- INCLUDE=('"python-version":"3.8","os":"windows-latest"' '"python-version":"3.8","os":"macos-12"' )
+ INCLUDE=('"python-version":"3.9","os":"windows-latest"' '"python-version":"3.9","os":"macos-12"' )
  INCLUDE_GROUPS="["
  for include in ${INCLUDE[@]}; do
  for group in $(seq 1 ${{ env.PYTHON_INTEGRATION_TEST_WORKERS }}); do
@@ -161,7 +161,7 @@ jobs:
  strategy:
  fail-fast: false
  matrix:
- python-version: [ "3.8", "3.9", "3.10", "3.11", "3.12" ]
+ python-version: [ "3.9", "3.10", "3.11", "3.12" ]
  os: [ubuntu-20.04]
  split-group: ${{ fromJson(needs.integration-metadata.outputs.split-groups) }}
  include: ${{ fromJson(needs.integration-metadata.outputs.include) }}
@@ -263,7 +263,7 @@ jobs:
  - name: Set up Python
  uses: actions/setup-python@v5
  with:
- python-version: '3.8'
+ python-version: '3.9'
 
  - name: Install python dependencies
  run: |

diff --git a/.github/workflows/model_performance.yml b/.github/workflows/model_performance.yml
@@ -150,7 +150,7 @@ jobs:
  - name: Setup Python
  uses: actions/setup-python@v5
  with:
- python-version: "3.8"
+ python-version: "3.9"
 
  - name: Install dbt
  run: pip install dbt-postgres==${{ needs.set-variables.outputs.release_id }}

diff --git a/.github/workflows/schema-check.yml b/.github/workflows/schema-check.yml
@@ -37,7 +37,7 @@ jobs:
  - name: Set up Python
  uses: actions/setup-python@v5
  with:
- python-version: 3.8
+ python-version: 3.9
 
  - name: Checkout dbt repo
  uses: actions/checkout@v4

diff --git a/.github/workflows/structured-logging-schema-check.yml b/.github/workflows/structured-logging-schema-check.yml
@@ -76,7 +76,7 @@ jobs:
  - name: Setup Python
  uses: actions/setup-python@v5
  with:
- python-version: "3.8"
+ python-version: "3.9"
 
  - name: Install python dependencies
  run: |

diff --git a/.github/workflows/test-repeater.yml b/.github/workflows/test-repeater.yml
@@ -27,7 +27,6 @@ on:
  description: 'Version of Python to Test Against'
  type: choice
  options:
- - '3.8'
  - '3.9'
  - '3.10'
  - '3.11'

diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml
@@ -3,7 +3,7 @@
 
 exclude: ^(core/dbt/docs/build/|core/dbt/common/events/types_pb2.py|core/dbt/events/core_types_pb2.py|core/dbt/adapters/events/adapter_types_pb2.py)
 
-# Force all unspecified python hooks to run python 3.8
+# Force all unspecified python hooks to run python 3.9
 default_language_version:
  python: python3
 

diff --git a/Dockerfile.test b/Dockerfile.test
@@ -33,9 +33,6 @@ RUN apt-get update \
  python-is-python3 \
  python-dev-is-python3 \
  python3-pip \
- python3.8 \
- python3.8-dev \
- python3.8-venv \
  python3.9 \
  python3.9-dev \
  python3.9-venv \

diff --git a/core/setup.py b/core/setup.py
@@ -2,9 +2,9 @@
 import os
 import sys
 
-if sys.version_info < (3, 8):
+if sys.version_info < (3, 9):
  print("Error: dbt does not support this version of Python.")
- print("Please upgrade to Python 3.8 or higher.")
+ print("Please upgrade to Python 3.9 or higher.")
  sys.exit(1)
 
 
@@ -93,11 +93,10 @@
  "Operating System :: Microsoft :: Windows",
  "Operating System :: MacOS :: MacOS X",
  "Operating System :: POSIX :: Linux",
- "Programming Language :: Python :: 3.8",
  "Programming Language :: Python :: 3.9",
  "Programming Language :: Python :: 3.10",
  "Programming Language :: Python :: 3.11",
  "Programming Language :: Python :: 3.12",
  ],
- python_requires=">=3.8",
+ python_requires=">=3.9",
 )
diff --git a/tests/functional/logging/test_logging.py b/tests/functional/logging/test_logging.py
@@ -99,7 +99,7 @@ def test_invalid_event_value(project, logs_dir):
  with pytest.raises(Exception) as excinfo:
  fire_event(InvalidOptionYAML(option_name=1))
 
- assert str(excinfo.value) == "[InvalidOptionYAML]: Unable to parse dict {'option_name': 1}"
+ assert str(excinfo.value).startswith("[InvalidOptionYAML]: Unable to parse")
 
 
 class TestNodeInfo:

diff --git a/tests/unit/test_events.py b/tests/unit/test_events.py
@@ -537,10 +537,7 @@ def test_bad_serialization():
  with pytest.raises(Exception) as excinfo:
  types.Note(param_event_doesnt_have="This should break")
 
- assert (
- str(excinfo.value)
- == "[Note]: Unable to parse dict {'param_event_doesnt_have': 'This should break'}"
- )
+ assert str(excinfo.value).startswith("[Note]: Unable to parse")
 
 
 def test_single_run_error():