Remove Python 3.8 from various places #10861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10861 +/- ##
==========================================
- Coverage 89.19% 89.13% -0.07%
==========================================
Files 183 183
Lines 23434 23434
==========================================
- Hits 20903 20888 -15
- Misses 2531 2546 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
I don't see why "unit test / python 3.8" was trying to run. |
|
Ran the Tests and Code Checks pipeline successfully with these changes: https://github.com/dbt-labs/dbt-core/actions/runs/11371519059 |
peterallenwebb
approved these changes
Oct 16, 2024
|
It won't let us merge with that failing "unit test / python 3.8". Also I'm wondering if there's anything that needs to be done about codecov? |
peterallenwebb
added a commit
that referenced
this pull request
Oct 16, 2024
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <peter.webb@dbtlabs.com>
peterallenwebb
added a commit
that referenced
this pull request
Oct 16, 2024
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <peter.webb@dbtlabs.com>
peterallenwebb
added a commit
that referenced
this pull request
Oct 16, 2024
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <peter.webb@dbtlabs.com>
peterallenwebb
added a commit
that referenced
this pull request
Oct 16, 2024
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <peter.webb@dbtlabs.com>
peterallenwebb
added a commit
that referenced
this pull request
Oct 16, 2024
* Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <peter.webb@dbtlabs.com>
peterallenwebb
added a commit
that referenced
this pull request
Oct 18, 2024
* Remove Python 3.8 from various places (#10861) * Remove Python 3.8 from various places * Add changelog entry. --------- Co-authored-by: Peter Allen Webb <peter.webb@dbtlabs.com> * Revise test to reflect change in dbt-common * Add another unit test. --------- Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
peterallenwebb
added a commit
that referenced
this pull request
Oct 18, 2024
peterallenwebb
added a commit
that referenced
this pull request
Oct 18, 2024
peterallenwebb
added a commit
that referenced
this pull request
Oct 18, 2024
peterallenwebb
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
Solution
Checklist