Skip to content

Commit

Permalink
re-lint imports section of test_base_resource.py (#10095)
Browse files Browse the repository at this point in the history
This was done by running `pre-commit run --all`. That this was needed
is a temporary glitch in how our `Tests and Code Checks` github action
works on PRs. Basically we added `isort` to the pre-commit hooks recently, and
this does additional linting/formatting on our imports.

People reasonably have branches which were started prior to `isort` being
part of the pre-commit hooks on main. Thus, unless those branches get caught
up to main, the github action on associated PRs won't run `isort` because
it doesn't exist on those branchs. Once everyone gets their local `main`
branch updated (I suspect this might take a few days) this problem will go
away.
  • Loading branch information
QMalcolm authored May 6, 2024
1 parent 3e8f2f1 commit 65791e4
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/unit/artifacts/test_base_resource.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from dataclasses import dataclass

import pytest

from dbt.artifacts.resources.base import BaseResource
Expand Down

0 comments on commit 65791e4

Please sign in to comment.